Re: Review Request 23208: Patch for KAFKA-1512

2014-07-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/#review47841 --- Ship it! Ship It! - Jun Rao On July 14, 2014, 8:28 p.m., Jay

Re: Review Request 23208: Patch for KAFKA-1512

2014-07-14 Thread Jay Kreps
On July 6, 2014, 7:34 p.m., Jun Rao wrote: I think what I have may be right. My understanding is that - InetAddress is an IP address - SocketAddress, InetSocketAddress are host/port pairs (basically) getInetAddress gets the remote ip address whereas getRemoteAddress gets the

Re: Review Request 23208: Patch for KAFKA-1512

2014-07-14 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/ --- (Updated July 14, 2014, 8:28 p.m.) Review request for kafka. Bugs:

Re: Review Request 23208: Patch for KAFKA-1512

2014-07-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/#review47362 --- core/src/main/scala/kafka/network/SocketServer.scala

Re: Review Request 23208: Patch for KAFKA-1512

2014-07-03 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/ --- (Updated July 3, 2014, 10:18 p.m.) Review request for kafka. Bugs:

Review Request 23208: Patch for KAFKA-1512

2014-07-01 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/ --- Review request for kafka. Bugs: KAFKA-1512

Re: Review Request 23208: Patch for KAFKA-1512

2014-07-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/#review47151 --- Ship it! Looks good to me, although the connection quotas will not