---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23208/#review47841
---
Ship it!
Ship It!
- Jun Rao
On July 14, 2014, 8:28 p.m., Jay
On July 6, 2014, 7:34 p.m., Jun Rao wrote:
I think what I have may be right. My understanding is that
- InetAddress is an IP address
- SocketAddress, InetSocketAddress are host/port pairs (basically)
getInetAddress gets the remote ip address whereas getRemoteAddress gets the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23208/
---
(Updated July 14, 2014, 8:28 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23208/#review47362
---
core/src/main/scala/kafka/network/SocketServer.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23208/
---
(Updated July 3, 2014, 10:18 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23208/
---
Review request for kafka.
Bugs: KAFKA-1512
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23208/#review47151
---
Ship it!
Looks good to me, although the connection quotas will not