On July 28, 2014, 3:16 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java,
lines 56-57
https://reviews.apache.org/r/23339/diff/3/?file=641061#file641061line56
We need to pass in the createTopic flag in this constructor too. In the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23339/#review48822
---
Thanks for the patch. A few more comments below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23339/
---
(Updated July 24, 2014, 12:07 a.m.)
Review request for kafka.
Bugs:
On July 22, 2014, 6:52 p.m., Jun Rao wrote:
core/src/main/scala/kafka/client/ClientUtils.scala, lines 86-87
https://reviews.apache.org/r/23339/diff/2/?file=639404#file639404line86
Perhaps this method can be named better since it may not just be for
the consumer.
Changed it to
On July 22, 2014, 6:52 p.m., Jun Rao wrote:
Thanks for the patch and doing the rebasing. Some comments below.
Thanks for the review. I've noticed NetworkClient.java always uses the
latestVersion of an api. There doesn't look like the way I can send specific
version of a request since the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23339/
---
(Updated July 22, 2014, 5:27 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23339/#review48397
---
Thanks for the patch and doing the rebasing. Some comments below.
