Re: Review Request 24856: Patch for KAFKA-1601

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24856/ --- (Updated Aug. 20, 2014, 3:57 p.m.) Review request for kafka. Bugs: KAFKA-1601

Re: Review Request 24856: Patch for KAFKA-1601

> On Aug. 20, 2014, 1:31 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ConsumerTransactionBuffer.scala, line 7 > > > > > > We should probably just grab this from TxRequestTypes in the api > > package fo

Re: Review Request 24856: Patch for KAFKA-1601

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24856/ --- (Updated Aug. 20, 2014, 4:10 a.m.) Review request for kafka. Bugs: KAFKA-1601

Re: Review Request 24856: Patch for KAFKA-1601

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24856/#review51050 --- Looks good overall, although you are probably aware of the caveats -

Review Request 24856: Patch for KAFKA-1601

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24856/ --- Review request for kafka. Bugs: KAFKA-1601 https://issues.apache.org/jira/b