Re: Review Request 27990: Patch for KAFKA-1751

2014-11-27 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/ --- (Updated Nov. 27, 2014, 11:39 a.m.) Review request for kafka. Bugs:

Re: Review Request 27990: Patch for KAFKA-1751

2014-11-24 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/#review62922 --- In addition to ensuring that the reassignment command doesn't

Re: Review Request 27990: Patch for KAFKA-1751

2014-11-19 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/ --- (Updated Nov. 19, 2014, 9:57 a.m.) Review request for kafka. Bugs:

Re: Review Request 27990: Patch for KAFKA-1751

2014-11-17 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/ --- (Updated Nov. 17, 2014, 2:25 p.m.) Review request for kafka. Bugs:

Re: Review Request 27990: Patch for KAFKA-1751

2014-11-17 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/ --- (Updated Nov. 17, 2014, 2:33 p.m.) Review request for kafka. Bugs:

Re: Review Request 27990: Patch for KAFKA-1751

2014-11-17 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/#review61855 --- Ship it! Looks good! Two minor readability comments from my side,

Re: Review Request 27990: Patch for KAFKA-1751

2014-11-15 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/#review61644 --- Looks great! Few comments and nitpicks below.

Review Request 27990: Patch for KAFKA-1751

2014-11-13 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/ --- Review request for kafka. Bugs: KAFKA-1751