Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-12-10 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- (Updated Dec. 11, 2014, 6:11 a.m.) Review request for kafka. Changes ---

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-12-10 Thread Ashish Singh
On Nov. 26, 2014, 1:05 a.m., Neha Narkhede wrote: Can you add a few test cases? Done. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/#review63083

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-12-10 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- (Updated Dec. 11, 2014, 6:16 a.m.) Review request for kafka. Changes ---

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-11-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/#review63083 --- Can you add a few test cases? - Neha Narkhede On Nov. 23, 2014,

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-11-22 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- (Updated Nov. 23, 2014, 5:37 a.m.) Review request for kafka. Changes ---

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-11-22 Thread Ashish Singh
On Nov. 20, 2014, 2:01 p.m., Gwen Shapira wrote: We have multiple functions for creating znodes in ZkUtils. persistent, epehmeral, sequence, etc... Does it make sense to put the validation in a function and use it in all create functions? Thanks for the review Gwen. Added a class

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-11-20 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/#review62349 --- We have multiple functions for creating znodes in ZkUtils.

Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-11-16 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- Review request for kafka. Repository: kafka Description --- KAFKA-1664:

Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot

2014-11-16 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- (Updated Nov. 16, 2014, 7:49 p.m.) Review request for kafka. Repository: