Re: Review Request 29692: Patch for kafka-1841

2015-01-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/#review67667 --- Thanks for patching this. Looks good overall.

Re: Review Request 29692: Patch for kafka-1841

2015-01-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/ --- (Updated Jan. 12, 2015, 10:30 p.m.) Review request for kafka. Bugs:

Re: Review Request 29692: Patch for kafka-1841

2015-01-12 Thread Jun Rao
On Jan. 12, 2015, 7:47 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/KafkaApis.scala, line 88 https://reviews.apache.org/r/29692/diff/3/?file=815275#file815275line88 We should probably also change OffsetCommitRequest.responseFor . The issue is that if you get an

Re: Review Request 29692: Patch for kafka-1841

2015-01-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/#review67775 --- Ship it! Reversed an earlier comment, but up to you to pick which

Re: Review Request 29692: Patch for kafka-1841

2015-01-09 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/ --- (Updated Jan. 9, 2015, 10:36 p.m.) Review request for kafka. Bugs:

Re: Review Request 29692: Patch for kafka-1841

2015-01-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/ --- (Updated Jan. 8, 2015, 11:07 p.m.) Review request for kafka. Bugs:

Review Request 29692: Patch for kafka-1841

2015-01-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/ --- Review request for kafka. Bugs: kafka-1841

Re: Review Request 29692: Patch for kafka-1841

2015-01-07 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29692/#review67149 --- Jun, have you had a chance to test the 0.8.1 client against the

Re: Review Request 29692: Patch for kafka-1841

2015-01-07 Thread Jun Rao
On Jan. 8, 2015, 2:15 a.m., Neha Narkhede wrote: Jun, have you had a chance to test the 0.8.1 client against the 0.8.2 server, as we had discussed earlier today? Yes, it works as expected with the following test program built with the 0.8.1 branch. package kafka import