Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74973 --- Tong, could you address Jun's last comments before committing? -

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
Yes. It was addressed in the latest patch set. A private method called toPositive was added so that the partition selection is preserved cross this and previous versions. Thanks Sent from my iPhone On Mar 4, 2015, at 12:49 AM, Guozhang Wang wangg...@gmail.com wrote: This is an

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
On March 3, 2015, 4:48 p.m., Guozhang Wang wrote: Tong, could you address Jun's last comments before committing? Yes. absolutely, doing it now. Thanks. - Tong --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/ --- (Updated March 4, 2015, midnight) Review request for kafka. Bugs: KAFKA-1988

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
AM Subject: Re: Review Request 31566: Patch for KAFKA-1988 Sent by: Guozhang Wang nore...@reviews.apache.org --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74973

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-03 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/ --- (Updated March 4, 2015, 12:03 a.m.) Review request for kafka. Bugs:

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-02 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74889 --- Ship it! This looks good assuming the other patch, centralizes the

Re: Review Request 31566: Patch for KAFKA-1988

2015-03-02 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74893 --- Thanks for the patch. A couple of minor comments below.

Re: Review Request 31566: Patch for KAFKA-1988

2015-02-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/#review74688 --- Ship it! Ship It! - Guozhang Wang On Feb. 27, 2015, 11:16 p.m.,

Review Request 31566: Patch for KAFKA-1988

2015-02-27 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31566/ --- Review request for kafka. Bugs: KAFKA-1988