---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31806/#review78892
---
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31806/#review78891
---
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31806/
---
(Updated March 25, 2015, 7:45 a.m.)
Review request for kafka.
Bugs:
On March 12, 2015, 1:04 p.m., Guozhang Wang wrote:
core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 67
https://reviews.apache.org/r/31806/diff/2/?file=889521#file889521line67
The name is a bit misleading since the port value is actually fixed.
Maybe we can renamed it to
On March 12, 2015, 1:04 p.m., Guozhang Wang wrote:
core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 67
https://reviews.apache.org/r/31806/diff/2/?file=889521#file889521line67
The name is a bit misleading since the port value is actually fixed.
Maybe we can renamed it to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31806/#review76190
---
The patch does not apply, could you rebase?
On March 9, 2015, 3:26 a.m., Eric Olander wrote:
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala,
line 274
https://reviews.apache.org/r/31806/diff/1/?file=887521#file887521line274
This is confusing - this inner loop doesn't use i so I'm not sure why
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31806/
---
(Updated March 9, 2015, 6:41 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31806/#review75654
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31806/
---
Review request for kafka.
Bugs: KAFKA-1501
10 matches
Mail list logo
