On May 4, 2015, 5:31 p.m., Neha Narkhede wrote:
clients/src/main/java/org/apache/kafka/common/serialization/Serializer.java,
line 25
https://reviews.apache.org/r/33760/diff/2/?file=947511#file947511line25
This and also the Deserializer should extend Configurable too right?
We
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/#review82399
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/#review82292
---
Ship it!
Ship It!
- Guozhang Wang
On May 1, 2015, 10:42 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/
---
(Updated May 1, 2015, 10:42 p.m.)
Review request for kafka.
Bugs: KAFKA-2121
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/
---
Review request for kafka.
Bugs: KAFKA-2121
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/#review82280
---
Pointed out two minor issues, but otherwise LGTM.
