Re: Review Request 34070: Patch for KAFKA-2186

2015-05-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/#review83472 --- Ship it! Ship It! - Joel Koshy On May 12, 2015, 1:39 a.m.,

Re: Review Request 34070: Patch for KAFKA-2186

2015-05-12 Thread Joel Koshy
On May 12, 2015, 2:31 a.m., Aditya Auradkar wrote: core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java, line 73 https://reviews.apache.org/r/34070/diff/1/?file=955930#file955930line73 How does this work if the consumer doesn't own these partitions? Is it possible to

Review Request 34070: Patch for KAFKA-2186

2015-05-11 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/ --- Review request for kafka. Bugs: KAFKA-2186

Re: Review Request 34070: Patch for KAFKA-2186

2015-05-11 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/#review83343 --- Ship it!