Re: Review Request 34273: remove roundrobin identical topic constraint in consumer coordinator

2015-05-19 Thread Onur Karaman
On May 18, 2015, 9:46 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/coordinator/PartitionAssignor.scala, lines 87-89 https://reviews.apache.org/r/34273/diff/1/?file=961395#file961395line87 I feel this logic's irregular assignment result may make it a bit harder to reason

Re: Review Request 34273: remove roundrobin identical topic constraint in consumer coordinator

2015-05-19 Thread Guozhang Wang
On May 18, 2015, 9:46 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/coordinator/PartitionAssignor.scala, lines 87-89 https://reviews.apache.org/r/34273/diff/1/?file=961395#file961395line87 I feel this logic's irregular assignment result may make it a bit harder to reason

Re: Review Request 34273: remove roundrobin identical topic constraint in consumer coordinator

2015-05-18 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34273/#review84223 --- core/src/main/scala/kafka/coordinator/PartitionAssignor.scala

Review Request 34273: remove roundrobin identical topic constraint in consumer coordinator

2015-05-15 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34273/ --- Review request for kafka. Bugs: KAFKA-2196