---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34415/#review88074
---
Thanks for the latest patch. A couple more minor comments.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34415/
---
(Updated June 16, 2015, 7:28 p.m.)
Review request for kafka.
Bugs:
On June 16, 2015, 3:52 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/requests/ConsumerMetadataRequest.java,
lines 49-50
https://reviews.apache.org/r/34415/diff/3/?file=984580#file984580line49
Perhaps it's better to include the request name in the error
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34415/
---
(Updated June 15, 2015, 6:55 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34415/#review85223
---
Thanks for the patch. Just one more comment blow.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34415/#review84850
---
Thanks for the patch. A few comments below.
On May 22, 2015, 4:37 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java,
lines 45-62
https://reviews.apache.org/r/34415/diff/1/?file=963952#file963952line45
Could we change all requests to use parse(buffer, versionId)?
Agree.
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34415/
---
Review request for kafka.
Bugs: KAFKA-2195
