Re: Review Request 34493: Patch for KAFKA-2211

> On Aug. 21, 2015, 2:31 p.m., Ismael Juma wrote: > > Thanks for this Parth. I did an initial pass where I left a number comments > > (many of them style-related, see http://kafka.apache.org/coding-guide.html > > for reference). I know, we should have a tool that checks some of these > >

Re: Review Request 34493: Patch for KAFKA-2211

> On Aug. 23, 2015, 9:28 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/security/auth/SimpleAclAuthorizer.scala, lines > > 55-57 > > > > > > To be consistent with how we pass in configs for pluggable components,

Re: Review Request 34493: Patch for KAFKA-2211

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34493/#review96128 --- Thanks for the patch. A few comments below.

Re: Review Request 34493: Patch for KAFKA-2211

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34493/#review96042 --- Thanks for this Parth. I did an initial pass where I left a number

Re: Review Request 34493: Patch for KAFKA-2211

On Aug. 21, 2015, 2:31 p.m., Ismael Juma wrote: Thanks for this Parth. I did an initial pass where I left a number comments (many of them style-related, see http://kafka.apache.org/coding-guide.html for reference). I know, we should have a tool that checks some of these things

Re: Review Request 34493: Patch for KAFKA-2211

On Aug. 21, 2015, 2:31 p.m., Ismael Juma wrote: Thanks for this Parth. I did an initial pass where I left a number comments (many of them style-related, see http://kafka.apache.org/coding-guide.html for reference). I know, we should have a tool that checks some of these things

Review Request 34493: Patch for KAFKA-2211

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34493/ --- Review request for kafka. Bugs: KAFKA-2211