Re: Review Request 35201: Fix KAFKA-2253

2015-06-11 Thread Jiangjie Qin
On June 11, 2015, 1:07 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/DelayedOperation.scala, lines 264-266 https://reviews.apache.org/r/35201/diff/2/?file=980805#file980805line264 Not sure if we need this check. Since all writes to watchersForKey are sync-ed, it's ok to

Re: Review Request 35201: Fix KAFKA-2253

2015-06-11 Thread Onur Karaman
On June 11, 2015, 1:07 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/DelayedOperation.scala, lines 264-266 https://reviews.apache.org/r/35201/diff/2/?file=980805#file980805line264 Not sure if we need this check. Since all writes to watchersForKey are sync-ed, it's ok to

Re: Review Request 35201: Fix KAFKA-2253

2015-06-11 Thread Jun Rao
On June 11, 2015, 1:07 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/DelayedOperation.scala, lines 264-266 https://reviews.apache.org/r/35201/diff/2/?file=980805#file980805line264 Not sure if we need this check. Since all writes to watchersForKey are sync-ed, it's ok to

Re: Review Request 35201: Fix KAFKA-2253

2015-06-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review87495 --- core/src/main/scala/kafka/server/DelayedOperation.scala

Re: Review Request 35201: Fix KAFKA-2253

2015-06-08 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review87065 --- Ship it! Ship It! - Jiangjie Qin On June 8, 2015, 6:47 p.m.,

Re: Review Request 35201: Fix KAFKA-2253

2015-06-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/ --- (Updated June 8, 2015, 6:47 p.m.) Review request for kafka. Bugs: KAFKA-2253

Re: Review Request 35201: Fix KAFKA-2253

2015-06-08 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review87077 --- Ship it! Ship It! - Onur Karaman On June 8, 2015, 6:47 p.m.,

Re: Review Request 35201: Fix KAFKA-2253

2015-06-08 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review86987 --- core/src/main/scala/kafka/server/DelayedOperation.scala

Review Request 35201: Fix KAFKA-2253

2015-06-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/ --- Review request for kafka. Bugs: KAFKA-2253