Re: Review Request 35347: Patch for KAFKA-2249

2015-06-17 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/ --- (Updated June 18, 2015, 12:35 a.m.) Review request for kafka. Bugs:

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-17 Thread Gwen Shapira
On June 11, 2015, 11:22 p.m., Jun Rao wrote: core/src/main/scala/kafka/server/KafkaConfig.scala, lines 964-965 https://reviews.apache.org/r/35347/diff/1/?file=982452#file982452line964 Is this castable since props is a map? Also, toProps is really just used by LogConfig which

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-17 Thread Gwen Shapira
On June 11, 2015, 11:22 p.m., Jun Rao wrote: core/src/main/scala/kafka/server/KafkaConfig.scala, lines 964-965 https://reviews.apache.org/r/35347/diff/1/?file=982452#file982452line964 Is this castable since props is a map? Also, toProps is really just used by LogConfig which

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/#review87981 --- Also, could you add a main() method in KafkaConfig like that in

Re: Review Request 35347: Patch for KAFKA-2249

2015-06-11 Thread Gwen Shapira
On June 11, 2015, 11:22 p.m., Jun Rao wrote: core/src/main/scala/kafka/server/KafkaConfig.scala, line 485 https://reviews.apache.org/r/35347/diff/1/?file=982452#file982452line485 Is there a particular reason to change this to a long? It is used as LONG everywhere in the code. On

Review Request 35347: Patch for KAFKA-2249

2015-06-11 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/ --- Review request for kafka. Bugs: KAFKA-2249