---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/#review91899
---
Could you rebase? Seems some previous commits get reflected in your
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/
---
(Updated July 16, 2015, 6:56 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/
---
(Updated July 16, 2015, 6:50 p.m.)
Review request for kafka.
Bugs:
On July 16, 2015, 4:54 p.m., Guozhang Wang wrote:
Could you rebase? Seems some previous commits get reflected in your latest
patch.
Done.
Also I have an update for BeforeAndAfter\BeforeAndAfterEach traits. These
traits requires any of Suite traits to defined for the class also. E.g.
On July 16, 2015, 4:54 p.m., Guozhang Wang wrote:
Could you rebase? Seems some previous commits get reflected in your latest
patch.
Alexander Pakulov wrote:
Done.
Also I have an update for BeforeAndAfter\BeforeAndAfterEach traits. These
traits requires any of Suite
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/#review91986
---
I can consistently get 8 unit test failues with your patch, all of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/
---
(Updated July 15, 2015, 11:58 p.m.)
Review request for kafka.
Bugs:
On July 14, 2015, 2:49 a.m., Guozhang Wang wrote:
Some general comments:
1. Regarding the @Before and @After annotations, one suggestion from the
JIRA was that we remove any annotations other than @Test itself but use
scalatest features (for example,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/#review91575
---
Some general comments:
1. Regarding the @Before and @After
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/
---
(Updated June 18, 2015, 6:53 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35615/
---
Review request for kafka.
Bugs: KAFKA-1782
11 matches
Mail list logo