Re: Review Request 35615: Patch for KAFKA-1782

2015-07-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/#review91899 --- Could you rebase? Seems some previous commits get reflected in your

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-16 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- (Updated July 16, 2015, 6:56 p.m.) Review request for kafka. Bugs:

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-16 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- (Updated July 16, 2015, 6:50 p.m.) Review request for kafka. Bugs:

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-16 Thread Alexander Pakulov
On July 16, 2015, 4:54 p.m., Guozhang Wang wrote: Could you rebase? Seems some previous commits get reflected in your latest patch. Done. Also I have an update for BeforeAndAfter\BeforeAndAfterEach traits. These traits requires any of Suite traits to defined for the class also. E.g.

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-16 Thread Guozhang Wang
On July 16, 2015, 4:54 p.m., Guozhang Wang wrote: Could you rebase? Seems some previous commits get reflected in your latest patch. Alexander Pakulov wrote: Done. Also I have an update for BeforeAndAfter\BeforeAndAfterEach traits. These traits requires any of Suite

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/#review91986 --- I can consistently get 8 unit test failues with your patch, all of

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-15 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- (Updated July 15, 2015, 11:58 p.m.) Review request for kafka. Bugs:

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-15 Thread Alexander Pakulov
On July 14, 2015, 2:49 a.m., Guozhang Wang wrote: Some general comments: 1. Regarding the @Before and @After annotations, one suggestion from the JIRA was that we remove any annotations other than @Test itself but use scalatest features (for example,

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/#review91575 --- Some general comments: 1. Regarding the @Before and @After

Re: Review Request 35615: Patch for KAFKA-1782

2015-06-18 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- (Updated June 18, 2015, 6:53 p.m.) Review request for kafka. Bugs:

Review Request 35615: Patch for KAFKA-1782

2015-06-18 Thread Alexander Pakulov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- Review request for kafka. Bugs: KAFKA-1782