Re: Review Request 35850: Patch for KAFKA-2301

2015-07-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review93346 --- Ship it! Ship It! - Guozhang Wang On July 2, 2015, 4:04 p.m.,

Re: Review Request 35850: Patch for KAFKA-2301

2015-07-02 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review90199 --- core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala (line

Re: Review Request 35850: Patch for KAFKA-2301

2015-07-01 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/ --- (Updated July 2, 2015, 12:46 a.m.) Review request for kafka. Bugs:

Re: Review Request 35850: Patch for KAFKA-2301

2015-06-29 Thread Ashish Singh
On June 25, 2015, 1:06 a.m., Ewen Cheslack-Postava wrote: Is this what was intended by deprecate? I'm not sure there's been serious discussion about this yet, but this doesn't really deprecate the command in a compatible way -- just changing to ConsumerGroupCommand requires changing

Review Request 35850: Patch for KAFKA-2301

2015-06-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/ --- Review request for kafka. Bugs: KAFKA-2301

Re: Review Request 35850: Patch for KAFKA-2301

2015-06-24 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review89301 --- Is this what was intended by deprecate? I'm not sure there's been