[jira] [Commented] (KAFKA-374) Move to java CRC32 implementation

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528932#comment-13528932 ] Jay Kreps commented on KAFKA-374: - Yes, this should go on trunk. Move to

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528948#comment-13528948 ] Jay Kreps commented on KAFKA-664: - This seems to iterate the whole list for every

Re: Objections to doing this in 0.8?

2012-12-11 Thread Prashanth Menon
I don't mind ... On Mon, Dec 10, 2012 at 6:05 PM, Jay Kreps jay.kr...@gmail.com wrote: https://issues.apache.org/jira/browse/KAFKA-667 Goal would just be forward compatibility with a more sane naming scheme... -Jay

[jira] [Updated] (KAFKA-667) Rename .highwatermark file

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-667: Attachment: KAFKA-667-v1.patch Trivial patch to change the name of the highwatermark file. Ready for

[jira] [Commented] (KAFKA-667) Rename .highwatermark file

2012-12-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529140#comment-13529140 ] Jun Rao commented on KAFKA-667: --- Thanks for the patch. +1. Rename

[jira] [Commented] (KAFKA-636) Make log segment delete asynchronous

2012-12-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529142#comment-13529142 ] Jun Rao commented on KAFKA-636: --- Thanks for the patch. +1. Just one minor comment: 1.

[jira] [Commented] (KAFKA-667) Rename .highwatermark file

2012-12-11 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529186#comment-13529186 ] Neha Narkhede commented on KAFKA-667: - +1 Rename .highwatermark file

[jira] [Resolved] (KAFKA-636) Make log segment delete asynchronous

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-636. - Resolution: Fixed Checked in with the suggested changes. Make log segment delete

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

2012-12-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529313#comment-13529313 ] Joel Koshy commented on KAFKA-664: -- Agreed that we should checkin this fix + the

[jira] [Assigned] (KAFKA-631) Implement log compaction

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps reassigned KAFKA-631: --- Assignee: Jay Kreps Implement log compaction Key:

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

2012-12-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529489#comment-13529489 ] Joel Koshy commented on KAFKA-664: -- One problem with the updated patch is the following:

[jira] [Created] (KAFKA-669) Kafka server sends producer response with an error code for successfully completed produce requests leading to spurious FailedToSendMessageException on the producer

2012-12-11 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-669: --- Summary: Kafka server sends producer response with an error code for successfully completed produce requests leading to spurious FailedToSendMessageException on the producer Key: KAFKA-669

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

2012-12-11 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v1.patch First pass at adding a commit offset request Add an

[jira] [Commented] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-11 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529566#comment-13529566 ] Neha Narkhede commented on KAFKA-646: - +1 on v5. I think we can check this in and wait

[jira] [Commented] (KAFKA-669) Kafka server sends producer response with an error code for successfully completed produce requests leading to spurious FailedToSendMessageException on the producer

2012-12-11 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529570#comment-13529570 ] Neha Narkhede commented on KAFKA-669: - This issue was caused by KAFKA-654 on the leader

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529583#comment-13529583 ] Jay Kreps commented on KAFKA-657: - This looks great. To confirm, the final format for the

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529589#comment-13529589 ] Jay Kreps commented on KAFKA-657: - Oh yes, two other things: 1. We don't have a response in

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-11 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529613#comment-13529613 ] David Arthur commented on KAFKA-657: I'm fine working on the rest of 1. 1a is simple

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529617#comment-13529617 ] Jay Kreps commented on KAFKA-657: - The existing API describes the offset ranges contained

[jira] [Commented] (KAFKA-604) Add missing metrics in 0.8

2012-12-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529626#comment-13529626 ] Swapnil Ghike commented on KAFKA-604: - Wow, this is going to be fun. :) Unfortunately

[jira] [Commented] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529639#comment-13529639 ] Jun Rao commented on KAFKA-646: --- Thanks for patch v5. A few more comments: 50. Config: 50.1