[jira] [Commented] (KAFKA-598) decouple fetch size from max message size

2012-12-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536167#comment-13536167 ] Jun Rao commented on KAFKA-598: --- Thanks for patch v3. Some comments. 30. AbstractFetcherThre

[jira] [Commented] (KAFKA-598) decouple fetch size from max message size

2012-12-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536227#comment-13536227 ] Joel Koshy commented on KAFKA-598: -- Thanks for taking the time to review. 30. I think wha

[jira] [Commented] (KAFKA-598) decouple fetch size from max message size

2012-12-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536339#comment-13536339 ] Jun Rao commented on KAFKA-598: --- I took a look at the patch again. Yes, you are right. Your l

[jira] [Created] (KAFKA-677) Retention process gives exception if an empty segment is chosen for collection

2012-12-19 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-677: --- Summary: Retention process gives exception if an empty segment is chosen for collection Key: KAFKA-677 URL: https://issues.apache.org/jira/browse/KAFKA-677 Project: Kafka

[jira] [Commented] (KAFKA-598) decouple fetch size from max message size

2012-12-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536705#comment-13536705 ] Joel Koshy commented on KAFKA-598: -- 33.2: not really, because that would violate the new c