[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019904#comment-14019904 ] Jun Rao commented on KAFKA-1298: Thanks for the patch. This patch seems to have made the

Re: Review Request 21937: Patch for KAFKA-1316

2014-06-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/#review44663 --- Thanks for the patch. Could we write short description in the

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020007#comment-14020007 ] Sriharsha Chintalapani commented on KAFKA-1298: --- [~junrao] This patch made

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020016#comment-14020016 ] Neha Narkhede commented on KAFKA-1298: -- [~sriharsha] The unit tests use some utility

[jira] [Closed] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1443. Add delete topic to topic commands and update DeleteTopicCommand

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44913 --- Ship it! Ship It! - Guozhang Wang On June 6, 2014, 5:42 a.m.,

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-06 Thread Rajasekar Elango
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44914 --- Ship it! Looks like the changes we did on this commit

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-06 Thread Rajasekar Elango
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44916 --- Ship it! Looks like the changes we did on this commit

[jira] [Updated] (KAFKA-1482) Transient test failures for kafka.admin.DeleteTopicTest

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1482: - Labels: newbie (was: ) Transient test failures for kafka.admin.DeleteTopicTest

[jira] [Updated] (KAFKA-1483) Split Brain about Leader Partitions

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1483: - Labels: newbie++ (was: ) Split Brain about Leader Partitions

[jira] [Updated] (KAFKA-1483) Split Brain about Leader Partitions

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1483: - Issue Type: Improvement (was: Bug) Split Brain about Leader Partitions

Review Request 22309: Patch for KAFKA-1298

2014-06-06 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22309/ --- Review request for kafka. Bugs: KAFKA-1298

[jira] [Updated] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1298: -- Attachment: KAFKA-1298.patch Controlled shutdown tool doesn't seem to work

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020046#comment-14020046 ] Sriharsha Chintalapani commented on KAFKA-1298: --- Created reviewboard

[jira] [Commented] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020050#comment-14020050 ] Neha Narkhede commented on KAFKA-1469: -- +1. Thanks for the patch. Util.abs function

[jira] [Updated] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1469: - Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to trunk Util.abs

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020054#comment-14020054 ] Sriharsha Chintalapani commented on KAFKA-1298: --- [~nehanarkhede] Yes I added

[jira] [Closed] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1469. Util.abs function does not return correct absolute values for negative values

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-06 Thread Rajasekar Elango
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44927 --- config/server.properties

Re: Review Request 21937: Patch for KAFKA-1316

2014-06-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/#review44921 ---

Re: Review Request 21937: Patch for KAFKA-1316

2014-06-06 Thread Guozhang Wang
On June 6, 2014, 3:18 a.m., Neha Narkhede wrote: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, line 58 https://reviews.apache.org/r/21937/diff/3/?file=603197#file603197line58 Now we will end up with potentially two Senders - one for the

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-06-06 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020084#comment-14020084 ] Andrew Olson commented on KAFKA-824: I have reported this issue to the zkclient

Build failed in Jenkins: Kafka-trunk #200

2014-06-06 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/200/changes Changes: [neha.narkhede] KAFKA-1443 Add delete topic option to topic commands; reviewed by Neha Narkhede [neha.narkhede] KAFKA-1469 Util.abs function does not return correct absolute values for negative values; patched by Guozhang Wang

[jira] [Commented] (KAFKA-1475) Kafka consumer stops LeaderFinder/FetcherThreads, but application does not know

2014-06-06 Thread Hang Qi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020139#comment-14020139 ] Hang Qi commented on KAFKA-1475: Hi Guozhang, Thanks for your reply. I checked the

[jira] [Commented] (KAFKA-1475) Kafka consumer stops LeaderFinder/FetcherThreads, but application does not know

2014-06-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020148#comment-14020148 ] Guozhang Wang commented on KAFKA-1475: -- In this case are the consumer using the same

[jira] [Commented] (KAFKA-1475) Kafka consumer stops LeaderFinder/FetcherThreads, but application does not know

2014-06-06 Thread Hang Qi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020269#comment-14020269 ] Hang Qi commented on KAFKA-1475: Not exactly. Let me recap. In original description,

Re: Review Request 19731: Patch for KAFKA-1328

2014-06-06 Thread Baran Nohutcuoglu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review44964 --- If a consumer fails to establish a connection to zookeeper, how is

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020446#comment-14020446 ] Jun Rao commented on KAFKA-1298: Sriharsha, Thanks for the patch. Do we know why the

NoReplicaOnlineException with 0.8.1.1

2014-06-06 Thread Prakash Gowri Shankor
Hi, I am running 0.8.1.1 with one Zookeeper and one broker. I created a partition 'test2' as below: /kafka-topics.sh --create --zookeeper localhost:2181 --replication-factor 1 --partitions 3 --topic test2 I noticed this exception in the state-change.log. Why is this occuring ? Should I be

[jira] [Commented] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-06-06 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020461#comment-14020461 ] Sriharsha Chintalapani commented on KAFKA-1298: --- [~junrao] Shouldn't we take

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

2014-06-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020462#comment-14020462 ] Jun Rao commented on KAFKA-1438: Thanks for the patch. It seems that after the patch, the

[jira] [Commented] (KAFKA-1475) Kafka consumer stops LeaderFinder/FetcherThreads, but application does not know

2014-06-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020463#comment-14020463 ] Guozhang Wang commented on KAFKA-1475: -- I see. This seems to me a ZkClient issue,

[jira] [Commented] (KAFKA-1475) Kafka consumer stops LeaderFinder/FetcherThreads, but application does not know

2014-06-06 Thread Hang Qi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020533#comment-14020533 ] Hang Qi commented on KAFKA-1475: Not often. Mainly happens on some long full GC on the

Re: Review Request 21588: Fix KAFKA-1430, round two

2014-06-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21588/#review44998 --- Overall, the patch looks pretty good to me. Some comments below.

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020696#comment-14020696 ] Neha Narkhede commented on KAFKA-1438: -- [~sriharsha] To rephrase Jun's finding, the

[jira] [Updated] (KAFKA-1430) Purgatory redesign

2014-06-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1430: - Assignee: Guozhang Wang Purgatory redesign -- Key:

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

2014-06-06 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020703#comment-14020703 ] Sriharsha Chintalapani commented on KAFKA-1438: --- [~junrao] [~nehanarkhede]