[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-21 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068333#comment-14068333 ] Dmitry Bugaychenko commented on KAFKA-1414: --- According our experience in

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-21 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068336#comment-14068336 ] Anton Karamanov commented on KAFKA-1414: Dir-level parallelization will prevent

[jira] [Comment Edited] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068442#comment-14068442 ] nicu marasoiu edited comment on KAFKA-1549 at 7/21/14 12:07 PM:

[jira] [Commented] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068442#comment-14068442 ] nicu marasoiu commented on KAFKA-1549: -- 2. Indeed, to avoid that overhead and make it

[jira] [Updated] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1549: - Attachment: (was: KAFKA-1549__dead_brokers_coming_in_the_TopicMetadataResponse_.patch)

[jira] [Comment Edited] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068442#comment-14068442 ] nicu marasoiu edited comment on KAFKA-1549 at 7/21/14 12:09 PM:

[jira] [Assigned] (KAFKA-1419) cross build for scala 2.11

2014-07-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein reassigned KAFKA-1419: Assignee: Ivan Lyutov cross build for scala 2.11 --

[jira] [Updated] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1549: - Attachment:

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068561#comment-14068561 ] Jay Kreps commented on KAFKA-1414: -- [~arhagnel] I share your concern. I just want to make

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-21 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068566#comment-14068566 ] Anton Karamanov commented on KAFKA-1414: [~jkreps], we are testing different

[jira] [Commented] (KAFKA-1546) Automate replica lag tuning

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068575#comment-14068575 ] Jay Kreps commented on KAFKA-1546: -- I think I was being a little vague. What I was trying

[jira] [Comment Edited] (KAFKA-1546) Automate replica lag tuning

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068575#comment-14068575 ] Jay Kreps edited comment on KAFKA-1546 at 7/21/14 2:41 PM: --- I

[jira] [Commented] (KAFKA-1546) Automate replica lag tuning

2014-07-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068606#comment-14068606 ] Jun Rao commented on KAFKA-1546: Yes, that works. So we will have to return enough info in

Re: Review Request 23705: Addressing Jun's comments

2014-07-21 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/ --- (Updated July 21, 2014, 3:16 p.m.) Review request for kafka. Summary

Review Request 23740: Patch for KAFKA-1462

2014-07-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23740/ --- Review request for kafka. Bugs: KAFKA-1462

[jira] [Updated] (KAFKA-1462) Add new request and response formats for the new consumer and coordinator communication

2014-07-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1462: --- Attachment: KAFKA-1462.patch Add new request and response formats for the new consumer and coordinator

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: KAFKA-1192_2014-07-21_20:44:08.patch Enable DumpLogSegments tool to deserialize

[jira] [Commented] (KAFKA-1462) Add new request and response formats for the new consumer and coordinator communication

2014-07-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068613#comment-14068613 ] Jun Rao commented on KAFKA-1462: There is actually an issue with the patch. The server

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068611#comment-14068611 ] Manikumar Reddy commented on KAFKA-1192: Updated reviewboard

[jira] [Commented] (KAFKA-1462) Add new request and response formats for the new consumer and coordinator communication

2014-07-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068614#comment-14068614 ] Jun Rao commented on KAFKA-1462: Created reviewboard https://reviews.apache.org/r/23740/

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: (was: KAFKA-1192_2014-07-19_13:56:18.patch) Enable DumpLogSegments tool to

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: (was: KAFKA-1192.patch) Enable DumpLogSegments tool to deserialize messages

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068623#comment-14068623 ] Manikumar Reddy commented on KAFKA-1192: Introduced new command-line parameter

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Assignee: Neha Narkhede (was: Manikumar Reddy) Change the status of the JIRA to Patch

[jira] [Commented] (KAFKA-1059) Improve the patch review tool to use OAuth for JIRA access

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068651#comment-14068651 ] Manikumar Reddy commented on KAFKA-1059: [nehanarkhede] I am unable to contact

[jira] [Comment Edited] (KAFKA-1059) Improve the patch review tool to use OAuth for JIRA access

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068651#comment-14068651 ] Manikumar Reddy edited comment on KAFKA-1059 at 7/21/14 3:44 PM:

[jira] [Updated] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option

2014-07-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1493: --- Priority: Blocker (was: Major) Affects Version/s: 0.8.2 Marking this as a blocker for 0.8.2

[jira] [Commented] (KAFKA-1399) Drop Scala 2.8.x support

2014-07-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068674#comment-14068674 ] Jun Rao commented on KAFKA-1399: LinkedIn no longer depends on scala 2.8.x. If there is no

[jira] [Commented] (KAFKA-1553) TopicMetadataResponse.brokers not read in scala producer?

2014-07-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068708#comment-14068708 ] Jun Rao commented on KAFKA-1553: Yes, that's the behavior of the old producer. We are

[jira] [Commented] (KAFKA-1546) Automate replica lag tuning

2014-07-21 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068731#comment-14068731 ] Sriram Subramanian commented on KAFKA-1546: --- the lagBegin does not persist

[jira] [Created] (KAFKA-1554) Corrupt index found on clean startup

2014-07-21 Thread Alexis Midon (JIRA)
Alexis Midon created KAFKA-1554: --- Summary: Corrupt index found on clean startup Key: KAFKA-1554 URL: https://issues.apache.org/jira/browse/KAFKA-1554 Project: Kafka Issue Type: Bug

Review Request 23743: Force fsync in OffsetCheckpoint

2014-07-21 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23743/ --- Review request for kafka. Bugs: KAFKA-1539

[jira] [Updated] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1539: - Attachment: KAFKA-1539.patch Due to OS caching Kafka might loose offset files which causes full reset

[jira] [Commented] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068831#comment-14068831 ] Jay Kreps commented on KAFKA-1539: -- Created reviewboard

Re: Review Request 23743: Force fsync in OffsetCheckpoint

2014-07-21 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23743/#review48256 --- Ship it! Ship It! - Sriram Subramanian On July 21, 2014, 5:23

[jira] [Commented] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068837#comment-14068837 ] Jay Kreps commented on KAFKA-1539: -- This is a really good catch, were clearly thinking

[jira] [Commented] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-21 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068848#comment-14068848 ] Sriram Subramanian commented on KAFKA-1539: --- I had encountered the same issue in

[jira] [Assigned] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-1192: Assignee: Guozhang Wang (was: Manikumar Reddy) Assign back to Guozhang for review.

Re: Review Request 23567: Patch for KAFKA-1522

2014-07-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review48259 --- core/src/main/scala/kafka/api/TransactionRequest.scala

[jira] [Commented] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2014-07-21 Thread Alexis Midon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1406#comment-1406 ] Alexis Midon commented on KAFKA-1112: - I created

[jira] [Issue Comment Deleted] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1549: - Comment: was deleted (was: Implemented point 1 and reverted for point 2, attached patch) dead

[jira] [Comment Edited] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068442#comment-14068442 ] nicu marasoiu edited comment on KAFKA-1549 at 7/21/14 5:53 PM:

[jira] [Comment Edited] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068442#comment-14068442 ] nicu marasoiu edited comment on KAFKA-1549 at 7/21/14 6:05 PM:

[jira] [Comment Edited] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068442#comment-14068442 ] nicu marasoiu edited comment on KAFKA-1549 at 7/21/14 6:06 PM:

[jira] [Commented] (KAFKA-1553) TopicMetadataResponse.brokers not read in scala producer?

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068944#comment-14068944 ] nicu marasoiu commented on KAFKA-1553: -- Hi, what does the new producer mean, is a

Re: Review Request 23705: Addressing Jun's comments

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/#review48265 --- core/src/main/scala/kafka/tools/DumpLogSegments.scala

[jira] [Comment Edited] (KAFKA-1553) TopicMetadataResponse.brokers not read in scala producer?

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068944#comment-14068944 ] nicu marasoiu edited comment on KAFKA-1553 at 7/21/14 6:18 PM:

[jira] [Resolved] (KAFKA-1553) TopicMetadataResponse.brokers not read in scala producer?

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu resolved KAFKA-1553. -- Resolution: Duplicate TopicMetadataResponse.brokers not read in scala producer?

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review48261 --- core/src/main/scala/kafka/admin/TopicCommand.scala

[jira] Subscription: outstanding kafka patches

2014-07-21 Thread jira
Issue Subscription Filter: outstanding kafka patches (112 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1550 Patch review tool should use git format-patch to generate patch https://issues.apache.org/jira/browse/KAFKA-1550

[jira] [Commented] (KAFKA-1553) TopicMetadataResponse.brokers not read in scala producer?

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069141#comment-14069141 ] Jay Kreps commented on KAFKA-1553: -- We have been working on rewriting the clients. We

Review Request 23767: Fix KAFKA-1430

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/ --- Review request for kafka. Bugs: KAFKA-1430

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069162#comment-14069162 ] Guozhang Wang commented on KAFKA-1430: -- Created reviewboard

[jira] [Updated] (KAFKA-1430) Purgatory redesign

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1430: - Attachment: KAFKA-1430.patch Purgatory redesign -- Key:

Re: Review Request 23767: Fix KAFKA-1430

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/ --- (Updated July 21, 2014, 7:53 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069171#comment-14069171 ] Guozhang Wang commented on KAFKA-1430: -- Updated reviewboard

[jira] [Updated] (KAFKA-1430) Purgatory redesign

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1430: - Attachment: KAFKA-1430_2014-07-21_12:53:39.patch Purgatory redesign --

[jira] [Commented] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069189#comment-14069189 ] nicu marasoiu commented on KAFKA-1549: -- added an implementation without the implicit:

[jira] [Updated] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-21 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1549: - Attachment:

Re: Review Request 23593: Fix KAFKA-1533: Address Jun's comments

2014-07-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23593/#review48285 --- clients/src/main/java/org/apache/kafka/clients/NetworkClient.java

Re: Review Request 23593: Fix KAFKA-1533: Address Jun's comments

2014-07-21 Thread Guozhang Wang
On July 21, 2014, 8:24 p.m., Neha Narkhede wrote: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 81 https://reviews.apache.org/r/23593/diff/1/?file=633954#file633954line81 Could you please address my previous rb comment about the naming convention? It is

Re: Review Request 23697: Fix KAFKA-1533: Address Jun and Neha's comments

2014-07-21 Thread Guozhang Wang
On July 20, 2014, 11:32 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, lines 376-377 https://reviews.apache.org/r/23697/diff/1/?file=635933#file635933line376 Thinking a bit more about this. There are two possibility after adding the

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

2014-07-21 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069394#comment-14069394 ] Jonathan Natkins commented on KAFKA-1420: - I was starting to work on this JIRA,

Re: Review Request 23697: Fix KAFKA-1533: Address Jun and Neha's comments

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23697/ --- (Updated July 21, 2014, 10:45 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1533) transient unit test failure in ProducerFailureHandlingTest

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1533: - Attachment: KAFKA-1533_2014-07-21_15:45:58.patch transient unit test failure in

[jira] [Commented] (KAFKA-1533) transient unit test failure in ProducerFailureHandlingTest

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069462#comment-14069462 ] Guozhang Wang commented on KAFKA-1533: -- Updated reviewboard

[jira] [Resolved] (KAFKA-322) Remove one-off Send objects

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-322. - Resolution: Fixed This was fixed a long while back, cleaning up. Remove one-off Send objects

Re: Review Request 23740: Patch for KAFKA-1462

2014-07-21 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23740/#review48309 --- Ship it! Ship It! - Jay Kreps On July 21, 2014, 3:17 p.m., Jun

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069473#comment-14069473 ] Guozhang Wang commented on KAFKA-1420: -- Hi Jonathan, TestUtils.createBrokerConfigs()

Re: Review Request 23740: Patch for KAFKA-1462

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23740/#review48315 --- Ship it! Ship It! - Guozhang Wang On July 21, 2014, 3:17 p.m.,

[jira] [Commented] (KAFKA-1537) add request.required.acks=-2 to require acks from all replicas

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069509#comment-14069509 ] Daniel Compton commented on KAFKA-1537: --- Adding to that, you will have less

Re: Review Request 23442: Updated WIP simple consumer

2014-07-21 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23442/ --- (Updated July 21, 2014, 11:44 p.m.) Review request for kafka. Summary

[jira] [Updated] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1330: - Attachment: KAFKA-1330_2014-07-21_16:44:23.patch Implement subscribe(TopicPartition...partitions) in

[jira] [Commented] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069525#comment-14069525 ] Jay Kreps commented on KAFKA-1330: -- Updated reviewboard

[jira] [Resolved] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1539. -- Resolution: Fixed I'm checking this in since it seems to fix a clear problem, but [~arhagnel] it

Re: Review Request 23655: Patch for KAFKA-687

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/#review48319 --- core/src/main/scala/kafka/consumer/PartitionAllocator.scala

[jira] [Commented] (KAFKA-1537) add request.required.acks=-2 to require acks from all replicas

2014-07-21 Thread Jiang Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069607#comment-14069607 ] Jiang Wu commented on KAFKA-1537: - I agree that adding acks=-2 to require acks from all

[jira] [Resolved] (KAFKA-1537) add request.required.acks=-2 to require acks from all replicas

2014-07-21 Thread Jiang Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiang Wu resolved KAFKA-1537. - Resolution: Not a Problem add request.required.acks=-2 to require acks from all replicas

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

2014-07-21 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069626#comment-14069626 ] Jonathan Natkins commented on KAFKA-1420: - Thanks for the context, Guozhang. So in

[jira] [Updated] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Compton updated KAFKA-1517: -- Status: Open (was: Patch Available) Messages is a required argument to Producer Performance

[jira] [Updated] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Compton updated KAFKA-1517: -- Status: Patch Available (was: Open) Messages is a required argument to Producer Performance

[jira] [Issue Comment Deleted] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Compton updated KAFKA-1517: -- Comment: was deleted (was: From 3cb6dd13ab487b72ff73f375617a372360418708 Mon Sep 17 00:00:00

[jira] [Updated] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Compton updated KAFKA-1517: -- Status: Patch Available (was: Open) From 3cb6dd13ab487b72ff73f375617a372360418708 Mon Sep 17

[jira] [Updated] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Compton updated KAFKA-1517: -- Status: Patch Available (was: Open) I've attached a patch for this. Let me know if the patch

[jira] [Updated] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Compton updated KAFKA-1517: -- Status: Open (was: Patch Available) Messages is a required argument to Producer Performance

[jira] [Updated] (KAFKA-1517) Messages is a required argument to Producer Performance Test

2014-07-21 Thread Daniel Compton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Compton updated KAFKA-1517: -- Attachment: 0001-KAFKA-1517-Make-messages-a-required-argument.patch Messages is a required

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

2014-07-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069699#comment-14069699 ] Guozhang Wang commented on KAFKA-1420: -- TestUtils.createTopic can be used here also.