Re: Review Request 26994: Patch for KAFKA-1719

2014-10-24 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ --- (Updated Oct. 24, 2014, 7:56 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1719) Make mirror maker exit when one consumer/producer thread exits.

2014-10-24 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1719: Attachment: KAFKA-1719_2014-10-24_00:56:06.patch Make mirror maker exit when one consumer/producer

[jira] [Commented] (KAFKA-1719) Make mirror maker exit when one consumer/producer thread exits.

2014-10-24 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182573#comment-14182573 ] Jiangjie Qin commented on KAFKA-1719: - Updated reviewboard

[jira] [Updated] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-24 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Tretyakov updated KAFKA-1481: -- Attachment: KAFKA-1481_2014-10-24_14-14-35.patch.patch Stop using dashes AND

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-24 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182670#comment-14182670 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi Jun, thx for your feedback

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Joe Stein
Jun, I updated the https://people.apache.org/~joestein/kafka-0.8.2-beta-candidate1/java-doc/ with the contents of kafka-clients-0.8.2-beta-javadoc.jar There weren't any artifact changes so I don't think we need a new release candidate ... we can extend the vote to Monday if we don't get a

[jira] [Created] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-10-24 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1729: -- Summary: add doc for Kafka-based offset management in 0.8.2 Key: KAFKA-1729 URL: https://issues.apache.org/jira/browse/KAFKA-1729 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-1730) add the doc for the new java producer in 0.8.2

2014-10-24 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1730: -- Summary: add the doc for the new java producer in 0.8.2 Key: KAFKA-1730 URL: https://issues.apache.org/jira/browse/KAFKA-1730 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-1730) add the doc for the new java producer in 0.8.2

2014-10-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182974#comment-14182974 ] Jun Rao commented on KAFKA-1730: We can probably just add a link to the java doc of the

[jira] [Created] (KAFKA-1731) add config/jmx changes in 0.8.2 doc

2014-10-24 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1731: -- Summary: add config/jmx changes in 0.8.2 doc Key: KAFKA-1731 URL: https://issues.apache.org/jira/browse/KAFKA-1731 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-1728) update 082 docs

2014-10-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182986#comment-14182986 ] Jun Rao commented on KAFKA-1728: Need to include the doc change in KAFKA-1555. update

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Jun Rao
Joe, Thanks. +1 on RC 1 from me. Jun On Fri, Oct 24, 2014 at 5:22 AM, Joe Stein joe.st...@stealth.ly wrote: Jun, I updated the https://people.apache.org/~joestein/kafka-0.8.2-beta-candidate1/java-doc/ with the contents of kafka-clients-0.8.2-beta-javadoc.jar There weren't any artifact

082 docs

2014-10-24 Thread Jun Rao
Hi, Everyone, I created KAFKA-1728 to track the doc changes in the 082 release. If anyone wants to help, you can sign up on one of the sub tasks. Joel Koshy, Do you want to update the doc for offset management? Thanks, Jun

Build failed in Jenkins: Kafka-trunk #317

2014-10-24 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/317/changes Changes: [neha.narkhede] KAFKA-1725 Configuration file bugs in system tests add noise to output and break a few tests; reviewed by Neha Narkhede -- [...truncated 1080 lines...]

[jira] [Updated] (KAFKA-1725) Configuration file bugs in system tests add noise to output and break a few tests

2014-10-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1725: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for fixing the system

[jira] [Closed] (KAFKA-1725) Configuration file bugs in system tests add noise to output and break a few tests

2014-10-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1725. Configuration file bugs in system tests add noise to output and break a few tests

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Gwen Shapira
+1 (non-official community vote). Kicked the tires of the binary release. Works out of the box as expected, new producer included. On Fri, Oct 24, 2014 at 5:22 AM, Joe Stein joe.st...@stealth.ly wrote: Jun, I updated the https://people.apache.org/~joestein/kafka-0.8.2-beta-candidate1/java-doc/

[jira] [Updated] (KAFKA-1719) Make mirror maker exit when one consumer/producer thread exits.

2014-10-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1719: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patches. Pushed

[jira] [Commented] (KAFKA-1688) Add authorization interface and naive implementation

2014-10-24 Thread Michael Herstine (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183061#comment-14183061 ] Michael Herstine commented on KAFKA-1688: - Apologies-- yes, I should have said

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Neha Narkhede
+1 (binding) Verified the quickstart, docs, unit tests on the source and binary release. Thanks, Neha On Fri, Oct 24, 2014 at 9:26 AM, Gwen Shapira gshap...@cloudera.com wrote: +1 (non-official community vote). Kicked the tires of the binary release. Works out of the box as expected, new

Build failed in Jenkins: Kafka-trunk #318

2014-10-24 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/318/changes Changes: [neha.narkhede] KAFKA-1719 Make mirror maker exit when one consumer/producer thread exits; reviewed by Neha Narkhede, Joel Koshy and Guozhang Wang -- [...truncated 1284 lines...]

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Darion Yaphet
+1 New Sender is Added ~ 2014-10-25 1:18 GMT+08:00 Neha Narkhede neha.narkh...@gmail.com: +1 (binding) Verified the quickstart, docs, unit tests on the source and binary release. Thanks, Neha On Fri, Oct 24, 2014 at 9:26 AM, Gwen Shapira gshap...@cloudera.com wrote: +1 (non-official

Re: 082 docs

2014-10-24 Thread Joel Koshy
Yes I can update the doc for offset management, and review Gwen's doc on min.isr/durability guarantees On Fri, Oct 24, 2014 at 09:10:19AM -0700, Jun Rao wrote: Hi, Everyone, I created KAFKA-1728 to track the doc changes in the 082 release. If anyone wants to help, you can sign up on one of

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183086#comment-14183086 ] Joel Koshy commented on KAFKA-1555: --- Jun, you can just diff configuration.html,

[jira] [Commented] (KAFKA-1683) Implement a session concept in the socket server

2014-10-24 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183089#comment-14183089 ] Gwen Shapira commented on KAFKA-1683: - Reviewed Zookeeper SASL code to get better

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Gwen Shapira
What's the plan for moving from beta to stable? Time based? Or are there any patches that need to go in? On Tue, Oct 21, 2014 at 1:58 PM, Joe Stein joe.st...@stealth.ly wrote: This is the first candidate for release of Apache Kafka 0.8.2-beta Release Notes for the 0.8.2-beta release

Re: 082 docs

2014-10-24 Thread Gwen Shapira
I'll upload a clean patch today to make the review easier. On Fri, Oct 24, 2014 at 10:32 AM, Joel Koshy jjkosh...@gmail.com wrote: Yes I can update the doc for offset management, and review Gwen's doc on min.isr/durability guarantees On Fri, Oct 24, 2014 at 09:10:19AM -0700, Jun Rao wrote:

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Neha Narkhede
Gwen, Production grade testing is the plan for moving from beta to stable. It will be great if companies that pick up beta, deploy it, use it and report bugs. LinkedIn will be helping do this within a 4-5 weeks timeframe, if possible. Thanks, Neha On Fri, Oct 24, 2014 at 10:36 AM, Gwen Shapira

Re: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Gwen Shapira
So the criteria is: At least one company doing a serious testing cycle on the beta and possibly running it in production for few weeks? On Fri, Oct 24, 2014 at 10:43 AM, Neha Narkhede neha.narkh...@gmail.com wrote: Gwen, Production grade testing is the plan for moving from beta to stable. It

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1555: Attachment: KAFKA-1555-DOCS.1.patch Attaching a clean version of the docs - just the diffs from

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-24 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179014#comment-14179014 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/24/14 6:21 PM:

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183304#comment-14183304 ] Joel Koshy commented on KAFKA-1555: --- Looks good - I just have a few minor edits to what

RE: [VOTE] 0.8.2-beta Release Candidate 1

2014-10-24 Thread Seshadri, Balaji
We are testing 0.8.2 branch now in dev-int. Balaji -Original Message- From: Neha Narkhede [mailto:neha.narkh...@gmail.com] Sent: Friday, October 24, 2014 12:06 PM To: dev@kafka.apache.org Subject: Re: [VOTE] 0.8.2-beta Release Candidate 1 So the criteria is: At least one company doing

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Kyle Banker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183382#comment-14183382 ] Kyle Banker commented on KAFKA-1555: The new durability docs looks great so far. Here

[jira] [Comment Edited] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Kyle Banker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183382#comment-14183382 ] Kyle Banker edited comment on KAFKA-1555 at 10/24/14 8:03 PM: --

[jira] [Comment Edited] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Kyle Banker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183382#comment-14183382 ] Kyle Banker edited comment on KAFKA-1555 at 10/24/14 8:03 PM: --

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Kyle Banker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183393#comment-14183393 ] Kyle Banker commented on KAFKA-1555: I like the section on Availability and Durability

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1555: Attachment: KAFKA-1555-DOCS.2.patch Uploading new docs, containing edits by [~kbanker] and

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183411#comment-14183411 ] Gwen Shapira commented on KAFKA-1555: - [~jjkoshy]: * I did not make the suggested

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-24 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183514#comment-14183514 ] Jay Kreps commented on KAFKA-1710: -- Ah, gotcha, so that was per ms not per us. Question

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-24 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183545#comment-14183545 ] Jay Kreps commented on KAFKA-1710: -- The reason I ask is because the per-partition lock is

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-24 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183648#comment-14183648 ] Bhavesh Mistry commented on KAFKA-1710: --- [~jkreps], Yes , I did this test with 75

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-24 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183659#comment-14183659 ] Guozhang Wang commented on KAFKA-1501: -- Thanks Chris, I also got the same conclusion

High Level Consumer Iterator IllegalStateException Issue

2014-10-24 Thread Bhavesh Mistry
HI Kafka Community , I am using kafka trunk source code and I get following exception. What could cause the iterator to have FAILED state. Please let me know how I can fix this issue. *java.lang.IllegalStateException: Iterator is in failed stateat

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-24 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183775#comment-14183775 ] Jay Kreps commented on KAFKA-1710: -- You could try some profiling and see if you see any

Re: High Level Consumer Iterator IllegalStateException Issue

2014-10-24 Thread Neha Narkhede
Which version of Kafka are you using on the consumer? On Fri, Oct 24, 2014 at 4:14 PM, Bhavesh Mistry mistry.p.bhav...@gmail.com wrote: HI Kafka Community , I am using kafka trunk source code and I get following exception. What could cause the iterator to have FAILED state. Please let me

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-24 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183787#comment-14183787 ] Jay Kreps commented on KAFKA-1501: -- Oh, man, my heart is broken, I was sure that was