Hey Jai, see below
On Fri, May 29, 2015 at 3:03 AM, Jaikiran Pai jai.forums2...@gmail.com
wrote:
Hi Joe,
Comments inline.
On Friday 29 May 2015 12:15 PM, Joe Stein wrote:
see below
On Fri, May 29, 2015 at 2:25 AM, Jaikiran Pai jai.forums2...@gmail.com
wrote:
Could someone please
On May 29, 2015, 7:11 a.m., Joe Stein wrote:
core/src/main/scala/kafka/utils/ZkUtils.scala, line 39
https://reviews.apache.org/r/34394/diff/2/?file=971310#file971310line39
if we are going to add this it should be exposed as a configuration and
written up in a KIP. We can't hard
Yeah, the same cleaning mechanism will be carried over.
1. Are we introducing a new Java API for the config change protocol and if
so where will that appear? Is that going to be part of the java api in the
admin api kip? Let's document that.
Yeah, we need to introduce a new Java API for the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34394/#review85691
---
core/src/main/scala/kafka/utils/ZkUtils.scala
Hi Joe,
Comments inline.
On Friday 29 May 2015 12:15 PM, Joe Stein wrote:
see below
On Fri, May 29, 2015 at 2:25 AM, Jaikiran Pai jai.forums2...@gmail.com
wrote:
Could someone please look at these few review requests and let me know if
any changes are needed:
Minor edit: I meant that we should expect change notifications in the old
format made earlier, but should perhaps ignore them. After the upgrade is done,
older versions of AdminTools can no longer be used to make config changes.
Aditya
From: Aditya
[
https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564610#comment-14564610
]
chenshangan commented on KAFKA-188:
---
@Jay Kreps I think we could provide a alternative,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34805/
---
Review request for kafka.
Bugs: KAFKA-2213
[
https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-2213:
---
Assignee: Manikumar Reddy
Status: Patch Available (was: Open)
Log cleaner should
[
https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564676#comment-14564676
]
Manikumar Reddy commented on KAFKA-2213:
Uploaded a patch which writes the
Guys,
I won't be able to attend next meeting. But in the latest patch for KIP-4
Phase 1
I didn't even evolve TopicMetadataRequest to v1 since we won't be able
to change config with AlterTopicRequest, hence with this patch TMR will
still
return isr. Taking this into account I think yes - it would
[
https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi resolved KAFKA-2228.
-
Resolution: Duplicate
Delete me
-
Key: KAFKA-2228
[
https://issues.apache.org/jira/browse/KAFKA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi resolved KAFKA-2227.
-
Resolution: Duplicate
Delete me
-
Key: KAFKA-2227
[
https://issues.apache.org/jira/browse/KAFKA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi updated KAFKA-2227:
Summary: Delete me (was: Phase 1: Requests and KafkaApis)
Delete me
-
[
https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi reassigned KAFKA-2228:
---
Assignee: (was: Andrii Biletskyi)
Delete me
-
Key:
[
https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi updated KAFKA-2228:
Summary: Delete me (was: Phase 1: Requests and KafkaApis)
Delete me
-
GitHub user sslavic opened a pull request:
https://github.com/apache/kafka/pull/67
Ignore gradle wrapper download directory
This patch adds gradle wrapper download directory to .gitignore
You can merge this pull request into a Git repository by running:
$ git pull
+1 on discussing this on next KIP hangout. I will update KIP-24 before that.
On Fri, May 29, 2015 at 3:40 AM, Andrii Biletskyi
andrii.bilets...@stealth.ly wrote:
Guys,
I won't be able to attend next meeting. But in the latest patch for KIP-4
Phase 1
I didn't even evolve
[
https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564610#comment-14564610
]
chenshangan edited comment on KAFKA-188 at 5/29/15 3:49 PM:
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564980#comment-14564980
]
Ashish K Singh commented on KAFKA-1367:
---
[~junrao] can we add this to the agenda of
On May 29, 2015, 1:56 a.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, line 106
https://reviews.apache.org/r/34734/diff/2/?file=973959#file973959line106
Since this is under synchronized, it seems that remove should always
return true?
Oh. You are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/
---
(Updated May 29, 2015, 5:49 p.m.)
Review request for kafka.
Bugs: KAFKA-2226
[
https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564676#comment-14564676
]
Manikumar Reddy edited comment on KAFKA-2213 at 5/29/15 6:58 PM:
Hi,
Can someone please review the following CRs:
Public entities and interfaces with changes to KafkaAPI and KafkaServer:
https://reviews.apache.org/r/34492/diff/
Actual Implementation: https://reviews.apache.org/r/34493/diff/
CLI: https://reviews.apache.org/r/34494/diff/
Thanks
Parth
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2226:
Attachment: KAFKA-2226_2015-05-29_10:49:34.patch
NullPointerException in
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 64-65
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line64
Could you explain a bit why this is needed? It seems that we can add
the entry either when
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565133#comment-14565133
]
Yasuhiro Matsuda commented on KAFKA-2226:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33196/
---
(Updated May 29, 2015, 6:11 p.m.)
Review request for kafka.
Bugs: KAFKA-2123
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565078#comment-14565078
]
Jun Rao commented on KAFKA-1367:
Yes.
Broker topic metadata not kept in sync with
[
https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2199:
-
Attachment: KAFKA-2199_2015-05-29_11:00:44.patch
Make signing artifacts
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 64-65
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line64
Could you explain a bit why this is needed? It seems that we can add
the entry either when
[
https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565155#comment-14565155
]
Ewen Cheslack-Postava commented on KAFKA-2199:
--
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34369/
---
(Updated May 29, 2015, 6 p.m.)
Review request for kafka.
Bugs: KAFKA-2199
Parth,
I will take a look.
Thanks,
Jun
On Fri, May 29, 2015 at 10:49 AM, Parth Brahmbhatt
pbrahmbh...@hortonworks.com wrote:
Hi,
Can someone please review the following CRs:
Public entities and interfaces with changes to KafkaAPI and KafkaServer:
[
https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565181#comment-14565181
]
Jay Kreps commented on KAFKA-188:
-
@chenshangan The issue with using data size was that it
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565164#comment-14565164
]
Ewen Cheslack-Postava commented on KAFKA-2123:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2123:
-
Attachment: KAFKA-2123_2015-05-29_11:11:05.patch
Make new consumer offset commit
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565522#comment-14565522
]
Yasuhiro Matsuda commented on KAFKA-2226:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565723#comment-14565723
]
chenshangan commented on KAFKA-188:
---
[~jkreps]
I recommend we instead leave this as it
[
https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-2199:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed.
Make signing artifacts
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33196/#review85824
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34369/#review85823
---
Ship it!
Ship It!
- Jay Kreps
On May 29, 2015, 6 p.m., Ewen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/
---
(Updated May 29, 2015, 10:10 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/
---
(Updated May 29, 2015, 10:04 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2226:
Attachment: KAFKA-2226_2015-05-29_15:04:35.patch
NullPointerException in
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565538#comment-14565538
]
Yasuhiro Matsuda commented on KAFKA-2226:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2226:
Attachment: KAFKA-2226_2015-05-29_15:10:24.patch
NullPointerException in
[
https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565837#comment-14565837
]
Abhishek Nigam commented on KAFKA-1778:
---
I believe what you are suggesting is that
[
https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-2213:
--
Reviewer: Joel Koshy
Log cleaner should write compacted messages using configured compression type
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/#review85764
---
Thanks for the new patch. A few more comments below.
Hi Kafka Dev Team,
I would appreciate your feedback on moving producer partition selection
from producer to Broker. Also, please do let me know what is correct
process of collecting feedback from Kafka Dev team and/or community.
Thanks,
Bhavesh
On Tue, May 26, 2015 at 11:54 AM, Bhavesh
On May 29, 2015, 7:08 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/Timer.scala, line 54
https://reviews.apache.org/r/34734/diff/3/?file=974375#file974375line54
canceled = cancelled
I will fix it. By the way, canceled is a legitimate spelling in American
English.
-
52 matches
Mail list logo
