[
https://issues.apache.org/jira/browse/KAFKA-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596298#comment-14596298
]
Aditya Auradkar commented on KAFKA-2293:
[~junrao] Can you take a look at this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34789/#review88796
---
Ship it!
I did not review it thoroughly but the design looks clean
[
https://issues.apache.org/jira/browse/KAFKA-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2288:
Attachment: KAFKA-2288_2015-06-22_10:02:27.patch
Follow-up to KAFKA-2249 - reduce logging and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35677/
---
(Updated June 22, 2015, 5:02 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596296#comment-14596296
]
Aditya A Auradkar commented on KAFKA-2293:
--
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-2235.
Resolution: Fixed
Fix Version/s: 0.8.3
Assignee: Ivan Simoneko (was: Jay Kreps)
Thanks for
[
https://issues.apache.org/jira/browse/KAFKA-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2293:
-
Attachment: KAFKA-2293.patch
IllegalFormatConversionException in Partition.scala
[
https://issues.apache.org/jira/browse/KAFKA-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-2290.
Resolution: Fixed
Fix Version/s: 0.8.3
Thanks for the patch. +1 and committed to trunk.
[
https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596624#comment-14596624
]
Geoffrey Anderson commented on KAFKA-2276:
--
Pull request is here:
Hi,
I'm pinging the dev list regarding KAFKA-2276 (KIP-25 initial patch) again
since it sounds like at least one person I spoke with did not see the
initial pull request.
Pull request: https://github.com/apache/kafka/pull/70/
JIRA: https://issues.apache.org/jira/browse/KAFKA-2276
Thanks!
Geoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35655/#review88877
---
Ship it!
LGTM. There were 9 question marks when 10 characters were
I'll respond to specific comments, but at the bottom of this email I've
included some comparisons with other connector frameworks and Kafka
import/export tools. This definitely isn't an exhaustive list, but
hopefully will clarify how I'm thinking about Copycat should live wrt these
other systems.
Hey Gwen,
That makes a lot of sense. Here was the thinking on our side.
I guess there are two questions, where does Copycat go and where do the
connectors go?
I'm in favor of Copycat being in Kafka and the connectors being federated.
Arguments for federating connectors:
- There will be like
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596965#comment-14596965
]
Aditya Auradkar commented on KAFKA-2205:
[~junrao] - Can you review this patch?
Hey Roshan,
That is definitely the key question in this space--what can we do that
other systems don't?
It's true that there are a number of systems that copy data between things.
At a high enough level of abstraction I suppose they are somewhat the same.
But I think this area is the source of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34789/
---
(Updated June 22, 2015, 11:35 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596850#comment-14596850
]
Jason Gustafson commented on KAFKA-2168:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-2168:
---
Attachment: KAFKA-2168_2015-06-22_16:34:37.patch
New consumer poll() can block other calls
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35734/#review88866
---
Ship it!
Minor comment: would use `%s` with `TopicAndPartition`
On June 21, 2015, 5:49 a.m., Guozhang Wang wrote:
I think the main reason is that util.Random.nextString() may include other
non-ascii chars and hence its toString may not be well-defined:
http://alvinalexander.com/scala/creating-random-strings-in-scala
So I think bottom-line is
On June 22, 2015, 11:43 p.m., Ewen Cheslack-Postava wrote:
LGTM. There were 9 question marks when 10 characters were requested, so the
problem was probably just that a whitespace character at the start or end
would get trimmed during AbstractConfig's parsing.
That's what I thought as
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595450#comment-14595450
]
Honghai Chen commented on KAFKA-1646:
-
See the commit
[
https://issues.apache.org/jira/browse/KAFKA-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Simoneko updated KAFKA-2235:
-
Attachment: KAFKA-2235_v2.patch
LogCleaner offset map overflow
--
Very useful KIP.
I have no clear opinion over where to put the framework will be better yet.
I agree with Gwen on the benefits we can get from have a separate project
for Copycat. But still have a few questions:
1. As far as code is concerned, Copycat would be some datasource adapters
+ Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595798#comment-14595798
]
Ivan Simoneko commented on KAFKA-2235:
--
[~junrao] thank you for review. Please check
[
https://issues.apache.org/jira/browse/KAFKA-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Black reassigned KAFKA-2290:
--
Assignee: Chris Black
OffsetIndex should open RandomAccessFile consistently
[
https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595510#comment-14595510
]
Gianmarco De Francisci Morales commented on KAFKA-2092:
---
Any more
[
https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589634#comment-14589634
]
Gianmarco De Francisci Morales edited comment on KAFKA-2092 at 6/22/15 8:42 AM:
[
https://issues.apache.org/jira/browse/KAFKA-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Black updated KAFKA-2290:
---
Attachment: KAFKA-2290.patch
OffsetIndex should open RandomAccessFile consistently
[
https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596624#comment-14596624
]
Geoffrey Anderson edited comment on KAFKA-2276 at 6/22/15 9:00 PM:
Jeremy Fields created KAFKA-2294:
Summary: javadoc compile error due to illegal p/ , build failing
(jdk 8)
Key: KAFKA-2294
URL: https://issues.apache.org/jira/browse/KAFKA-2294
Project: Kafka
Thanks Jay and Ewen for the response.
@Jay
3. This has a built in notion of parallelism throughout.
It was not obvious how it will look like or differ from existing systemsŠ
since all of existing ones do parallelize data movement.
@Ewen,
Import: Flume is just one of many similar systems
On June 22, 2015, 11:43 p.m., Ewen Cheslack-Postava wrote:
LGTM. There were 9 question marks when 10 characters were requested, so the
problem was probably just that a whitespace character at the start or end
would get trimmed during AbstractConfig's parsing.
Jason Gustafson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34789/#review88914
---
Ship it!
Thanks for the latest patch. Looks good overall. To avoid
Thanks, I indeed missed the original :)
Is the plan to squash the commits and merge a pull request with single
commit that matches the JIRA #?
This will be more in line with how commits were organized until now
and will make life much easier when cherry-picking.
Gwen
On Mon, Jun 22, 2015 at
35 matches
Mail list logo
