[
https://issues.apache.org/jira/browse/KAFKA-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Tian resolved KAFKA-2326.
---
Resolution: Invalid
KafkaProducer - invoke Thread.start() during construction
Ismael Juma created KAFKA-2328:
--
Summary: merge-kafka-pr.py script should restore previous branch
after merge is cancelled
Key: KAFKA-2328
URL: https://issues.apache.org/jira/browse/KAFKA-2328
Project:
[
https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622029#comment-14622029
]
Ismael Juma commented on KAFKA-2328:
Workaround is to use `git checkout -`.
[
https://issues.apache.org/jira/browse/KAFKA-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Tian updated KAFKA-2326:
--
Priority: Minor (was: Major)
Description: KafkaProducer invokes Thread.start() during
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35867/
---
(Updated July 10, 2015, 11:15 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622151#comment-14622151
]
Manikumar Reddy commented on KAFKA-1901:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1901:
---
Attachment: KAFKA-1901_2015-07-10_16:42:53.patch
Move Kafka version to be generated in code
[
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622154#comment-14622154
]
Manikumar Reddy commented on KAFKA-1901:
[~jjkoshy] pinging for review
Move
[
https://issues.apache.org/jira/browse/KAFKA-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623077#comment-14623077
]
Parth Brahmbhatt commented on KAFKA-2182:
-
[~junrao] I think I took care of this
[
https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623106#comment-14623106
]
Parth Brahmbhatt commented on KAFKA-2145:
-
[~neelesh77] sorry for the delay on
Yeah, I have an actual customer who ran into this. Unfortunately,
inconsistencies in the way things are named are pretty common - just
look at Kafka's many CLI options.
I don't think that supporting both and pointing at the docs with I
told you so when our metrics break is a good solution.
On
I figure you'll probably see complaints no matter what change you make.
Gwen, given that you raised this, another important question might be how
many people you see using *both*. I'm guessing this question came up
because you actually saw a conflict? But I'd imagine (or at least hope)
that most
[
https://issues.apache.org/jira/browse/KAFKA-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt reassigned KAFKA-1695:
---
Assignee: Parth Brahmbhatt (was: Gwen Shapira)
Authenticate connection to
[
https://issues.apache.org/jira/browse/KAFKA-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623072#comment-14623072
]
Gwen Shapira commented on KAFKA-1695:
-
Sure, go ahead.
Authenticate connection to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35454/
---
(Updated July 10, 2015, 3:47 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622399#comment-14622399
]
Manikumar Reddy commented on KAFKA-2213:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622495#comment-14622495
]
Manikumar Reddy commented on KAFKA-2159:
Updated reviewboard
On July 6, 2015, 3:50 p.m., Guozhang Wang wrote:
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java,
line 57
https://reviews.apache.org/r/35880/diff/2/?file=999580#file999580line57
Is this intentional?
yes. Now ClassNotFoundException will be thrown from
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34805/#review91298
---
Joel, need your inputs for proceeding further on this.
- Manikumar
[
https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-2213:
---
Attachment: KAFKA-2213_2015-07-10_20:18:06.patch
Log cleaner should write compacted messages
[
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622332#comment-14622332
]
Joel Koshy commented on KAFKA-1901:
---
Will review today.
Move Kafka version to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34805/
---
(Updated July 10, 2015, 2:50 p.m.)
Review request for kafka.
Bugs:
On July 9, 2015, 7:19 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76
https://reviews.apache.org/r/34965/diff/2/?file=977751#file977751line76
You could get around the above by retaining this call to
simpleConsumer.close (although it
[
https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622637#comment-14622637
]
Manikumar Reddy commented on KAFKA-2198:
[~gwenshap] Thanks for the review.
[
https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-2198:
---
Attachment: KAFKA-2198_2015-07-10_23:11:23.patch
kafka-topics.sh exits with 0 status on
On June 25, 2015, 10:55 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 40
https://reviews.apache.org/r/33378/diff/8/?file=981582#file981582line40
I think we should add throttle time metrics to the old producer and
consumer as well. What
On July 6, 2015, 3:50 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/utils/CoreUtils.scala, line 221
https://reviews.apache.org/r/35880/diff/2/?file=999581#file999581line221
Can we use scala's Utils.createObject here?
Manikumar Reddy O wrote:
Are you sugessting to use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35880/#review91337
---
Ship it!
Ship It!
- Guozhang Wang
On July 6, 2015, 6:05 a.m.,
On July 9, 2015, 1:42 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java,
line 775
https://reviews.apache.org/r/36333/diff/1/?file=1002921#file1002921line775
I think KAFKA-1894 is already fixed in this patch + KAFKA-2168?
[
https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622644#comment-14622644
]
Manikumar Reddy commented on KAFKA-2198:
Updated reviewboard
On July 10, 2015, 4:46 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/admin/TopicCommand.scala, lines 72-73
https://reviews.apache.org/r/34403/diff/4/?file=1008271#file1008271line72
This is a bit unclean. I think its more idiomatic when the catch block
includes the
Hi Kostya,
I actually did not think about this too much when write the code.
My gut feeling is that the benefit of using a thread pool is that you have
jobs come and go and want to safe your own resource management overhead.
In Mirror maker, there are only fixed number of mirror maker thread and
[
https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622722#comment-14622722
]
Guozhang Wang commented on KAFKA-2295:
--
[~tdas] The latest patch from [~omkreddy]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/#review91319
---
LGTM - just a few minor comments.
Hi Kafka Fans,
If you have one topic named kafka_lab_2 and the other named
kafka.lab.2, the topic level metrics will be named kafka_lab_2 for
both, effectively making it impossible to monitor them properly.
The reason this happens is that using . in topic names is pretty
common, especially as a
[
https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622551#comment-14622551
]
Manikumar Reddy commented on KAFKA-2214:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622559#comment-14622559
]
Manikumar Reddy commented on KAFKA-2198:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-2198:
---
Attachment: KAFKA-2198_2015-07-10_22:02:02.patch
kafka-topics.sh exits with 0 status on
On May 26, 2015, 7:08 a.m., Michael Noll wrote:
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 81
https://reviews.apache.org/r/34641/diff/1/?file=971195#file971195line81
Should we also consider reassignments that are in-progress as errors?
The
[
https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622574#comment-14622574
]
Gwen Shapira commented on KAFKA-2198:
-
Hope its ok if I review this, [~omkreddy].
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36345/#review91321
---
Ship it!
LGTM.
- Jiangjie Qin
On July 9, 2015, 9:05 a.m.,
[
https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622553#comment-14622553
]
Manikumar Reddy commented on KAFKA-2214:
[~junrao] pinging for review
[
https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622561#comment-14622561
]
Manikumar Reddy commented on KAFKA-2198:
[~junrao] pinging for review
On May 26, 2015, 7:08 a.m., Michael Noll wrote:
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 81
https://reviews.apache.org/r/34641/diff/1/?file=971195#file971195line81
Should we also consider reassignments that are in-progress as errors?
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36345/#review91324
---
Ship it!
Ship It!
- Mayuresh Gharat
On July 9, 2015, 9:05 a.m.,
[
https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-2214:
---
Attachment: KAFKA-2214_2015-07-10_21:56:04.patch
kafka-reassign-partitions.sh --verify
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34641/
---
(Updated July 10, 2015, 4:28 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34403/
---
(Updated July 10, 2015, 4:34 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34403/#review91310
---
Thanks for the patch!
[
https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2214:
Reviewer: Gwen Shapira (was: Neha Narkhede)
kafka-reassign-partitions.sh --verify should return
On July 9, 2015, 1:42 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java,
line 775
https://reviews.apache.org/r/36333/diff/1/?file=1002921#file1002921line775
I think KAFKA-1894 is already fixed in this patch + KAFKA-2168?
[
https://issues.apache.org/jira/browse/KAFKA-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622767#comment-14622767
]
Jiangjie Qin commented on KAFKA-2303:
-
Would the following help solve the issue?
1.
Hi Ismael,
I have a couple of comments on the wiki pages / merge scripts:
1. In the wiki page it mentions If the change is new, then it usually
needs a new JIRA. However, trivial changes, where what should change is
virtually the same as how it should change do not require a JIRA.
Example: Fix
I had to go look this one up again to make sure -
https://issues.apache.org/jira/browse/KAFKA-495
The only valid character names for topics are alphanumeric, underscore, and
dash. A period is not supposed to be a valid character to use. If you're
seeing them, then one of two things have happened:
On Fri, Jul 10, 2015 at 11:34 AM, Gwen Shapira gshap...@cloudera.com wrote:
Hi Kafka Fans,
If you have one topic named kafka_lab_2 and the other named
kafka.lab.2, the topic level metrics will be named kafka_lab_2 for
both, effectively making it impossible to monitor them properly.
The
kafka.common.Topic shows that currently period is a valid character and I
have verified I can use kafka-topics.sh to create a new topic with a period.
AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK currently uses
Topic.validate before writing to Zookeeper.
Should period character
On July 9, 2015, 1:42 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java,
lines 88-93
https://reviews.apache.org/r/36333/diff/1/?file=1002923#file1002923line88
This is not introduced in the patch, but I am not
This was definitely changed at some point after KAFKA-495. The question is
when and why.
Here's the relevant code from that patch:
===
--- core/src/main/scala/kafka/utils/Topic.scala (revision 1390178)
+++
Thanks, Grant. That seems like a bad solution to the problem that John ran
into in that ticket. It's entirely reasonable to have separate validators
for separate things, but it seems like the choice was made to try and mash
it all into a single validator. And it appears that despite the commentary
Unintentional side effect from allowing IP addresses in consumer client IDs :)
So the question is, what do we do now?
1) disallow .
2) disallow _
3) find a reversible way to encode . and _ that won't break existing metrics
4) all of the above?
btw. it looks like . and .. are currently valid.
I vote for #1 too.
A special reason Kafka may use '.' in the future is for hierarchical or
namespaced topics.
On Fri, Jul 10, 2015 at 3:32 PM, Todd Palino tpal...@gmail.com wrote:
My selfish point of view is that we do #1, as we use _ extensively in
topic names here :) I also happen to think
Hi Guozhang,
Comments inline.
On Fri, Jul 10, 2015 at 8:47 PM, Guozhang Wang wangg...@gmail.com wrote:
I have a couple of comments on the wiki pages / merge scripts:
Thanks, it's important to discuss these things as the current version is
based on what the Spark project does and may not
The problem with '.' seems only to be in case of metrics. Should kafka
replace '.' with some special character, not in [a-zA-Z0-9\\._\\-] or some
reserved seq of characters?
On Fri, Jul 10, 2015 at 2:08 PM, Neha Narkhede n...@confluent.io wrote:
. seems natural for grouping topic names. +1 for
I absolutely disagree with #2, Neha. That will break a lot of
infrastructure within LinkedIn. That said, removing . might break other
people as well, but I think we should have a clearer idea of how much usage
there is on either side.
-Todd
On Fri, Jul 10, 2015 at 2:08 PM, Neha Narkhede
Found it was added here: https://issues.apache.org/jira/browse/KAFKA-697
On Fri, Jul 10, 2015 at 3:18 PM, Todd Palino tpal...@gmail.com wrote:
This was definitely changed at some point after KAFKA-495. The question is
when and why.
Here's the relevant code from that patch:
My selfish point of view is that we do #1, as we use _ extensively in
topic names here :) I also happen to think it's the right choice,
specifically because . has more special meanings, as you noted.
-Todd
On Fri, Jul 10, 2015 at 1:30 PM, Gwen Shapira gshap...@cloudera.com wrote:
Unfortunately '.' is pretty common too. I agree that it is perverse, but
people seem to do it. Breaking all the topics with '.' in the name seems
like it could be worse than combining metrics for people who have a
'foo_bar' AND 'foo.bar' (and after all, having both is DEEPLY perverse,
no?).
Where
Yes, agree here. While it can be a little confusing, I think it's better to
just disallow the character for all creation steps so you can't create more
bad topic names, but not try and enforce it for topics that already
exist. Anyone who is in that situation is already there with regards to
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622967#comment-14622967
]
Ashish K Singh commented on KAFKA-972:
--
[~junrao] could you take a look, thanks.
Commends inlined.
On Fri, Jul 10, 2015 at 2:10 PM, Ismael Juma ism...@juma.me.uk wrote:
Hi Guozhang,
Comments inline.
On Fri, Jul 10, 2015 at 8:47 PM, Guozhang Wang wangg...@gmail.com wrote:
I have a couple of comments on the wiki pages / merge scripts:
Thanks, it's important to
I find dots more common in my customer base, so I will definitely feel
the pain of removing them.
However, . are already used in metrics, file names, directories, etc
- so if we keep the dots, we need to keep code that translates them
and document the translation. Just banning . seems more
[
https://issues.apache.org/jira/browse/KAFKA-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623024#comment-14623024
]
Parth Brahmbhatt commented on KAFKA-2032:
-
Pinging for review from committers.
[
https://issues.apache.org/jira/browse/KAFKA-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623031#comment-14623031
]
Parth Brahmbhatt commented on KAFKA-2162:
-
There are a few options here, we could
[
https://issues.apache.org/jira/browse/KAFKA-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623053#comment-14623053
]
Parth Brahmbhatt commented on KAFKA-1695:
-
[~gwenshap] I have upgraded zkClient to
74 matches
Mail list logo
