Re: Review Request 33620: Patch for KAFKA-1690

On June 30, 2015, 5:27 p.m., Michael Herstine wrote: clients/src/main/java/org/apache/kafka/common/network/Channel.java, lines 109-114 https://reviews.apache.org/r/33620/diff/10/?file=990775#file990775line109 So you want class `Channel` to have at most one send pending at any

[jira] [Commented] (KAFKA-2162) Kafka Auditing functionality

[ https://issues.apache.org/jira/browse/KAFKA-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624158#comment-14624158 ] Gwen Shapira commented on KAFKA-2162: - I like starting with requirements. So I asked

[jira] [Commented] (KAFKA-2275) Add a ListTopic() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624057#comment-14624057 ] Stevo Slavic commented on KAFKA-2275: - Isn't this covered by [public ListPartitionInfo

Re: [Discussion] Limitations on topic names

First, a couple of clarifications on this. 1. Currently, we allow Kafka topic to have dots, except that we disallow topic names that are exactly . or .. (which can cause weird problems when mapping to file directories and ZK paths as Gwen pointed out). 2. When creating the Coda Hale metrics,

Re: Review Request 34403: Patch for KAFKA-2198

On July 10, 2015, 4:46 p.m., Gwen Shapira wrote: core/src/main/scala/kafka/admin/TopicCommand.scala, lines 72-73 https://reviews.apache.org/r/34403/diff/4/?file=1008271#file1008271line72 This is a bit unclean. I think its more idiomatic when the catch block includes the

[jira] [Commented] (KAFKA-2162) Kafka Auditing functionality

[ https://issues.apache.org/jira/browse/KAFKA-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624188#comment-14624188 ] Sriharsha Chintalapani commented on KAFKA-2162: --- [~gwenshap] I think

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624238#comment-14624238 ] Jiangjie Qin commented on KAFKA-1835: - Maybe we can enforce a metadata refresh upon

[jira] [Comment Edited] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623837#comment-14623837 ] Stefan Miklosovic edited comment on KAFKA-1835 at 7/12/15 2:46 PM:

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623837#comment-14623837 ] Stefan Miklosovic commented on KAFKA-1835: -- I am still hitting this issue, I need

Re: [Discussion] Limitations on topic names

Can we provide a tool so folks can sync back old topic names to new so their clusters aren't format lopsided. ~ Joestein On Jul 11, 2015 1:33 PM, Todd Palino tpal...@gmail.com wrote: I tend to agree with this as a compromise at this point. The reality is that this is technical debt that has

Re: [Discussion] Limitations on topic names

I like the lets warn people of conflicts when creating the topic suggestion. IMO, automatic topic creation as currently done is buggy either way (Send data and hope the topic is ready before retries run out, potentially failing with the super helpful NO_LEADER error), so I don't mind leaving it

[jira] [Comment Edited] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623837#comment-14623837 ] Stefan Miklosovic edited comment on KAFKA-1835 at 7/12/15 2:51 PM: