[DISCUSS] JIRA issue required even for minor/hotfix pull requests?

2015-07-13 Thread Ismael Juma
Hi all, Guozhang raised this topic in the [DISCUSS] Using GitHub Pull Requests for contributions and code review thread and suggested starting a new thread for it. In the Spark project, they say: If the change is new, then it usually needs a new JIRA. However, trivial changes, where what should

Re: Question about sub-projects and project merging

2015-07-13 Thread Greg Stein
Hi Jay, Looking at your question, I see the Apache Samza and Apache Kafka *communities* have little overlap(*). The Board looks at communities, and their overlap or lack thereof. Smushing two communities under one TLP is what we have historically called an umbrella TLP, and discourage.

Re: [DISCUSS] JIRA issue required even for minor/hotfix pull requests?

2015-07-13 Thread Joe Stein
Ismael, If you create a pull request on github today then a JIRA is created so folks can see and respond and such. The JIRA hooks also provide in comment updates too. What issue are you having or looking to-do? ~ Joe Stein On Mon, Jul 13, 2015 at 6:52 AM, Ismael Juma ism...@juma.me.uk wrote:

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624382#comment-14624382 ] Stefan Miklosovic commented on KAFKA-1835: -- [~becket_qin] Anything which would

[jira] [Comment Edited] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624382#comment-14624382 ] Stefan Miklosovic edited comment on KAFKA-1835 at 7/13/15 8:52 AM:

Re: [DISCUSS] JIRA issue required even for minor/hotfix pull requests?

2015-07-13 Thread Joe Stein
Sorry, meant to say 'an email to dev list' instead of 'a JIRA' below. The hooks in JIRA comments I have seen working recently. ~ Joe Stein On Mon, Jul 13, 2015 at 8:42 AM, Joe Stein joe.st...@stealth.ly wrote: Ismael, If you create a pull request on github today then a JIRA is created so

[jira] [Commented] (KAFKA-2275) Add a ListTopic() API to the new consumer

2015-07-13 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624399#comment-14624399 ] Stevo Slavic commented on KAFKA-2275: - [~guozhang] so it's {{listTopics()}} not

[jira] [Created] (KAFKA-2331) Kafka does not spread partitions in a topic among all consumers evenly

2015-07-13 Thread Stefan Miklosovic (JIRA)
Stefan Miklosovic created KAFKA-2331: Summary: Kafka does not spread partitions in a topic among all consumers evenly Key: KAFKA-2331 URL: https://issues.apache.org/jira/browse/KAFKA-2331

[jira] [Commented] (KAFKA-2145) An option to add topic owners.

2015-07-13 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624578#comment-14624578 ] Neelesh Srinivas Salian commented on KAFKA-2145: I don't think I can get

Re: Review Request 35615: Patch for KAFKA-1782

2015-07-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/#review91575 --- Some general comments: 1. Regarding the @Before and @After

[jira] [Commented] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-13 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625827#comment-14625827 ] Gwen Shapira commented on KAFKA-2198: - Thanks for the patch! pushed to trunk.

Build failed in Jenkins: kafka-trunk-git-pr #2

2015-07-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/kafka-trunk-git-pr/2/changes Changes: [cshapi] KAFKA-2198: kafka-topics.sh exits with 0 status on failures; patched by Manikumar Reddy reviewed by Gwen Shapira -- [...truncated 1442 lines...] kafka.api.ProducerBounceTest

Build failed in Jenkins: KafkaPreCommit #147

2015-07-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/147/changes Changes: [cshapi] KAFKA-2198: kafka-topics.sh exits with 0 status on failures; patched by Manikumar Reddy reviewed by Gwen Shapira -- [...truncated 3035 lines...] kafka.consumer.MetricsTest

[jira] [Updated] (KAFKA-1782) Junit3 Misusage

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1782: - Status: In Progress (was: Patch Available) Junit3 Misusage ---

Inquiry regarding unreviewed patch (KAFKA-1614)

2015-07-13 Thread Jisoo Kim
To whom may it concern, My coworker submitted a patch https://issues.apache.org/jira/browse/KAFKA-1614 about a year ago, which enables JMX to report segment information, so the amount of data each broker has can be calculated through JMX polling. May I ask the progress on reviewing the patch?

Re: Inquiry regarding unreviewed patch (KAFKA-1614)

2015-07-13 Thread Jisoo Kim
Also, please let me know if there's a way for another program to know the amount of data each broker currently holds. Thanks, Jisoo On Mon, Jul 13, 2015 at 4:59 PM, Jisoo Kim jisoo@metamarkets.com wrote: To whom may it concern, My coworker submitted a patch

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-13 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625844#comment-14625844 ] Gwen Shapira commented on KAFKA-2214: - Thank you! Can you also address [~miguno]

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625781#comment-14625781 ] Jiangjie Qin commented on KAFKA-1835: - [~ewencp] I agree that handling exception is

[jira] [Comment Edited] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625781#comment-14625781 ] Jiangjie Qin edited comment on KAFKA-1835 at 7/14/15 4:06 AM: --

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625763#comment-14625763 ] Steven Zhen Wu commented on KAFKA-1835: --- [~ewencp] As a user, I don't mind handling

[jira] [Commented] (KAFKA-242) Subsequent calls of ConsumerConnector.createMessageStreams cause Consumer offset to be incorrect

2015-07-13 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624630#comment-14624630 ] Stefan Miklosovic commented on KAFKA-242: - [~jkreps] I am hitting the same issues

Re: [DISCUSS] JIRA issue required even for minor/hotfix pull requests?

2015-07-13 Thread Ismael Juma
Hi Joe, Yes, I am aware of the emails and automatic JIRA updates. The question is whether a contributor who wants to make a simple change (eg fix a typo, improve a scaladoc, make a small code improvement) should have to create a JIRA for it and then submit the PR or if they can just skip the

Re: [DISCUSS] JIRA issue required even for minor/hotfix pull requests?

2015-07-13 Thread Joe Stein
Ismael, If the patch lives on a pull request and is a simple hotfix a committer could +1 and commit it. I don't see anything in the https://cwiki.apache.org/confluence/display/KAFKA/Bylaws preventing this already now. I guess I am still struggling between what is not setup that you think we need

[jira] [Commented] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624674#comment-14624674 ] Manikumar Reddy commented on KAFKA-2198: Updated reviewboard

[jira] [Updated] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2198: --- Attachment: KAFKA-2198_2015-07-13_19:24:46.patch kafka-topics.sh exits with 0 status on

Re: [DISCUSS] JIRA issue required even for minor/hotfix pull requests?

2015-07-13 Thread Ismael Juma
On Mon, Jul 13, 2015 at 2:41 PM, Joe Stein joe.st...@stealth.ly wrote: If the patch lives on a pull request and is a simple hotfix a committer could +1 and commit it. I don't see anything in the https://cwiki.apache.org/confluence/display/KAFKA/Bylaws preventing this already now. Good. I

Re: [Discussion] Limitations on topic names

2015-07-13 Thread Jun Rao
Magnus, Converting dot to _ essentially is our way of escaping in the scope part of the metric name. The issue is that your options of escaping is limited due to the constraints in the reporters. For example, the Ganglia reporter replaces anything other than alpha-numeric, -, _ and dot to _ in

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625837#comment-14625837 ] Ewen Cheslack-Postava commented on KAFKA-1835: -- [~becket_qin] Agreed that

Re: Review Request 35867: Patch for KAFKA-1901

2015-07-13 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review91574 ---

Re: Review Request 35867: Patch for KAFKA-1901

2015-07-13 Thread Joel Koshy
On June 25, 2015, 7:01 p.m., Joel Koshy wrote: build.gradle, line 386 https://reviews.apache.org/r/35867/diff/1/?file=991942#file991942line386 I was originally interested in this because it would be a quick way to determine what version someone is running/testing with. However,

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-13 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34403/#review91579 --- Ship it! Ship It! - Gwen Shapira On July 13, 2015, 1:57 p.m.,

[jira] [Updated] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-13 Thread Ben Kirwin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Kirwin updated KAFKA-2260: -- Status: Patch Available (was: Open) Worked up a draft of this over the weekend, implementing the

[jira] [Updated] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-13 Thread Ben Kirwin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Kirwin updated KAFKA-2260: -- Attachment: expected-offsets.patch Allow specifying expected offset on produce

Re: Review Request 36244: Patch for KAFKA-2312

2015-07-13 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review91488 --- Ship it! LGTM - Jason Gustafson On July 7, 2015, 5 a.m., Tim

[jira] [Updated] (KAFKA-2275) Add a ListTopics() API to the new consumer

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2275: - Description: With regex subscription like {code} consumer.subscribe(topic*) {code} The

Re: [Discussion] Limitations on topic names

2015-07-13 Thread Joel Koshy
One way to get around this conflict could be to replace . with _ and _ with __ On Sat, Jul 11, 2015 at 10:33 AM, Todd Palino tpal...@gmail.com wrote: I tend to agree with this as a compromise at this point. The reality is that this is technical debt that has built up in the project, and it

[jira] [Commented] (KAFKA-2162) Kafka Auditing functionality

2015-07-13 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625176#comment-14625176 ] Parth Brahmbhatt commented on KAFKA-2162: - [~gwenshap] [~harsha_ch] I don't

Re: [Discussion] Limitations on topic names

2015-07-13 Thread Joel Koshy
This did come up in the discussion in KAFKA-1902. It is somewhat concerning that something very specific - in this case (what I think is a limitation [1]) in certain metric reporters should drive the decision on what constitutes a legal topic name in Kafka - especially when all the characters in

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

2015-07-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625095#comment-14625095 ] Joel Koshy commented on KAFKA-2275: --- [~onurkaraman] has also been doing some thinking on

[jira] [Commented] (KAFKA-2275) Add a ListTopic() API to the new consumer

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624955#comment-14624955 ] Guozhang Wang commented on KAFKA-2275: -- [~sslavic] Yes you are right, changed the

[jira] [Commented] (KAFKA-2145) An option to add topic owners.

2015-07-13 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624975#comment-14624975 ] Parth Brahmbhatt commented on KAFKA-2145: - @singhashish Given I am the original

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

2015-07-13 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624873#comment-14624873 ] Parth Brahmbhatt commented on KAFKA-1788: - [~becket_qin] So is this jira

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

2015-07-13 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624933#comment-14624933 ] Mayuresh Gharat commented on KAFKA-1788: Hi [~parth.brahmbhatt], this is been

[jira] [Comment Edited] (KAFKA-2145) An option to add topic owners.

2015-07-13 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624975#comment-14624975 ] Parth Brahmbhatt edited comment on KAFKA-2145 at 7/13/15 5:18 PM:

Re: [DISCUSS] JIRA issue required even for minor/hotfix pull requests?

2015-07-13 Thread Guozhang Wang
Joe, I think the issue that Ismael want to raise discussion for is that today, we are unofficially sticking with JIRA tickets for all of our commits (i.e. it is not enforced in bylaws but we are doing it anyways), for example, following today's RB-based review process people are creating JIRAs

[jira] [Updated] (KAFKA-2275) Add a ListTopics() API to the new consumer

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2275: - Summary: Add a ListTopics() API to the new consumer (was: Add a ListTopic() API to the new

[jira] [Commented] (KAFKA-2275) Add a ListTopic() API to the new consumer

2015-07-13 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624793#comment-14624793 ] Ashish K Singh commented on KAFKA-2275: --- If no one is already working on this, I can

[jira] [Assigned] (KAFKA-2275) Add a ListTopic() API to the new consumer

2015-07-13 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh reassigned KAFKA-2275: - Assignee: Ashish K Singh Add a ListTopic() API to the new consumer

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624826#comment-14624826 ] Manikumar Reddy commented on KAFKA-2214: Sample output: {code} sh

[jira] [Assigned] (KAFKA-2145) An option to add topic owners.

2015-07-13 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh reassigned KAFKA-2145: - Assignee: Ashish K Singh (was: Neelesh Srinivas Salian) An option to add topic owners.

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-13 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated July 13, 2015, 3:43 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2214: --- Attachment: KAFKA-2214_2015-07-13_21:10:58.patch kafka-reassign-partitions.sh --verify

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-13 Thread Manikumar Reddy O
On July 10, 2015, 4:46 p.m., Gwen Shapira wrote: core/src/main/scala/kafka/admin/TopicCommand.scala, lines 72-73 https://reviews.apache.org/r/34403/diff/4/?file=1008271#file1008271line72 This is a bit unclean. I think its more idiomatic when the catch block includes the

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624819#comment-14624819 ] Manikumar Reddy commented on KAFKA-2214: Updated reviewboard

[jira] [Commented] (KAFKA-2077) Add ability to specify a TopicPicker class for KafkaLog4jApender

2015-07-13 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624895#comment-14624895 ] Jason Gustafson commented on KAFKA-2077: [~benoyantony], I think

[jira] [Commented] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625257#comment-14625257 ] Guozhang Wang commented on KAFKA-2312: -- Thanks for the patch, committed to trunk.

[jira] [Updated] (KAFKA-2312) Use AtomicLong opposed to AtomicReference to store currentThread in consumer

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2312: - Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available)

Re: Review Request 33378: Patch for KAFKA-2136

2015-07-13 Thread Aditya Auradkar
On July 10, 2015, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/DelayedFetch.scala, line 135 https://reviews.apache.org/r/33378/diff/9/?file=996359#file996359line135 For these, I'm wondering if we should put in the actual delay and in KAFKA-2136 just add a config

Re: Review Request 34965: Patch for KAFKA-2241

2015-07-13 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/ --- (Updated July 13, 2015, 8:30 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625284#comment-14625284 ] Dong Lin commented on KAFKA-2241: - Updated reviewboard

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

2015-07-13 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625288#comment-14625288 ] Aditya A Auradkar commented on KAFKA-2136: -- Updated reviewboard

Re: Review Request 33378: Patch for KAFKA-2136

2015-07-13 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated July 13, 2015, 8:34 p.m.) Review request for kafka, Joel Koshy and

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

2015-07-13 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2136: - Attachment: KAFKA-2136_2015-07-13_13:34:03.patch Client side protocol changes to return

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2015-07-13 Thread Alexander Pakulov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625341#comment-14625341 ] Alexander Pakulov commented on KAFKA-1782: -- [~guozhang] [~junrao] is this ticket

Re: Review Request 36244: Patch for KAFKA-2312

2015-07-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review91519 --- Ship it! Ship It! - Guozhang Wang On July 7, 2015, 5 a.m., Tim

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625234#comment-14625234 ] Jiangjie Qin commented on KAFKA-1835: - [~guozhang][~jkreps] What do you think on this?

Re: Review Request 36244: Patch for KAFKA-2312

2015-07-13 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36244/#review91514 --- Ship it! Ship It! - Ismael Juma On July 7, 2015, 5 a.m., Tim

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2241: Attachment: KAFKA-2241_2015-07-13_13:30:07.patch AbstractFetcherThread.shutdown() should not block on

Re: Review Request 33378: Patch for KAFKA-2136

2015-07-13 Thread Aditya Auradkar
On June 25, 2015, 10:55 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 40 https://reviews.apache.org/r/33378/diff/8/?file=981582#file981582line40 I think we should add throttle time metrics to the old producer and consumer as well. What

[jira] [Created] (KAFKA-2332) Add quota metrics to old producer and consumer

2015-07-13 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2332: -- Summary: Add quota metrics to old producer and consumer Key: KAFKA-2332 URL: https://issues.apache.org/jira/browse/KAFKA-2332 Project: Kafka Issue Type:

Re: Review Request 33378: Patch for KAFKA-2136

2015-07-13 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated July 13, 2015, 8:36 p.m.) Review request for kafka, Joel Koshy and

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-07-13 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625346#comment-14625346 ] Ismael Juma commented on KAFKA-1595: [~gwenshap], I started a thread in the mailing

[jira] [Created] (KAFKA-2333) Add rename topic support

2015-07-13 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-2333: -- Summary: Add rename topic support Key: KAFKA-2333 URL: https://issues.apache.org/jira/browse/KAFKA-2333 Project: Kafka Issue Type: New Feature

[jira] [Assigned] (KAFKA-1893) Allow regex subscriptions in the new consumer

2015-07-13 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-1893: -- Assignee: Jason Gustafson Allow regex subscriptions in the new consumer

[jira] [Updated] (KAFKA-2332) Add quota metrics to old producer and consumer

2015-07-13 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2332: --- Issue Type: Sub-task (was: Improvement) Parent: KAFKA-2083 Add quota metrics to old

[DISCUSS] Json libraries for Kafka

2015-07-13 Thread Ismael Juma
Hi all, Kafka currently use scala.util.parsing.json.JSON as its json parser and it has a number of issues: * It encourages unsafe casts (returns `Option[Any]`) * It's slow (it relies on parser combinators under the hood) * It's not thread-safe (so external locks are needed to use it in a

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625550#comment-14625550 ] Jun Rao commented on KAFKA-2205: Reviewed and just have a couple of more minor comments.

[jira] [Resolved] (KAFKA-2182) zkClient dies if there is any exception while reconnecting

2015-07-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-2182. Resolution: Implemented Fix Version/s: 0.8.3 As [~parth.brahmbhatt] pointed out, this is already

Re: Review Request 36341: Patch for KAFKA-2311

2015-07-13 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36341/#review91556 --- Ship it! Ship It! - Jason Gustafson On July 9, 2015, 1:04 a.m.,

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625568#comment-14625568 ] Guozhang Wang commented on KAFKA-1835: -- [~smiklosovic] You will only be blocked for

Build failed in Jenkins: Kafka-trunk #539

2015-07-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/539/changes Changes: [wangguoz] KAFKA-2312: use atomic long for thread id reference; reviewed by Ewen Cheslack-Postava, Jason Gustafson, Ismael Juma and Guozhang Wang -- [...truncated 1435 lines...]

[jira] [Assigned] (KAFKA-2145) An option to add topic owners.

2015-07-13 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt reassigned KAFKA-2145: --- Assignee: Parth Brahmbhatt An option to add topic owners.

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2241: Attachment: KAFKA-2241_2015-07-13_14:51:42.patch AbstractFetcherThread.shutdown() should not block on

[jira] [Commented] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

2015-07-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625428#comment-14625428 ] Dong Lin commented on KAFKA-2241: - Updated reviewboard

[jira] [Commented] (KAFKA-2145) An option to add topic owners.

2015-07-13 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625380#comment-14625380 ] Ashish K Singh commented on KAFKA-2145: --- [~parth.brahmbhatt] sure, go ahead. An

[jira] [Updated] (KAFKA-2145) An option to add topic owners.

2015-07-13 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2145: -- Assignee: (was: Ashish K Singh) An option to add topic owners.

Re: Review Request 34965: Patch for KAFKA-2241

2015-07-13 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34965/ --- (Updated July 13, 2015, 9:52 p.m.) Review request for kafka. Bugs:

Re: Review Request 33378: Patch for KAFKA-2136

2015-07-13 Thread Aditya Auradkar
On July 10, 2015, 5:49 p.m., Joel Koshy wrote: LGTM - just a few minor comments. Also, I filed this ticket to add metrics to the old producer and consumers: https://issues.apache.org/jira/browse/KAFKA-2332 - Aditya --- This is an

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

2015-07-13 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625460#comment-14625460 ] Jason Gustafson commented on KAFKA-2275: [~singhashish], [~onurkaraman], one of

[jira] [Updated] (KAFKA-1782) Junit3 Misusage

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1782: - Reviewer: Guozhang Wang Junit3 Misusage --- Key: KAFKA-1782

Re: Review Request 36333: Patch for KAFKA-2123

2015-07-13 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/#review91564 ---

Re: Review Request 36333: Patch for KAFKA-2123

2015-07-13 Thread Jason Gustafson
On July 14, 2015, 12:04 a.m., Guozhang Wang wrote: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java, lines 117-131 https://reviews.apache.org/r/36333/diff/1-2/?file=1002924#file1002924line117 With this change, we are now always sending an

Re: Review Request 36333: Patch for KAFKA-2123

2015-07-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/#review91565 ---

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-972: -- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for the

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625634#comment-14625634 ] Jiangjie Qin commented on KAFKA-1835: - Hey [~guozhang], I am worrying about the case

Jenkins build is back to normal : Kafka-trunk #540

2015-07-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/540/changes

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625674#comment-14625674 ] Ewen Cheslack-Postava commented on KAFKA-1835: -- [~becket_qin] I agree that

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-07-13 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625677#comment-14625677 ] Jason Gustafson commented on KAFKA-2123: Updated reviewboard

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

2015-07-13 Thread Jun Rao
Ismael, I followed the instructions in KAFKA-2320 and created a new Jenkins job ( https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it works? As for wiki, I have a couple of minor comments. a. Could we add the following to the wiki? To avoid conflicts, assign a jira to

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2015-07-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625654#comment-14625654 ] Guozhang Wang commented on KAFKA-1782: -- [~apakulov] Yes this is still relevant, sorry

  1   2   >