---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92349
---
core/src/main/scala/kafka/security/auth/Acl.scala (line 136)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92350
---
core/src/main/scala/kafka/server/KafkaApis.scala (line 620)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92352
---
core/src/main/scala/kafka/security/auth/KafkaPrincipal.scala (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92354
---
core/src/main/scala/kafka/security/auth/Operation.scala (line 43)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92355
---
core/src/main/scala/kafka/server/KafkaApis.scala (line 148)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92356
---
core/src/main/scala/kafka/server/KafkaApis.scala (line 536)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92357
---
core/src/main/scala/kafka/server/KafkaApis.scala (line 136)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92358
---
core/src/main/scala/kafka/server/KafkaApis.scala (line 163)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92359
---
core/src/main/scala/kafka/security/auth/PermissionType.scala (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92361
---
core/src/main/scala/kafka/security/auth/PermissionType.scala (line
On June 30, 2015, 3:03 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
line 67
https://reviews.apache.org/r/33620/diff/10/?file=990783#file990783line67
Shouldn't we only start the ssl handshake after the raw socket
connection
On June 30, 2015, 3:03 p.m., Jun Rao wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 393
https://reviews.apache.org/r/33620/diff/10/?file=990801#file990801line393
This parameter doesn't seem to be used. We can remove it.
I am using for metrics
On June 30, 2015,
On June 30, 2015, 5:20 p.m., Joel Koshy wrote:
clients/src/main/java/org/apache/kafka/common/network/Channel.java, lines
148-150
https://reviews.apache.org/r/33620/diff/10/?file=990775#file990775line148
This should be caught by checkstyle - can you double-check? If we want
On June 24, 2015, 4:39 p.m., Jiangjie Qin wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
lines 75-78
https://reviews.apache.org/r/33620/diff/10/?file=990783#file990783line75
Can they be replaced by clear() method?
These are set only once I
On May 22, 2015, 12:33 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
line 294
https://reviews.apache.org/r/33620/diff/8/?file=966806#file966806line294
Not sure why we are looping back here. If the HandshakeStatus is
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634169#comment-14634169
]
Jason Gustafson commented on KAFKA-2350:
There will probably be a large number of
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634229#comment-14634229
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
Can we have TopicPartition rather than
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634274#comment-14634274
]
Jason Gustafson commented on KAFKA-2342:
[~junrao], I found a case where a
See https://builds.apache.org/job/KafkaPreCommit/158/changes
Changes:
[cshapi] KAFKA-2337; Verify that metric names will not collide when creating
new topics; patched by Grant Henke; reviewed by Edward Ribeiro, Ashish Singh
and Gwen Shapira
--
See https://builds.apache.org/job/KafkaPreCommit/159/changes
Changes:
[cshapi] KAFKA-2328; merge-kafka-pr.py script should not leave user in a
detached branch
--
[...truncated 803 lines...]
kafka.log.OffsetMapTest testClear PASSED
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92341
---
core/src/main/scala/kafka/security/auth/Acl.scala (line 86)
Yes, sorry, I think this is right -- it's pretty application-specific.
One thing to note: in a large subset of cases (ie. bulk load,
copycat-type, mirrormaker) the correct response is not to resend the
message at all; if there's already a message at that offset, it's
because another instance of
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634247#comment-14634247
]
Gwen Shapira commented on KAFKA-2337:
-
Pushed to trunk.
Thanks for the patch
[
https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2328:
Resolution: Fixed
Reviewer: Gwen Shapira
Fix Version/s: 0.8.3
Status:
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634294#comment-14634294
]
Jason Gustafson edited comment on KAFKA-2350 at 7/20/15 11:49 PM:
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634296#comment-14634296
]
Edward Ribeiro commented on KAFKA-2350:
---
Nit: wouldn't the inverse of ``pause`` to
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634294#comment-14634294
]
Jason Gustafson commented on KAFKA-2350:
I don't see why not. In that case, I
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634322#comment-14634322
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
To me the state preservation is not a
[
https://issues.apache.org/jira/browse/KAFKA-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634222#comment-14634222
]
Guozhang Wang commented on KAFKA-2329:
--
Thanks for the patch [~zklapow], a couple
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634266#comment-14634266
]
ASF GitHub Bot commented on KAFKA-2342:
---
GitHub user hachikuji opened a pull
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/88
KAFKA-2342; fix transient unit test failure ConsumerBounceTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-2342
GitHub user sslavic opened a pull request:
https://github.com/apache/kafka/pull/89
Fixed javadoc for committed return value
If no offset has been committed, then committed method does not return
(null) value, instead NoOffsetForPartitionException is thrown in that case.
You can
[
https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634279#comment-14634279
]
ASF GitHub Bot commented on KAFKA-2328:
---
Github user asfgit closed the pull request
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/
---
(Updated July 20, 2015, 11:42 p.m.)
Review request for kafka.
Bugs:
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634280#comment-14634280
]
Parth Brahmbhatt commented on KAFKA-2210:
-
Updated reviewboard
On July 16, 2015, 10:32 p.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/security/auth/Operation.scala, lines 43-44
https://reviews.apache.org/r/34492/diff/7/?file=1011774#file1011774line43
+1. As of today, it spills out a Match error that can be confusing to
figure out. An
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt updated KAFKA-2210:
Attachment: KAFKA-2210_2015-07-20_16:42:18.patch
KafkaAuthorizer: Add all public entities,
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt updated KAFKA-2210:
Status: Patch Available (was: In Progress)
KafkaAuthorizer: Add all public entities,
[
https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634327#comment-14634327
]
Parth Brahmbhatt commented on KAFKA-824:
[~junrao] Looked at the fix code and
See https://builds.apache.org/job/Kafka-trunk/550/changes
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634435#comment-14634435
]
Gwen Shapira commented on KAFKA-2100:
-
Go ahead, all yours :)
Client Error doesn't
[
https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2100:
Assignee: David Jacot (was: Gwen Shapira)
Client Error doesn't preserve or display original
[
https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634465#comment-14634465
]
Edward Ribeiro commented on KAFKA-2338:
---
Hi [~gwenshap], whenever you have a free
Mayuresh Gharat created KAFKA-2351:
--
Summary: Brokers are having a problem shutting down correctly
Key: KAFKA-2351
URL: https://issues.apache.org/jira/browse/KAFKA-2351
Project: Kafka
Issue
Github user rekhajoshm closed the pull request at:
https://github.com/apache/kafka/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634555#comment-14634555
]
ASF GitHub Bot commented on KAFKA-1621:
---
Github user rekhajoshm closed the pull
101 - 148 of 148 matches
Mail list logo
