Hey Guozhang,
Thanks for the review:) Yes it is possible to combine them. Both solution
will have the same performance. But I think the current solution will give
us simpler Java class design. Note that we will have to change Java API
(e.g. read() and write()) of OffsetCheckpoint class in order to
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833355#comment-15833355
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833356#comment-15833356
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833429#comment-15833429
]
Bhavesh Shah commented on KAFKA-4676:
-
Hi [~hachikuji]/[~ijuma],
Event after upgradin
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833492#comment-15833492
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833491#comment-15833491
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2000:
---
Reviewer: Jason Gustafson (was: Joel Koshy)
> Delete consumer offsets from kafka once the topic is de
[
https://issues.apache.org/jira/browse/KAFKA-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833429#comment-15833429
]
Bhavesh Shah edited comment on KAFKA-4676 at 1/22/17 3:04 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833131#comment-15833131
]
Jeyhun Karimov edited comment on KAFKA-4144 at 1/22/17 3:05 PM:
[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833131#comment-15833131
]
Jeyhun Karimov edited comment on KAFKA-4144 at 1/22/17 3:06 PM:
GitHub user jeyhunkarimov opened a pull request:
https://github.com/apache/kafka/pull/2420
KAFKA-4613: Treat null-key records the same way for joins and aggreations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeyhunkarimov/ka
[
https://issues.apache.org/jira/browse/KAFKA-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833586#comment-15833586
]
ASF GitHub Bot commented on KAFKA-4613:
---
GitHub user jeyhunkarimov opened a pull req
[
https://issues.apache.org/jira/browse/KAFKA-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeyhun Karimov reassigned KAFKA-4613:
-
Assignee: Jeyhun Karimov
> Treat null-key records the same way for joins and aggreations
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833596#comment-15833596
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833597#comment-15833597
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833607#comment-15833607
]
Jeyhun Karimov commented on KAFKA-4304:
---
[~mjsax] Can we generalize this feature to
I think this is less of an issue: we can use the same patterns as in the
request protocol, i.e.:
write(Map[TP, Long]) // write the checkout point in v0 format
write(Map[TP, Pair[Long, Long]]) // write the checkout point in v1 format
CheckpointedOffsets read() // read the file relying on its versi
Hello Dong,
Thanks for the very well written KIP. I had a general thought on the ZK
path management, wondering if the following alternative would work:
1. Bump up versions in "brokers/topics/[topic]" and
"/brokers/topics/[topic]/partitions/[partitionId]/state"
to 2, in which the replica id is no
I think it also affects KIP-113 design but just leave it as a single
comment here.
On Sun, Jan 22, 2017 at 10:50 AM, Guozhang Wang wrote:
> Hello Dong,
>
> Thanks for the very well written KIP. I had a general thought on the ZK
> path management, wondering if the following alternative would work
[
https://issues.apache.org/jira/browse/KAFKA-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833640#comment-15833640
]
Sushant Sood commented on KAFKA-3628:
-
Hi [~sriharsha] can you please share the update
[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833649#comment-15833649
]
Elias Levy commented on KAFKA-4144:
---
That's fine. I am less concerned about the impleme
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833686#comment-15833686
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833687#comment-15833687
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833708#comment-15833708
]
Jeyhun Karimov commented on KAFKA-4144:
---
[~elevy] I am not sure I got your point. Pl
Yeah, your solution of adding new APIs certainly works and I don't think
that is an issue. On the other hand I don't think it is an issue to add a
new checkpoint file as well since we already have multiple checkpoint
files. The benefit of the new approach you mentioned is probably not an
issue in t
[
https://issues.apache.org/jira/browse/KAFKA-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833747#comment-15833747
]
Jason Gustafson commented on KAFKA-4676:
Can you provide full consumer logs please
Sounds good, thanks!
On Thu, Jan 19, 2017 at 9:21 PM, Dongjin Lee wrote:
> 1. Then, I will submit the KIP as soon as KAFKA-2898 is completed.
> 2. Into following three sub-tasks:
> a. Provide ProducerConfig#builder
> b. Provide ConsumerConfig#builder
> c. Provide StreamsConfig#builde
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/2407
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/KAFKA-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833762#comment-15833762
]
Guozhang Wang commented on KAFKA-4113:
--
Hello [~mitch-seymour], sorry for the late re
To me the distinction between recovery-checkpoint and
replication-checkpoint are different from the distinction between these two
hw checkpoint values: when broker starts up and act as the leader for a
partition, it can live without seeing the recovery checkpoint, but just
cannot rely on the existi
Thanks for the comment Guozhang. Please don't worry about being late. I
would like to update the KIP if there is clear benefit of the new approach.
I am wondering if there is any use-case or operation aspects that would
benefit from the new approach.
I am not saying that these checkpoint files hav
Hey Guozhang,
Thanks for the review! Yes we have considered this approach and briefly
explained why we don't do it in the rejected alternative section. Here is
my concern with this approach in more detail:
- This approach introduces tight coupling between kafka's logical leader
election with brok
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833776#comment-15833776
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833775#comment-15833775
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
Thanks for the KIP Eno, I have a few meta comments and a few detailed
comments:
1. I like the materialize() function in general, but I would like to see
how other KTable functions should be updated accordingly. For example, 1)
KStreamBuilder.table(..) has a state store name parameter, and we will
[
https://issues.apache.org/jira/browse/KAFKA-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833783#comment-15833783
]
Guozhang Wang commented on KAFKA-3124:
--
[~liquanpei] I'm un-assigning you from this t
[
https://issues.apache.org/jira/browse/KAFKA-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1354:
-
Assignee: (was: Jay Kreps)
> Failed to load class "org.slf4j.impl.StaticLoggerBinder"
> --
[
https://issues.apache.org/jira/browse/KAFKA-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-3124:
-
Assignee: (was: Liquan Pei)
> Update protocol wiki page to reflect latest request/response for
[
https://issues.apache.org/jira/browse/KAFKA-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1676:
-
Assignee: (was: Neha Narkhede)
> Ability to cancel replica reassignment in progress
>
[
https://issues.apache.org/jira/browse/KAFKA-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833785#comment-15833785
]
Guozhang Wang commented on KAFKA-2363:
--
I have not seen this failure recently, how ab
[
https://issues.apache.org/jira/browse/KAFKA-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833784#comment-15833784
]
Maniyoor, RakeshAcharya (Rakesh) commented on KAFKA-1354:
-
HI
I a
[
https://issues.apache.org/jira/browse/KAFKA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1850:
-
Assignee: (was: Neha Narkhede)
> Failed reassignment leads to additional replica
> ---
[
https://issues.apache.org/jira/browse/KAFKA-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833786#comment-15833786
]
Guozhang Wang commented on KAFKA-3835:
--
[~ankushpuri] Sorry for the late reply as I w
[
https://issues.apache.org/jira/browse/KAFKA-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-4613:
---
Status: Patch Available (was: Open)
> Treat null-key records the same way for joins and aggre
[
https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-4327:
---
Description:
This is a follow up on https://issues.apache.org/jira/browse/KAFKA-4008
Currentl
[
https://issues.apache.org/jira/browse/KAFKA-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vishal Shukla updated KAFKA-4676:
-
Attachment: stuck-consumer-node-1.log
stuck-consumer-node-2.log
res
[
https://issues.apache.org/jira/browse/KAFKA-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833869#comment-15833869
]
Vishal Shukla commented on KAFKA-4676:
--
Hi Jason,
Thank you very much for immediate
[
https://issues.apache.org/jira/browse/KAFKA-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833891#comment-15833891
]
Matthias J. Sax commented on KAFKA-4113:
[~mitch-seymour] see
http://stackoverflo
[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833899#comment-15833899
]
Matthias J. Sax commented on KAFKA-4144:
Some of my thoughts:
1. I don't think, w
[
https://issues.apache.org/jira/browse/KAFKA-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833900#comment-15833900
]
Matthias J. Sax commented on KAFKA-4304:
[~jeyhunkarimov] I am not sure what you m
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833907#comment-15833907
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833906#comment-15833906
]
postmas...@inn.ru commented on KAFKA-1207:
--
Delivery is delayed to these recipien
[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833913#comment-15833913
]
Elias Levy commented on KAFKA-4144:
---
Jeyhun, sorry if I was not clear. My comment about
Hi,
thanks for the KIP Eno! Here are my 2 cents:
1) I like Guozhang's proposal about removing store name from all KTable
methods and generate internal names (however, I would do this as
overloads). Furthermore, I would not force users to call .materialize()
if they want to query a store, but add
[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833933#comment-15833933
]
Matthias J. Sax commented on KAFKA-4144:
About #2: I guess, the question is what "
55 matches
Mail list logo
