Re: 答复: [VOTE] KIP-177: Consumer perf tool should count rebalance time

[Mickael Maison]

+1

On Sun, Aug 6, 2017 at 4:15 AM, Hu Xi  wrote:
> Hi all, a naive question please. Since this KIP already collects four binding 
> +1 votes, could we mark it as Accepted and move it under 'Adopted KIPs'? 
> Thanks
>
>
>
>
> 
> 发件人: Guozhang Wang 
> 发送时间: 2017年8月5日 2:55
> 收件人: dev@kafka.apache.org
> 主题: Re: [VOTE] KIP-177: Consumer perf tool should count rebalance time
>
> +1
>
> On Fri, Aug 4, 2017 at 11:02 AM, Ismael Juma  wrote:
>
>> Thanks for the KIP, +1 (binding)
>>
>> Ismael
>>
>> On Fri, Aug 4, 2017 at 3:13 AM, Hu Xi  wrote:
>>
>> > Hi all,
>> >
>> >
>> > I'd like to kick off the vote for KIP-177: https://cwiki.apache.org/
>> > confluence/display/ARIES/KIP-177%3A+Consumer+perf+tool+
>> > should+count+rebalance+time.
>> >
>> >
>> > A PR for this KIP can be found at > > kafka/pull/3188> https://github.com/apache/kafka/pull/3188
>> >
>> >
>> >
>>
>
>
>
> --
> -- Guozhang

Re: [VOTE] KIP-163: Lower the Minimum Required ACL Permission of OffsetFetch

[Mickael Maison]

+1
While it's not fixing the Read/Write inconsistency it's a step in the
right direction

On Thu, Aug 3, 2017 at 4:46 PM, Jason Gustafson  wrote:
> +1
>
> On Wed, Aug 2, 2017 at 2:40 PM, Vahid S Hashemian > wrote:
>
>> Hi all,
>>
>> Thanks to everyone who participated in the discussion on KIP-163, and
>> provided feedback.
>> The KIP can be found at
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> 163%3A+Lower+the+Minimum+Required+ACL+Permission+of+OffsetFetch
>> .
>> I believe the concerns have been addressed in the current version of the
>> KIP; so I'd like to start a vote.
>>
>> Thanks.
>> --Vahid
>>
>>
>>

[GitHub] kafka pull request #3632: KAFKA-5707: TopicCommand and ConfigCommand should ...

[huxihx]

GitHub user huxihx opened a pull request:

https://github.com/apache/kafka/pull/3632

KAFKA-5707: TopicCommand and ConfigCommand should remove useless `--force` 
option.

TopicCommand and ConfigCommand should remove useless `--force` option.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/huxihx/kafka KAFKA-5707

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3632


commit d16d9882c1fe0daf2ce2809395020f2289f13f77
Author: huxihx 
Date:   2017-08-07T01:40:36Z

KAFKA-5707: TopicCommand and ConfigCommand should remove useless `--force` 
option.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (KAFKA-5707) Remove useless `--force` option for both TopicCommand and ConfigCommand

[huxihx (JIRA)]

huxihx created KAFKA-5707:
-

 Summary: Remove useless `--force` option for both TopicCommand and 
ConfigCommand
 Key: KAFKA-5707
 URL: https://issues.apache.org/jira/browse/KAFKA-5707
 Project: Kafka
  Issue Type: Bug
  Components: admin
Affects Versions: 0.11.0.0
Reporter: huxihx
Assignee: huxihx
Priority: Minor


`TopicCommand` and `ConfigCommand` do expose an option named `--force` which 
suppresses console prompts, but both classes do not actually use it. Should 
remove it from the usage description.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] kafka pull request #3578: KAFKA-5643: Using _DUCKTAPE_OPTIONS has no effect ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3578


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3631: MINOR: jackson upgrade (2.8.5 -> 2.9.0); version f...

[dejan2609]

GitHub user dejan2609 opened a pull request:

https://github.com/apache/kafka/pull/3631

MINOR: jackson upgrade (2.8.5 -> 2.9.0); version forcing for 
'jackson-annotations' is deprecated

**_Prologue:_** PR #3116

**_Jackson release notes:_**
- https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8
- https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9

**_Note:_** you may want to wait for [Jackson 2.9.1 release 
](https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.1)

@ewencp: FYI

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dejan2609/kafka jackson-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3631.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3631


commit 5e5ee808daf67a2996465193df53f12724bb0c6b
Author: dejan2609 
Date:   2017-08-06T16:56:11Z

MINOR: jackson upgrade (2.8.5 -> 2.9.0); version forcing for 
'jackson-annotations' is deprecated




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3620: KAFKA-5700: Producer should not drop header inform...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3620


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (KAFKA-5700) producer missed header information when splitting batches

[huxihx (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huxihx resolved KAFKA-5700.
---
Resolution: Fixed

> producer missed header information when splitting batches
> -
>
> Key: KAFKA-5700
> URL: https://issues.apache.org/jira/browse/KAFKA-5700
> Project: Kafka
>  Issue Type: Bug
>  Components: producer 
>Affects Versions: 0.11.0.0
>Reporter: huxihx
>Assignee: huxihx
>Priority: Critical
>  Labels: reliability
> Fix For: 0.11.0.1
>
>
> In `ProducerBatch.tryAppendForSplit`, invoking 
> `this.recordsBuilder.append(timestamp, key, value);` missed the header 
> information in the ProducerRecord. Should invoke this like :
> `this.recordsBuilder.append(timestamp, key, value, headers);`



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)