Re: Fault Injection

2017-09-01 Thread Viktor Somogyi
Hi Colin, I'd be interested in this and also think it's a valuable thing to have this for the community and would greatly increase the test coverage. Saw you already have a PR, I'll give a review as I have time :). Viktor On Tue, Aug 22, 2017 at 9:36 PM, Timothy Chen wrote:

Re: [DISCUSS] 0.11.0.1 bug fix release

2017-09-01 Thread Damian Guy
Hi all, There is one last outstanding issue in 0.11.0.1. This will hopefully be resolved today. Assuming it is i will cut the first RC tomorrow. Thanks for your patience. Regards, Damian On Tue, 29 Aug 2017 at 10:53 Damian Guy wrote: > We still have 2 outstanding issues

[GitHub] kafka pull request #3709: KAFKA-5759; Allow user to specify relative path as...

2017-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3709 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (KAFKA-5821) Intermittent test failure in SaslPlainSslEndToEndAuthorizationTest.testAcls

2017-09-01 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5821: - Summary: Intermittent test failure in SaslPlainSslEndToEndAuthorizationTest.testAcls Key: KAFKA-5821 URL: https://issues.apache.org/jira/browse/KAFKA-5821 Project: Kafka

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-09-01 Thread Jason Gustafson
Hi Attila, We should allow 3 days for the vote even if it is clear it will pass. Thanks, Jason On Fri, Sep 1, 2017 at 8:16 AM, Attila Kreiner wrote: > Hi All, > > Looks like accepted. Updating KIP page. > > Thx, > Attila > > 2017-08-31 19:22 GMT+02:00 Matthias J. Sax

Re: Dry-run option for new admin commands

2017-09-01 Thread Viktor Somogyi
Yea, I think we have to make a constraint that the dry-run is valid as far as the environment doesn't change. Also I think too that we can dismiss reporting admin operations (like --describe) as they won't be that useful and focus only on those which are altering. (Hope I got your questions

Request access to Wiki

2017-09-01 Thread charly molter
Hi, I would like to open a KIP and start a discussion. Could someone please grant me access. My username is cmolter: https://cwiki.apache.org/confluence/display/~cmolter Thanks! -- Charly Molter

Dry-run option for new admin commands

2017-09-01 Thread Viktor Somogyi
Hi all, I've been working on creating a KIP for one of the jiras that aim to refactor the admin commands (KAFKA-3268 -> KAFKA-5722 ) and I see that the KIPs related to these are still under

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-09-01 Thread Attila Kreiner
Hi All, Looks like accepted. Updating KIP page. Thx, Attila 2017-08-31 19:22 GMT+02:00 Matthias J. Sax : > +1 > > On 8/31/17 8:49 AM, Jason Gustafson wrote: > > +1 > > > > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison < > mickael.mai...@gmail.com> > > wrote: > > > >>

[GitHub] kafka pull request #3777: KAFKA-5820 Remove unneeded synchronized keyword in...

2017-09-01 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/3777 KAFKA-5820 Remove unneeded synchronized keyword in StreamThread I removed synchronized keyword from 3 methods. I ran the change thru streams module where test suite passed. You can merge

[jira] [Resolved] (KAFKA-5785) Always close connection if KafkaChannel.setSend throws exception

2017-09-01 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-5785. Resolution: Duplicate KAFKA-5607 includes a fix for this. > Always close connection if

Re: Dry-run option for new admin commands

2017-09-01 Thread Ted Yu
State change on broker side may be subject to various factors (network, disk, etc). How would the dry-run report state change which is close to what actually happens in non-dry-run mode ? Thanks On Fri, Sep 1, 2017 at 7:48 AM, Viktor Somogyi wrote: > Hi all, > > I've

[jira] [Created] (KAFKA-5820) Remove unneeded synchronized keyword in StreamThread

2017-09-01 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-5820: - Summary: Remove unneeded synchronized keyword in StreamThread Key: KAFKA-5820 URL: https://issues.apache.org/jira/browse/KAFKA-5820 Project: Kafka Issue Type: Improvement

Re: Fault Injection

2017-09-01 Thread Colin McCabe
Thanks, Victor. Also check out the fault injection umbrella JIRA here: https://issues.apache.org/jira/browse/KAFKA-5775 with more subtasks. cheers, Colin On Fri, Sep 1, 2017, at 05:07, Viktor Somogyi wrote: > Hi Colin, > > I'd be interested in this and also think it's a valuable thing to have

Re: Request access to Wiki

2017-09-01 Thread Jun Rao
Hi, Charly, Thanks for your interest. Just granted you the permission to the wiki. Jun On Fri, Sep 1, 2017 at 9:22 AM, charly molter wrote: > Hi, > > I would like to open a KIP and start a discussion. > > Could someone please grant me access. > > My username is

Re: [VOTE] KIP-182 - Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-09-01 Thread Bill Bejeck
+1 On Thu, Aug 31, 2017 at 10:20 AM, Damian Guy wrote: > Thanks everyone for voting! Unfortunately i've had to make a bit of an > update based on some issues found during implementation. > The main changes are: > BytesStoreSupplier -> StoreSupplier > Addition of: >

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-09-01 Thread Attila Kreiner
Hi Jason, Sorry, I didn't know that one. Then I assume we should wait a few days before moving forward. Regards, Attila 2017-09-01 18:01 GMT+02:00 Jason Gustafson : > Hi Attila, > > We should allow 3 days for the vote even if it is clear it will pass. > > Thanks, > Jason >

[jira] [Created] (KAFKA-5823) Update Docs

2017-09-01 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-5823: -- Summary: Update Docs Key: KAFKA-5823 URL: https://issues.apache.org/jira/browse/KAFKA-5823 Project: Kafka Issue Type: Sub-task Reporter:

Re: [VOTE] KIP-182 - Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-09-01 Thread Matthias J. Sax
+1 On 9/1/17 2:53 PM, Bill Bejeck wrote: > +1 > > On Thu, Aug 31, 2017 at 10:20 AM, Damian Guy wrote: > >> Thanks everyone for voting! Unfortunately i've had to make a bit of an >> update based on some issues found during implementation. >> The main changes are: >>

[GitHub] kafka pull request #3778: KAFKA-5822: Consistent log formatting of topic par...

2017-09-01 Thread hachikuji
GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/3778 KAFKA-5822: Consistent log formatting of topic partitions You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-5822

[jira] [Created] (KAFKA-5822) Consistent logging of topic partitions

2017-09-01 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-5822: -- Summary: Consistent logging of topic partitions Key: KAFKA-5822 URL: https://issues.apache.org/jira/browse/KAFKA-5822 Project: Kafka Issue Type:

[jira] [Resolved] (KAFKA-4411) broker don't have access to kafka zookeeper nodes

2017-09-01 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-4411. -- Resolution: Not A Problem It is necessary to have the same principal name across all brokers for ZK

[jira] [Resolved] (KAFKA-4337) Create topic in multiple zookeepers with Kafka AdminUtils.CreateTopic JAVA API in Kafka 0.9.0.1 gives Error (Topic gets created in only one of the specified zookeeper)

2017-09-01 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-4337. -- Resolution: Won't Fix > Create topic in multiple zookeepers with Kafka AdminUtils.CreateTopic JAVA >

[jira] [Resolved] (KAFKA-4264) kafka-server-stop.sh fails is Kafka launched via kafka-server-start.sh

2017-09-01 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-4264. -- Resolution: Duplicate This is related to KAFKA-4931. PR is available for KAFKA-4931. >

[jira] [Created] (KAFKA-5819) Add Joined class and relevant KStream join overloads

2017-09-01 Thread Damian Guy (JIRA)
Damian Guy created KAFKA-5819: - Summary: Add Joined class and relevant KStream join overloads Key: KAFKA-5819 URL: https://issues.apache.org/jira/browse/KAFKA-5819 Project: Kafka Issue Type:

[GitHub] kafka pull request #3776: KAFKA-5819: Add Joined class and relevant KStream ...

2017-09-01 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3776 KAFKA-5819: Add Joined class and relevant KStream join overloads Add the `Joined` class and the overloads to `KStream` that use it. Deprecate existing methods that have `Serde` params You can

Re: [DISCUSS] KIP-190: Handle client-ids consistently between clients and brokers

2017-09-01 Thread Gwen Shapira
Thanks for bumping this. I do have a concern: This proposal changes the names of existing metrics - as such, it will require all owners of monitoring systems to update their dashboards. It will also complicate monitoring of multiple clusters with different versions and require some modifications

Re: [VOTE] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient

2017-09-01 Thread Gwen Shapira
Thank you! +1 (binding). On Thu, Aug 31, 2017 at 9:48 AM Jun Rao wrote: > Hi, Tom, > > Thanks for the KIP. +1. Just one more minor comment. It seems that the > ElectPreferredLeadersResponse > should expect at least 3 other types of errors : (1) request timeout > exception,