Re: [DISCUSS] KIP-269: Substitution Within Configuration Values

2018-04-08 Thread Rajini Sivaram
Hi Ron, Thanks for the responses. For broader use as configs, opt-in makes sense to avoid any surprises and a global opt-in ought to be fine. If we do want to use this for all configs, a few things to consider: - How will sasl.jaas.config property will get parsed? This is essentially a

Re: [DISCUSS] KIP-284 Set default retention ms for Streams repartition topics to Long.MAX_VALUE

2018-04-08 Thread khaireddine Rezgui
ok 2018-04-08 1:04 GMT+01:00 Ted Yu : > Several sections, such as 'Public Interfaces', only contain template. > > Can you modify the KIP so that it is easier to read ? > > Thanks > > On Sat, Apr 7, 2018 at 2:57 PM, khaireddine Rezgui < > khaireddine...@gmail.com > > wrote: >

Re: [DISCUSS] KIP-283 Set default retention ms for Streams repartition topics to Long.MAX_VALUE

2018-04-08 Thread khaireddine Rezgui
yes Ted, the next kip number was not updated, so i fixed it and i created kip-284 :) So you can ignore this thread 2018-04-08 0:45 GMT+01:00 Ted Yu : > Did you intend to say KIP-284 ? > KIP-283 is for another proposal. > Original message From: khaireddine

[jira] [Resolved] (KAFKA-6688) The Trogdor coordinator should track task statuses

2018-04-08 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-6688. --- Resolution: Fixed Reviewer: Rajini Sivaram Fix Version/s: 1.2.0 > The Trogdor

RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-08 Thread Luís Cabral
Hi Matthias, bq. Why do we need two new configs? Why is the topic config `compaction.strategy` not sufficient? As I understand these configurations, one allows you to configure the default for all topics while the other allows you to configure a single topic directly. If this is incorrect, or

Jenkins build is back to normal : kafka-trunk-jdk8 #2535

2018-04-08 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-284 Set default retention ms for Streams repartition topics to Long.MAX_VALUE

2018-04-08 Thread khaireddine Rezgui
KIP updated. 2018-04-08 9:47 GMT+01:00 khaireddine Rezgui : > ok > > 2018-04-08 1:04 GMT+01:00 Ted Yu : > >> Several sections, such as 'Public Interfaces', only contain template. >> >> Can you modify the KIP so that it is easier to read ? >> >>

Build failed in Jenkins: kafka-trunk-jdk7 #3323

2018-04-08 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-6688. The Trogdor coordinator should track task statuses (#4737) -- [...truncated 413.09 KB...]

Build failed in Jenkins: kafka-trunk-jdk8 #2536

2018-04-08 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-6688. The Trogdor coordinator should track task statuses (#4737) -- [...truncated 2.00 MB...]

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-08 Thread Matthias J. Sax
Thanks for clarification. This make sense to me. About naming: the broker config has `cleaner` in it, while the topic config does not. Is might be more consistent if either both have `cleaner` or none of them? (Personally, I would prefer to strip `cleaner` for the broker config.) The sentence

Jenkins build is back to normal : kafka-trunk-jdk7 #3324

2018-04-08 Thread Apache Jenkins Server
See

Jenkins build is back to normal : kafka-trunk-jdk8 #2537

2018-04-08 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-284 Set default retention ms for Streams repartition topics to Long.MAX_VALUE

2018-04-08 Thread Matthias J. Sax
Thank for the KIP. LGTM. -Matthias On 4/8/18 1:55 AM, khaireddine Rezgui wrote: > KIP updated. > > 2018-04-08 9:47 GMT+01:00 khaireddine Rezgui : > >> ok >> >> 2018-04-08 1:04 GMT+01:00 Ted Yu : >> >>> Several sections, such as 'Public

Re: [DISCUSS] KIP-269: Substitution Within Configuration Values

2018-04-08 Thread Ron Dagostino
Hi Rajini. I've also been thinking about how sasl.jaas.config will be parsed. Something that is implicit in the current proposal needs to be made explicit if this is to be applied more broadly, and that is the fact that there is a namespacing of sorts going on. For example, in the current