Re: [VOTE] KIP-342 - Add support for custom SASL extensions in OAuthBearer authentication

2018-08-06 Thread Stanislav Kozlovski
KIP-342 has passed. Here is the vote break down: Binding: - Jason Gustafson - Jun Rao - Rajini Sivaram Non-Binding: - Ron Dagostino Thanks to all of those who voted and provided feedback! On Fri, Aug 3, 2018 at 11:50 PM Jason Gustafson wrote: > +1 Thanks Stanislav! > > On Fri,

Build failed in Jenkins: kafka-2.0-jdk8 #104

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H34 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk10 #374

2018-08-06 Thread Apache Jenkins Server
See Changes: [harsha] KAFKA-7142: fix joinGroup performance issues (#5354) [harsha] Fixed Spelling. (#5432) [wangguoz] MINOR: fix Streams docs state.dir (#5465) --

Jenkins build is back to normal : kafka-1.0-jdk7 #226

2018-08-06 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-2.0-jdk8 #105

2018-08-06 Thread Apache Jenkins Server
See Changes: [matthias] MINOR: Fixed default streams state dir location. (#5441) [matthias] MINOR: fix Streams docs state.dir (#5465) -- [...truncated 438.61 KB...]

Re: [DISCUSS] KIP-320: Allow fetchers to detect and handle log truncation

2018-08-06 Thread Jun Rao
Hi, Jason, Thanks for the reply. They all make sense. Just a couple of more minor comments. 57. I was thinking that if will be useful to encourage people to use the new seek() api to get better semantics. Deprecating the old seek api is one way. I guess we could also just document it for now.

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

2018-08-06 Thread Ray Chiang
I'm okay with that. -Ray On 8/6/18 10:59 AM, Colin McCabe wrote: Perhaps we could start with max.uncleanable.partitions and then implement max.uncleanable.partitions.per.logdir in a follow-up change if it seemed to be necessary? What do you think? regards, Colin On Sat, Aug 4, 2018, at

Build failed in Jenkins: kafka-1.0-jdk7 #225

2018-08-06 Thread Apache Jenkins Server
See -- [...truncated 729 B...] ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://github.com/apache/kafka.git at

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-06 Thread Boyang Chen
Sounds good to me Guozhang. I feel clear and confident about this enhanced design. Kindly asking everyone's opinion on this thread for the updated approach. If we are ok here, I will go ahead to update the KIP and plan out the implementation. Best, Boyang

Re: Add to JIRA

2018-08-06 Thread Matthias J. Sax
What is our user id? I am not aware of any docs, but it's rather simple. kafka/core (brokers) kafka/clients (consumer,producer,admin) kafka/connect kafka/streams kafka/tools (command line tools like `bin/kafka-consumer-group.sh`) kafka/tests (system test) Hope this helps. -Matthias On

Build failed in Jenkins: kafka-2.0-jdk8 #103

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H34 (ubuntu xenial) in workspace

Re: [VOTE] KIP-328: Ability to suppress updates for KTables

2018-08-06 Thread Matthias J. Sax
+1 (binding) Thanks for the KIP. -Matthias On 8/3/18 12:52 AM, Damian Guy wrote: > Thanks John! +1 > > On Mon, 30 Jul 2018 at 23:58 Guozhang Wang wrote: > >> Yes, the addendum lgtm as well. Thanks! >> >> On Mon, Jul 30, 2018 at 3:34 PM, John Roesler wrote: >> >>> Another thing that came up

Re: [DISCUSS] KIP-320: Allow fetchers to detect and handle log truncation

2018-08-06 Thread Jason Gustafson
Hi Jun, I spent a little more time looking at the usage in WorkerSinkTask. I think actually the initialization of the positions in the assignment callback is not strictly necessary. We keep a map of the current consumed offsets which is updated as we consume the data. As far as I can tell, we

Build failed in Jenkins: kafka-1.0-jdk7 #224

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H28 (ubuntu xenial) in workspace

Re: ConsumerGroupCommand tool improvement?

2018-08-06 Thread Vahid S Hashemian
Hi Colin, Thanks for the feedback! I understand your concerns (I was thinking about making this improvement in a way that's fully backward compatible, with similar regex syntax as in some of the existing tools). In any case, If there is not enough interest in the user community I'll rest my

Build failed in Jenkins: kafka-trunk-jdk10 #378

2018-08-06 Thread Apache Jenkins Server
See Changes: [jason] MINOR: Log AdminClient configs (#5457) [lindong28] KAFKA-5928; Avoid redundant requests to zookeeper when reassign topic -- [...truncated 1.59

Re: [DISCUSS] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-08-06 Thread Dong Lin
Hi all, Since we are going to use "command-config" as the option name in KIP-332, I have updated the KIP to use "command-config" for consistency. Please comment if you think "config-file" is better. Thanks, Dong On Fri, Aug 3, 2018 at 2:39 AM, Manikumar wrote: > Hi Dong, > > In KIP-332

Jenkins build is back to normal : kafka-trunk-jdk8 #2870

2018-08-06 Thread Apache Jenkins Server
See

Re: Add to JIRA

2018-08-06 Thread Piyush Sagar
Thanks Matthias J. Sax for help. My username : *piyush_sagar* I'm looking to contribute to JAVA codebase, any pointers for starting up will be helpful. Thanks On Tue, 7 Aug 2018 at 00:53, Matthias J. Sax wrote: > What is our user id? > > I am not aware of any docs, but it's rather simple. >

Build failed in Jenkins: kafka-trunk-jdk8 #2871

2018-08-06 Thread Apache Jenkins Server
See Changes: [jason] MINOR: Log AdminClient configs (#5457) -- [...truncated 1.97 MB...] org.apache.kafka.common.security.scram.internals.ScramFormatterTest >

Build failed in Jenkins: kafka-trunk-jdk10 #375

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H31 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk10 #376

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H31 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk10 #377

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H31 (ubuntu xenial) in workspace

[jira] [Created] (KAFKA-7253) The connector type responded by worker is always null when creating connector

2018-08-06 Thread Chia-Ping Tsai (JIRA)
Chia-Ping Tsai created KAFKA-7253: - Summary: The connector type responded by worker is always null when creating connector Key: KAFKA-7253 URL: https://issues.apache.org/jira/browse/KAFKA-7253

Re: [VOTE] KIP-341: Update Sticky Assignor's User Data Protocol

2018-08-06 Thread Vahid S Hashemian
The KIP passes with 3 binding and 2 non-binding +1 votes, and no -1 or 0 votes. Binding +1s * Jason Gustafson * Dong Lin * Rajini Sivaram Non-binding +1s * Ted Yu * Mike Freyberger Thank you for providing feedback or vote on this KIP. --Vahid From: "Vahid S Hashemian" To: dev

Re: [DISCUSS] KIP-349 Priorities for Source Topics

2018-08-06 Thread nick
> From: "Matthias J. Sax" One general question: The Jira is marked as "stream", so I am wondering what > the intended scope the KIP is because, it suggests a new consumer > API only. Can you clarify? Based on the thread in KAFKA-6690, I’ve changed the component from streams to consumer. --

Re: [VOTE] KIP-341: Update Sticky Assignor's User Data Protocol

2018-08-06 Thread Rajini Sivaram
Hi Vahid, Thanks for the KIP. +1 (binding) Regards, Rajini On Fri, Aug 3, 2018 at 7:27 PM, Dong Lin wrote: > Thanks Vahid! > > +1 > > On Thu, Aug 2, 2018 at 1:27 PM, Vahid S Hashemian < > vahidhashem...@us.ibm.com > > wrote: > > > Hi everyone, > > > > I believe the feedback on this KIP has

Timestamp based log compaction

2018-08-06 Thread Jan Lukavský
Hi, I have a question about log compaction. LogCleaner's JavaDoc states that: {quote} A message with key K and offset O is obsolete if there exists a message with key K and offset O' such that O < O'. {/quote} That works fine if messages are arriving "in-order", i.e. with timestamp

[jira] [Created] (KAFKA-7250) Kafka-Streams-Scala DSL transform shares transformer instance

2018-08-06 Thread Michal (JIRA)
Michal created KAFKA-7250: - Summary: Kafka-Streams-Scala DSL transform shares transformer instance Key: KAFKA-7250 URL: https://issues.apache.org/jira/browse/KAFKA-7250 Project: Kafka Issue Type:

Re: Timestamp based log compaction

2018-08-06 Thread Jan Lukavský
Hi Rajini, thanks for pointing out, that looks like exactly what I had in mind. I wasn't able to google that. Jan On 08/06/2018 12:31 PM, Rajini Sivaram wrote: Can you take a look at KIP-280: https://cwiki.apache.org/confluence/display/KAFKA/KIP-280%3A+Enhanced+log+compaction ? On Mon,

Re: [VOTE] KIP-332: Update AclCommand to use AdminClient API

2018-08-06 Thread Manikumar
Hi All, The vote has passed with 3 binding votes (Rajini, Jason, Dong) and 2 non-binding votes (Ted, Colin). Thanks everyone for the votes. Thanks, Manikumar On Sat, Aug 4, 2018 at 5:09 AM Dong Lin wrote: > Thanks Manikumar! > > +1 > > On Fri, Aug 3, 2018 at 4:33 PM, Jason Gustafson >

Re: [DISCUSS] KIP-351: Add --critical-partitions option to describe topics command

2018-08-06 Thread Kevin Lu
Hi Jason, Thanks for the response! I completely agree with you and Mickael about adding a --under-minisr-partitions option to match the existing metric. I will create a separate KIP to discuss the --under-minisr-partitions option. I believe there is a technical challenge with retrieving the

Build failed in Jenkins: kafka-trunk-jdk10 #370

2018-08-06 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-7183: Add a trogdor test that creates many connections to brokers -- [...truncated 1.53 MB...]

Re: Timestamp based log compaction

2018-08-06 Thread Rajini Sivaram
Can you take a look at KIP-280: https://cwiki.apache.org/confluence/display/KAFKA/KIP-280%3A+Enhanced+log+compaction ? On Mon, Aug 6, 2018 at 10:55 AM, Jan Lukavský wrote: > Hi, > > I have a question about log compaction. LogCleaner's JavaDoc states that: > > {quote} > > A message with key K

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

2018-08-06 Thread Colin McCabe
Thanks, Manikumar. Sounds good. best, Colin On Mon, Aug 6, 2018, at 08:57, Manikumar wrote: > Hi All, > > For this KIP, I will be using "--command-config" option name to specify > config file. > We can handle the naming discrepancies as part of KIP-14. > > Thanks, > > > > > > On Sat, Aug

[jira] [Created] (KAFKA-7252) Default value for 'state.dir' is incorrect in the docs

2018-08-06 Thread Brett Harper (JIRA)
Brett Harper created KAFKA-7252: --- Summary: Default value for 'state.dir' is incorrect in the docs Key: KAFKA-7252 URL: https://issues.apache.org/jira/browse/KAFKA-7252 Project: Kafka Issue

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

2018-08-06 Thread Colin McCabe
Perhaps we could start with max.uncleanable.partitions and then implement max.uncleanable.partitions.per.logdir in a follow-up change if it seemed to be necessary? What do you think? regards, Colin On Sat, Aug 4, 2018, at 10:53, Stanislav Kozlovski wrote: > Hey Ray, > > Thanks for the

Build failed in Jenkins: kafka-trunk-jdk10 #372

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H31 (ubuntu xenial) in workspace

Add to JIRA

2018-08-06 Thread Piyush Sagar
Hello All, Can anyone please add me to JIRA ? Also, Is there any document(Confluence page) which briefs folder structure/ sub modules of the main kafka repository ? Thanks

Re: [DISCUSS] KIP-320: Allow fetchers to detect and handle log truncation

2018-08-06 Thread Jason Gustafson
Hey Jun, Thanks for the review. Responses below: 50. Yes, that is right. I clarified this in the KIP. 51. Yes, updated the KIP to mention. 52. Yeah, this was a reference to a previous iteration. I've fixed it. 53. I changed the API to use an `Optional` for the leader epoch and added a note

[jira] [Created] (KAFKA-7251) Add support for TLS 1.3

2018-08-06 Thread Rajini Sivaram (JIRA)
Rajini Sivaram created KAFKA-7251: - Summary: Add support for TLS 1.3 Key: KAFKA-7251 URL: https://issues.apache.org/jira/browse/KAFKA-7251 Project: Kafka Issue Type: New Feature

Build failed in Jenkins: kafka-trunk-jdk10 #371

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H30 (ubuntu xenial) in workspace

Build failed in Jenkins: kafka-trunk-jdk8 #2868

2018-08-06 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H32 (ubuntu xenial) in workspace

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

2018-08-06 Thread Manikumar
Hi All, For this KIP, I will be using "--command-config" option name to specify config file. We can handle the naming discrepancies as part of KIP-14. Thanks, On Sat, Aug 4, 2018 at 4:53 AM Jason Gustafson wrote: > Here's hoping someone has time to pick up KIP-14 again: > >

Build failed in Jenkins: kafka-trunk-jdk8 #2867

2018-08-06 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-7183: Add a trogdor test that creates many connections to brokers -- [...truncated 426.36 KB...]

[VOTE] KIP-310: Add a Kafka Source Connector to Kafka Connect

2018-08-06 Thread McCaig, Rhys
Hi All, I’m starting a vote on KIP-310: Add a Kafka Source Connector to Kafka Connect KIP:

Re: ConsumerGroupCommand tool improvement?

2018-08-06 Thread Vahid S Hashemian
Hi Colin, Thanks for considering the idea and sharing your feedback. The improvements I proposed can be achieved, to some extend, using the AdminClient API and the Consumer Group CLI tool. But they won't fully support the proposal. For example, Regular expressions are not supported on the