Follow-up on KAFKA-7286

Hi there, Not sure if this is expected behaviour (according to the contributing guide , it seems to be), let me know if not. I opened an issue some days ago (KAFKA-7286 ) along with a related Github PR

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

Hello, Matthias, John. Thanks in advance. > I wanted to let you know that we have dropped the `grace(long)` method from > the Windows interface `grace(long)` removed from the KIP. > It seems like, if we want to use long millis internally, then we just need to > leave Windows alone.

[jira] [Resolved] (KAFKA-4065) Missing Property in ProducerConfig.java - KafkaProducer API 0.9.0.0

[ https://issues.apache.org/jira/browse/KAFKA-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-4065. -- Resolution: Auto Closed Closing inactive issue. It is highly unlikely to add this feature. >

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

+1 (non-binding) On Sat, Aug 25, 2018 at 1:16 PM Joan Goyeau wrote: > Hi, > > We want to make sure that we always have a serde for all Materialized, > Serialized, Joined, Consumed and Produced. > For that we can make use of the implicit parameters in Scala. > > KIP: > >

Re: [VOTE] KIP-357: Add support to list ACLs per principal

+1 (binding) -Harsha On Mon, Aug 27, 2018, at 12:46 PM, Jakub Scholz wrote: > +1 (non-binding) > > On Mon, Aug 27, 2018 at 6:24 PM Manikumar wrote: > > > Hi All, > > > > I would like to start voting on KIP-357 which allows to list ACLs per > > principal using AclCommand (kafka-acls.sh) > > >

[jira] [Created] (KAFKA-7349) Long Disk Writes cause Zookeeper Disconnects

Adam Kafka created KAFKA-7349: - Summary: Long Disk Writes cause Zookeeper Disconnects Key: KAFKA-7349 URL: https://issues.apache.org/jira/browse/KAFKA-7349 Project: Kafka Issue Type: Bug

Re: [VOTE] KIP-363: Make FunctionConversions private

John, no this is for internal use only. I fact I expect this object to go away with the drop of Scala 2.11 since in Scala 2.12 we have support for SAM. Thanks On Mon, 27 Aug 2018 at 15:41 John Roesler wrote: > Hey Joan, > > I was thinking more about this... Do any of the conversions in >

Re: [VOTE] KIP-357: Add support to list ACLs per principal

+1 (Non-binding) On 8/27/18, 9:24 AM, "Manikumar" wrote: Hi All, I would like to start voting on KIP-357 which allows to list ACLs per principal using AclCommand (kafka-acls.sh) KIP:

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

I like John's idea as well: for this KIP specifically as we do not expect any other consumers to read the repartition topics externally, we can slightly prefix the header to be safe, while keeping the additional cost (note the header field is per-record, so any additional byte is per-record as

Re: [VOTE] KIP-357: Add support to list ACLs per principal

+1 (non-binding) On Mon, Aug 27, 2018 at 6:24 PM Manikumar wrote: > Hi All, > > I would like to start voting on KIP-357 which allows to list ACLs per > principal using AclCommand (kafka-acls.sh) > > KIP: > >

Re: [VOTE] KIP-357: Add support to list ACLs per principal

+1 On Mon, Aug 27, 2018 at 11:42 AM Priyank Shah wrote: > +1 (Non-binding) > > On 8/27/18, 9:24 AM, "Manikumar" wrote: > > Hi All, > > I would like to start voting on KIP-357 which allows to list ACLs per > principal using AclCommand (kafka-acls.sh) > > KIP: > >

[jira] [Resolved] (KAFKA-3369) Add unit-tests to the Metadata Cache

[ https://issues.apache.org/jira/browse/KAFKA-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-3369. -- Resolution: Fixed Closing as per above comment. > Add unit-tests to the Metadata Cache >

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

+1 On Mon, Aug 27, 2018 at 12:18 PM John Roesler wrote: > +1 (non-binding) > > On Sat, Aug 25, 2018 at 1:16 PM Joan Goyeau wrote: > > > Hi, > > > > We want to make sure that we always have a serde for all Materialized, > > Serialized, Joined, Consumed and Produced. > > For that we can make use

Re: [VOTE] KIP-363: Make FunctionConversions private

+1 -Bill On Mon, Aug 27, 2018 at 10:41 AM John Roesler wrote: > Hey Joan, > > I was thinking more about this... Do any of the conversions in > FunctionConversions convert to types that are used in the public Scala > interface? > > If you've already checked, then carry on. > > Otherwise, we

Re: [DISCUSS] KIP-354 Time-based log compaction policy

Hi All, Do you have any additional comments on this KIP? On Thu, Aug 16, 2018 at 9:17 PM, xiongqi wu wrote: > on 2) > The offsetmap is built starting from dirty segment. > The compaction starts from the beginning of the log partition. That's how > it ensure the deletion of tomb keys. > I

Re: [VOTE] KIP-336: Consolidate ExtendedSerializer/Serializer and ExtendedDeserializer/Deserializer

Thanks Viktor. I think it would be good to verify that existing ExtendedSerializer implementations work without recompiling. This could be done as a manual test. If you agree, I suggest adding it to the testing plan section. Ismael On Mon, Aug 27, 2018 at 7:57 AM Viktor Somogyi-Vass wrote: >

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Looking at the code for solution #1: } else if (builder.build(version) instanceof List){ wouldn't AbstractRequest be gone due to type erasure ? Which solution do you favor ? Cheers On Mon, Aug 27, 2018 at 4:20 PM

[jira] [Resolved] (KAFKA-7347) Wrong error code returned for OffsetsForLeaderEpoch from non-replica

[ https://issues.apache.org/jira/browse/KAFKA-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-7347. Resolution: Fixed Fix Version/s: 2.1.0 > Wrong error code returned for

Re: [DISCUSS] KIP-291: Have separate queues for control requests and data requests

Thanks for the comments, Joel. I addressed all but the last one, where Jun also shared a comment in the Vote thread to change it to "controller.listener.name". I actually feel CONTROLLER is better since it's a well defined concept in Kafka, while it's easier to confuse people with CONTROL since

Re: [VOTE] KIP-291: Have separate queues for control requests and data requests

Thanks for the comments, Jun. 1. I think the answer should be no, since the "inter.broker.listener.name" are also used for replication traffic, and merging these two types of request to the single threaded tunnel would defeat the purpose of this KIP and also hurt replication throughput. So I

Build failed in Jenkins: kafka-trunk-jdk10 #439

See Changes: [wangguoz] MINOR: Correct folder for package object scala (#5573) -- [...truncated 1.53 MB...] kafka.coordinator.transaction.TransactionCoordinatorTest >

Jenkins build is back to normal : kafka-trunk-jdk8 #2928

See

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Sorry for the delay, I have been struggling to come up with a nice solution: I have updated the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-347%3A++Enable+batching+in+FindCoordinatorRequest In summary, to solve the question Guozhang raised: "One tricky question is, how do we know

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

+1 -Bill On Mon, Aug 27, 2018 at 3:24 PM Ted Yu wrote: > +1 > > On Mon, Aug 27, 2018 at 12:18 PM John Roesler wrote: > > > +1 (non-binding) > > > > On Sat, Aug 25, 2018 at 1:16 PM Joan Goyeau wrote: > > > > > Hi, > > > > > > We want to make sure that we always have a serde for all

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Hi Ted, you are right! I fixed it to List. I would prefer the first solution because all the logics will be added on NetworkClient.java, and changing the current AbstractRequest class seems a little unnecessary. Thanks Yishun On Mon, Aug 27, 2018 at 4:57 PM Ted Yu wrote: > > Looking at the code

[jira] [Resolved] (KAFKA-6753) Speed up event processing on the controller

[ https://issues.apache.org/jira/browse/KAFKA-6753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Wang resolved KAFKA-6753. --- Resolution: Fixed > Speed up event processing on the controller >

[jira] [Created] (KAFKA-7350) Improve or remove the PreferredReplicaImbalanceCount metric

Lucas Wang created KAFKA-7350: - Summary: Improve or remove the PreferredReplicaImbalanceCount metric Key: KAFKA-7350 URL: https://issues.apache.org/jira/browse/KAFKA-7350 Project: Kafka Issue

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

+1 (non-binding) On Tue, Aug 28, 2018 at 8:53 AM Bill Bejeck wrote: > +1 > > -Bill > > On Mon, Aug 27, 2018 at 3:24 PM Ted Yu wrote: > > > +1 > > > > On Mon, Aug 27, 2018 at 12:18 PM John Roesler wrote: > > > > > +1 (non-binding) > > > > > > On Sat, Aug 25, 2018 at 1:16 PM Joan Goyeau wrote:

Re: [VOTE] KIP-357: Add support to list ACLs per principal

+1 (non-binding) On Tue, Aug 28, 2018 at 2:59 AM, Harsha wrote: > +1 (binding) > > -Harsha > > On Mon, Aug 27, 2018, at 12:46 PM, Jakub Scholz wrote: > > +1 (non-binding) > > > > On Mon, Aug 27, 2018 at 6:24 PM Manikumar > wrote: > > > > > Hi All, > > > > > > I would like to start voting on

Re: [VOTE] KIP-363: Make FunctionConversions private

Hey Joan, I was thinking more about this... Do any of the conversions in FunctionConversions convert to types that are used in the public Scala interface? If you've already checked, then carry on. Otherwise, we should leave public any that might be in use. Thanks, -John On Sat, Aug 25, 2018

Re: [VOTE] KIP-336: Consolidate ExtendedSerializer/Serializer and ExtendedDeserializer/Deserializer

Thanks guys, I've updated my KIP with this info (so to keep solution #1). If you find it good enough, please vote as well or let me know if you think something is missing. On Sat, Aug 25, 2018 at 1:14 AM Ismael Juma wrote: > I'm OK with 1 too. It makes me a bit sad that we don't have a path for

Re: Follow-up on KAFKA-7286

Hi Flavien, As far as I'm concerned, it's perfectly appropriate to keep pinging periodically if no one responds to your ticket. I'm sorry no one commented on your ticket or PR! I have to admit that I don't know much about the coordinator, but I do have one question I'll leave a comment on the

Re: [EXTERNAL] [DISCUSS] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

Randall, This KIP looks great to me. As for _updating_ topic configs - It’s a nice to have but certainly something that I could live without in order to get this KIP implemented. (Its not something I would use in my current setup but I can see some cases where it could be part of the workflow

[VOTE] KIP-357: Add support to list ACLs per principal

Hi All, I would like to start voting on KIP-357 which allows to list ACLs per principal using AclCommand (kafka-acls.sh) KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-357%3A++Add+support+to+list+ACLs+per+principal Discussion Thread: