Re: [VOTE] KIP-457: Add DISCONNECTED status to Kafka Streams

2019-04-17 Thread Richard Yu
Sorry everybody, if you don't mind holding off voting for a second. Something came up, take a look at the discussion thread. - Richard On Wed, Apr 17, 2019 at 8:46 AM Richard Yu wrote: > Hi all, > > I would like to propose a minor change to the current KafkaStreams#state() > method. >

Re: Cleaning up command line tools argument parsing a little

2019-04-17 Thread McCaig, Rhys
Sönke - I think this is a great idea. I’d be willing to help out where I can if there is a new issue to track this. > On Apr 17, 2019, at 9:02 AM, Sönke Liebau > wrote: > > I actually have a theory how that came about. > > All classes that use argparse4j are situated in the tools and connect

[jira] [Resolved] (KAFKA-7965) Flaky Test ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2019-04-17 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-7965. Resolution: Fixed > Flaky Test >

Build failed in Jenkins: kafka-trunk-jdk11 #442

2019-04-17 Thread Apache Jenkins Server
See Changes: [github] KAFKA-6455: KStream-KStream join should set max timestamp for result -- [...truncated 2.37 MB...] org.apache.kafka.streams.test.OutputVerifierTest

[jira] [Resolved] (KAFKA-8241) Dynamic update of keystore fails on listener without truststore

2019-04-17 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-8241. --- Resolution: Fixed Reviewer: Manikumar Fix Version/s: 2.1.2 > Dynamic update

Re: [VOTE] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-17 Thread Bill Bejeck
Thanks for the KIP. +1(binding) -Bill On Wed, Apr 17, 2019 at 12:58 PM Bruno Cadonna wrote: > Hi Maarten Duijn, > > Thank you for driving this. > > +1 (non-binding) > > Best, > Bruno > > On Wed, Apr 17, 2019 at 8:21 AM Maarten Duijn > wrote: > > > Hello all, > > > > There has been informal

Build failed in Jenkins: kafka-trunk-jdk8 #3564

2019-04-17 Thread Apache Jenkins Server
See Changes: [github] KAFKA-6455: KStream-KStream join should set max timestamp for result [github] KAFKA-8241; Handle configs without truststore for broker keystore update

Re: [VOTE] KIP-433: Block old clients on brokers

2019-04-17 Thread Ying Zheng
I have updated the config description in the KIP, made the example more clear The proposed change allows setting different min versions for different APIs, and the ApiVersionRequest change is already in the KIP. On Fri, Apr 12, 2019 at 8:22 PM Harsha wrote: > Hi Ismael, > I meant

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Richard Yu
I just realized something. Hi Matthias, might need your input here. I realized that when implementing this change, as noted in the JIRA, we would need to "check the behaviour of the consumer" since its consumer's connection with broker that we are dealing with. So doesn't that mean we would also

Build failed in Jenkins: kafka-trunk-jdk11 #443

2019-04-17 Thread Apache Jenkins Server
See Changes: [github] KAFKA-8241; Handle configs without truststore for broker keystore update -- [...truncated 2.39 MB...]

Re: [DISCUSS] KIP-451: Make TopologyTestDriver output iterable

2019-04-17 Thread Patrik Kleindl
Hi all Unless someone has objections I will start a VOTE thread tomorrow. The KIP adds two methods to the TopologyTestDriver and has no conflicts for existing users. PR https://github.com/apache/kafka/pull/6556 is already being reviewed. Side-note:

Remove my email from the list.

2019-04-17 Thread Zhou, Limin (Ray)
Hello Guys Can any of you remove my email address from the list? I am not interested to be in the group anymore, but it doesn’t work by just sending email to dev-unsubscr...@kafka.apache.org, Once again please remove my email ASAP. I hate to received 30+ emails everyday Thanks ahead Raymond

Re: [VOTE] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-17 Thread Maarten Duijn
For those interested, a WIP PR is now available at: https://github.com/apache/kafka/pull/6593 Maarten

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Richard Yu
Alright, so I made a few changes to the KIP. I realized that there might be an easier way to give the user information on the connection state of Kafka Streams. In implementation, if one wishes to have DISCONNECTED as a state, then one would have to factor in proper state transitions. The other

[jira] [Created] (KAFKA-8248) Producer may fail IllegalStateException

2019-04-17 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-8248: -- Summary: Producer may fail IllegalStateException Key: KAFKA-8248 URL: https://issues.apache.org/jira/browse/KAFKA-8248 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-8185) Controller becomes stale and not able to failover the leadership for the partitions

2019-04-17 Thread Dhruvil Shah (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhruvil Shah resolved KAFKA-8185. - Resolution: Not A Problem This is not a typically expected scenario and would only happen when

Re: Cleaning up command line tools argument parsing a little

2019-04-17 Thread Colin McCabe
If we are going to standardize on one argument parsing library, it should certainly be argparse4j, I think. argparse4j is simply a better argument parsing library with support for more features. One example is mutually exclusive options. argparse4j supports this with MutuallyExclusiveGroup.

Re: [DISCUSS] KIP-455: Create an Administrative API for Replica Reassignment

2019-04-17 Thread Robert Barrett
Thanks for the KIP, Colin. I have a couple questions: 1. What's the reasoning for requiring cancellation of a reassignment before submitting a new one? It seems like overriding an existing reassignment could be done with a single update to /brokers/topics/[topic]/partitions/[partitionId]/state

[jira] [Created] (KAFKA-8250) Flaky Test DelegationTokenEndToEndAuthorizationTest#testProduceConsumeViaAssign

2019-04-17 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-8250: -- Summary: Flaky Test DelegationTokenEndToEndAuthorizationTest#testProduceConsumeViaAssign Key: KAFKA-8250 URL: https://issues.apache.org/jira/browse/KAFKA-8250

Jenkins build is back to normal : kafka-trunk-jdk8 #3565

2019-04-17 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-8252) topic catalog.offer-updated.1 has an unexpected message

2019-04-17 Thread zan fu (JIRA)
zan fu created KAFKA-8252: - Summary: topic catalog.offer-updated.1 has an unexpected message Key: KAFKA-8252 URL: https://issues.apache.org/jira/browse/KAFKA-8252 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-8252) topic catalog.offer-updated.1 has an unexpected message

2019-04-17 Thread zan fu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zan fu resolved KAFKA-8252. --- Resolution: Not A Bug > topic catalog.offer-updated.1 has an unexpected message >

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Thanks for the feedback Colin. And agree we should enable it for all the components as this feature is going to benefit all the components and not just Connect. I have updated the KIP to enable it for all the components. Thanks, Tejal On 2019/04/17 23:22:50, "Colin McCabe" wrote: > On

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread Randall Hauch
Thanks for making the changes, Tejal. The KIP looks great. Randall On Wed, Apr 17, 2019 at 10:32 AM TEJAL ADSUL wrote: > > Thanks for the feedback Randall. I have incorporated the below changes in > the KIP. > > Thanks, > Tejal > > On 2019/04/17 15:42:31, Randall Hauch wrote: > > Overall this

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread Colin McCabe
On Wed, Apr 17, 2019, at 07:49, TEJAL ADSUL wrote: > > Hi Colin, > > By default we are enabling this feature only Connect. All the other > components can enable or disable the feature as needed. Hi Tejal, I believe we should enable automatically resolving external configurations in all

Jenkins build is back to normal : kafka-trunk-jdk11 #444

2019-04-17 Thread Apache Jenkins Server
See

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Hi Rajini and Colin, I have incorporated your feedbacks and have enabled the the automatic resolution of configs for all the components. Also I have removed the flag to enable or disable the feature to address Rajini's feedback as the user won't be able to enable or disable the feature so it

Build failed in Jenkins: kafka-trunk-jdk8 #3566

2019-04-17 Thread Apache Jenkins Server
See Changes: [bbejeck] Added note to RocksDBConfigSetter (#6578) [bbejeck] [HOT FIX] Check for null before deserializing in MeteredSessionStore [wangguoz] KAFKA-7652: Restrict range of fetch/findSessions in

[jira] [Created] (KAFKA-8251) Consider different logging for purgeData

2019-04-17 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-8251: -- Summary: Consider different logging for purgeData Key: KAFKA-8251 URL: https://issues.apache.org/jira/browse/KAFKA-8251 Project: Kafka Issue Type:

Build failed in Jenkins: kafka-trunk-jdk11 #445

2019-04-17 Thread Apache Jenkins Server
See Changes: [bbejeck] [HOT FIX] Check for null before deserializing in MeteredSessionStore [wangguoz] KAFKA-7652: Restrict range of fetch/findSessions in cache (#6448)

Re: [DISCUSS] 2.3.0 release

2019-04-17 Thread Colin McCabe
Hi all, Here are the proposed dates for the 2.3 release. 1) KIP Freeze: May 8, 2019. A KIP must be accepted by this date in order to be considered for this release) 2) Feature Freeze: May 15, 2019 Major features merged & working on stabilization, minor features have PR, release branch cut;

Build failed in Jenkins: kafka-1.1-jdk7 #260

2019-04-17 Thread Apache Jenkins Server
See Changes: [github] MINOR: Removed unused import (#6587) -- [...truncated 434.66 KB...] kafka.utils.CoreUtilsTest > testReplaceSuffix PASSED kafka.utils.CoreUtilsTest >

[jira] [Created] (KAFKA-8249) partition reassignment may never finish if topic deletion completes first

2019-04-17 Thread xiongqi wu (JIRA)
xiongqi wu created KAFKA-8249: - Summary: partition reassignment may never finish if topic deletion completes first Key: KAFKA-8249 URL: https://issues.apache.org/jira/browse/KAFKA-8249 Project: Kafka

Jenkins build is back to normal : kafka-2.1-jdk8 #164

2019-04-17 Thread Apache Jenkins Server
See

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread Rajini Sivaram
Thanks Tejal, KIP looks good. A couple of comments/questions: The KIP changes the public `AbstractConfig` class to enable existing components to choose whether or not to resolve external configs. For a specific component, (e.g. broker), will this allow users to choose whether or not to resolve

Cleaning up command line tools argument parsing a little

2019-04-17 Thread Sönke Liebau
Hi everybody, Jason and I were recently discussing command line argument parsing on KAFKA-8131 (or rather the related pull request) [1]. Command line tools and their arguments are somewhat diverse at the moment. Most of the tools use joptsimple for argument parsing, some newer java tools use

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Hi Rajini, The user wont have the ability to choose whether config value should be enabled/disabled. Its enable/disabled per component by hardcoding the value. I have documented your recommendations in the compatibility sections. Thanks, Tejal

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Michael Noll
Richard, thanks for looking into this! However, I have some concerns. The KIP you created ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-457%3A+Add+DISCONNECTED+status+to+Kafka+Streams) doesn't yet address open questions such as the ones mentioned by Matthias: 1) What is the difference

Re: Cleaning up command line tools argument parsing a little

2019-04-17 Thread Ryanne Dolan
Sönke, I'd find this very helpful. It's annoying to keep track of which commands use which form -- I always seem to guess wrong. Though I don't think there is any reason to deprecate existing forms, e.g. consumer.config vs consumer-config. I think it's perfectly reasonable to have multiple

Re: Cleaning up command line tools argument parsing a little

2019-04-17 Thread Sönke Liebau
I actually have a theory how that came about. All classes that use argparse4j are situated in the tools and connect projects, which doesn't have a dependency on core. But that's where all the CommandLine stuff that uses joptsimple is located. So to gain access to that (not joptsimple itself, but

Build failed in Jenkins: kafka-trunk-jdk8 #3563

2019-04-17 Thread Apache Jenkins Server
See -- [...truncated 545 B...] > git config remote.origin.url https://github.com/apache/kafka.git # timeout=10 Fetching upstream changes from https://github.com/apache/kafka.git > git

Re: Request for adding me as contributor in Kafka project

2019-04-17 Thread Matthias J. Sax
Done. On 4/17/19 2:28 AM, nitin agarwal wrote: > Hi, > > I have graduated from IIT Hyderabad in 2014. I am currently working as > Software Development Engineer in Flipkart. I want to contribute in Kafka > project, can you please add my username as contributor in Kafka project. > Username:

[jira] [Created] (KAFKA-8247) Duplicate error handling in kafka-server-start.sh and actual Kafka class

2019-04-17 Thread JIRA
Sönke Liebau created KAFKA-8247: --- Summary: Duplicate error handling in kafka-server-start.sh and actual Kafka class Key: KAFKA-8247 URL: https://issues.apache.org/jira/browse/KAFKA-8247 Project: Kafka

Bay area Kafka Meetup hosted by Confluent at Palo Alto, Monday 6pm, April 29, 2019

2019-04-17 Thread Guozhang Wang
Hello folks, The Confluent engineering team would like to invite you all to attend the first-ever Confluent hosted Bay Area Kafka® meetup on Monday 6pm, at Confluent's Palo Alto HQ. *RSVP and Register* (if you intend to attend in person): https://www.meetup.com/KafkaBayArea/events/260657485/

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Hi Colin, By default we are enabling this feature only Connect. All the other components can enable or disable the feature as needed. No it won't reload the configuration if its not configured using KIP 226 as in order for the dynamic configs to be reloaded it has to be triggered by the

Request for adding me as contributor in Kafka project

2019-04-17 Thread nitin agarwal
Hi, I have graduated from IIT Hyderabad in 2014. I am currently working as Software Development Engineer in Flipkart. I want to contribute in Kafka project, can you please add my username as contributor in Kafka project. Username: nitin1891 Thanks, Nitin

Re: Cleaning up command line tools argument parsing a little

2019-04-17 Thread Guozhang Wang
I took another look at the PR itself and I think it would be great to have this cleanup too -- I cannot remember at the beginning why we gradually moved to different mechanism (argparse4j) for different cmds, if there's no rationales behind it we should just make them consistent. Thanks for

[VOTE] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-17 Thread Maarten Duijn
Hello all, There has been informal agreement so I would like to call for a vote on KIP-446: Add changelog topic configuration to KTable suppress. This will allow users to configure internal topics created by the suppress operator via the streams DSL. KIP:

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread Randall Hauch
Overall this looks good. A few specific requests to hopefully improve the clarity of the proposal: 1) The motivation section should more clearly state that this feature will allow it to be reused in multiple components, Connect will use this feature to resolve variables in the worker

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Richard Yu
Hi Micheal, Yeah, those are some points I should've clarified. No problem. Have got it done. On Wed, Apr 17, 2019 at 6:42 AM Michael Noll wrote: > Richard, > > thanks for looking into this! > > However, I have some concerns. The KIP you created ( > >

[VOTE] KIP-457: Add DISCONNECTED status to Kafka Streams

2019-04-17 Thread Richard Yu
Hi all, I would like to propose a minor change to the current KafkaStreams#state() method. Considering the small size of this proposal, I thought it would be good if we could pass it quickly. (It does not have large scale ramifications) Here is the KIP link:

Re: [VOTE] KIP-446: Add changelog topic configuration to KTable suppress

2019-04-17 Thread Bruno Cadonna
Hi Maarten Duijn, Thank you for driving this. +1 (non-binding) Best, Bruno On Wed, Apr 17, 2019 at 8:21 AM Maarten Duijn wrote: > Hello all, > > There has been informal agreement so I would like to call for a vote on > KIP-446: Add changelog topic configuration to KTable suppress. This will

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Thanks for the feedback Randall. I have incorporated the below changes in the KIP. Thanks, Tejal On 2019/04/17 15:42:31, Randall Hauch wrote: > Overall this looks good. A few specific requests to hopefully improve the > clarity of the proposal: > > 1) The motivation section should more