Re: [VOTE] KIP-805: Add range and scan query support in IQ v2

2021-12-13 Thread Luke Chen
Hi Vicky, I checked the KIP again, and found there's something you might need to have some description. The term: *scan query*, is my first time seeing this term. I think it's not a publicly known term (or it's just me?), and might need some description for it. And for the "range query", I think

Re: [VOTE] KIP-806: Add session and window query over KV-store in IQv2

2021-12-13 Thread Luke Chen
Hi Patrick, Thanks for the KIP! I have some comments, in addition to Guozhang's comments: 4. The parameter names `windowLower` and `windowUpper` are kind of ambiguous to me. Could we come up a better name for it, like `windowStartTime`, `windowEndTime`, or even we don't need the "window" name,

Re: [VOTE] KIP-784: Add top-level error code field to DescribeLogDirsResponse

2021-12-13 Thread Mickael Maison
Bumping this thread another time. This is a very minor change to make DescribeLogDirsResponse consistent with the other APIs. Let me know if you have any feedback. Thanks, Mickael On Mon, Nov 22, 2021 at 10:29 AM Tom Bentley wrote: > > Hi Mickael, > > It's pretty low value, but I think

[VOTE] KIP-769: Connect APIs to list all connector plugins and retrieve their configuration definitions

2021-12-13 Thread Mickael Maison
Hi all, I'd like to start a vote on KIP-769 which proposes adding new endpoints to the Connect REST API to list all connectors plugins and retrieve their configurations.

[jira] [Created] (KAFKA-13540) UniformStickyPartitioner leads to uneven Kafka partitions

2021-12-13 Thread nk2242696 (Jira)
nk2242696 created KAFKA-13540: - Summary: UniformStickyPartitioner leads to uneven Kafka partitions Key: KAFKA-13540 URL: https://issues.apache.org/jira/browse/KAFKA-13540 Project: Kafka Issue

[jira] [Created] (KAFKA-13541) Make IQv2 query/store interface type safe

2021-12-13 Thread Patrick Stuedi (Jira)
Patrick Stuedi created KAFKA-13541: -- Summary: Make IQv2 query/store interface type safe Key: KAFKA-13541 URL: https://issues.apache.org/jira/browse/KAFKA-13541 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-13539) Improve propagation and processing of SSL handshake failures

2021-12-13 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-13539: -- Summary: Improve propagation and processing of SSL handshake failures Key: KAFKA-13539 URL: https://issues.apache.org/jira/browse/KAFKA-13539 Project: Kafka

Re: [VOTE] KIP-805: Add range and scan query support in IQ v2

2021-12-13 Thread Vasiliki Papavasileiou
Hello everyone, Thank you for your comments. I applied the changes. Hope things are clearer now. Best, Vicky On Mon, Dec 13, 2021 at 8:24 AM Luke Chen wrote: > Hi Vicky, > > I checked the KIP again, and found there's something you might need to have > some description. > The term: *scan

Re: [VOTE] KIP-769: Connect APIs to list all connector plugins and retrieve their configuration definitions

2021-12-13 Thread Chris Egerton
Thanks Mickael, this looks great. +1 non-binding. Cheers, Chris On Mon, Dec 13, 2021 at 5:18 AM Mickael Maison wrote: > Hi all, > > I'd like to start a vote on KIP-769 which proposes adding new > endpoints to the Connect REST API to list all connectors plugins and > retrieve their

Re: [DISCUSS] Please review the 3.1.0 blog post

2021-12-13 Thread Mickael Maison
Hi David, It looks good, I just noticed a typo: "KIP-733" should be "KIP-773" Thanks On Sun, Dec 12, 2021 at 4:05 PM David Jacot wrote: > > Hi Luke, > > Thanks for your feedback. I have found and have fixed the issue. It was > actually > due to the formatting of the title of the AK 3.0 blog

Re: [VOTE] KIP-805: Add range and scan query support in IQ v2

2021-12-13 Thread Vasiliki Papavasileiou
Hello everyone, Thank you for the discussion and for voting. The vote on KIP-805 passes with: 3 binding +1 (John, Matthias, and Guozhang), 1 non-binding +1 (Luke), no vetoes. The vote is now closed. If anyone has objections later on, please don't hesitate to let me know. I will proceed with

Re: [DISCUSS] KIP-795: Add public APIs for AbstractCoordinator

2021-12-13 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
Hi kafka-devs, I would like a second review to the proposed changes on KIP-795: Add public APIs for AbstractCoordinator [ https://cwiki.apache.org/confluence/display/KAFKA/KIP-795%3A+Add+public+APIs+for +AbstractCoordinator ] I've amended the KIP addressing Tom's feedback, and also opened a

Re: [DISCUSS] KIP-782: Expandable batch size in producer

2021-12-13 Thread Jun Rao
Hi, Lucas, Thanks for the reply. It would be useful to summarize the benefits of a separate batch.max.size. To me, it's not clear why a user would want two different batch sizes. In your example, I can understand why a user would want to form a batch with a 5ms linger. But why would a user prefer

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-12-13 Thread Kirk True
Hi Jun, On Thu, Dec 9, 2021, at 2:28 PM, Jun Rao wrote: > 13. Using OpenTelemetry. Does that require runtime dependency > on OpenTelemetry library? How good is the compatibility story > of OpenTelemetry? This is important since an application could have other > OpenTelemetry dependencies than the

[VOTE] KIP-801: Implement an Authorizer that stores metadata in __cluster_metadata

2021-12-13 Thread Colin McCabe
Hi all, I'd like to start the vote on KIP-801: Implement an Authorizer that stores metadata in __cluster_metadata The KIP is here: https://cwiki.apache.org/confluence/x/h5KqCw The original DISCUSS thread is here: https://lists.apache.org/thread/3d5o7h17ztjztjhblx4fln0wbbs1rmdq Please take a

[jira] [Created] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13542: -- Summary: Utilize the new Consumer#enforceRebalance(reason) API in Streams Key: KAFKA-13542 URL: https://issues.apache.org/jira/browse/KAFKA-13542

Re: [VOTE] KIP-806: Add session and window query over KV-store in IQv2

2021-12-13 Thread Guozhang Wang
Hi John, Please see my follow-up comments inlined below. On Mon, Dec 13, 2021 at 2:26 PM John Roesler wrote: > Hi Patrick, thanks for the KIP! > > I hope you, Guozhang, and Luke don't mind if I share some > thoughts: > > 1. I think you just meant to remove that private constructor > from the

Re: [DISCUSS] KIP-801: Implement an Authorizer that stores metadata in __cluster_metadata

2021-12-13 Thread Colin McCabe
Hi José, I think these are good questions. We have a few situations like this where there is something brokers have to know before they can contact the controller quorum -- or something controllers have to know before they can accept broker connections. Basically, the bootstrapping problem.

[jira] [Created] (KAFKA-13543) Consumer may pass stale cluster metadata to the assignor following a subscription update

2021-12-13 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13543: -- Summary: Consumer may pass stale cluster metadata to the assignor following a subscription update Key: KAFKA-13543 URL:

Re: [DISCUSS] KIP-785 Automatic storage formatting

2021-12-13 Thread Colin McCabe
Hi Igor, Disk failures have always required manual intervention in Kafka. For example, if you are using a RAID array and a disk goes bad, you will need to remove the disk, insert a new one, and start the RAID rebuild process. Kafka can't help with this process since we don't operate at this

Re: [VOTE] KIP-806: Add session and window query over KV-store in IQv2

2021-12-13 Thread John Roesler
Hi Patrick, thanks for the KIP! I hope you, Guozhang, and Luke don't mind if I share some thoughts: 1. I think you just meant to remove that private constructor from the KIP, right? 2. I think WindowRangeQuery#withWindowRage(windowLower, windowUpper) is the version that yields an iterator over

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-12-13 Thread Ryanne Dolan
I think we should be very careful about introducing new runtime dependencies into the clients. Historically this has been rare and essentially necessary (e.g. compression libs). Ryanne On Mon, Dec 13, 2021, 1:06 PM Kirk True wrote: > Hi Jun, > > On Thu, Dec 9, 2021, at 2:28 PM, Jun Rao wrote:

Re: [VOTE] KIP-769: Connect APIs to list all connector plugins and retrieve their configuration definitions

2021-12-13 Thread Ryanne Dolan
+1 (non-binding) Ryanne On Mon, Dec 13, 2021, 4:18 AM Mickael Maison wrote: > Hi all, > > I'd like to start a vote on KIP-769 which proposes adding new > endpoints to the Connect REST API to list all connectors plugins and > retrieve their configurations. > >

Re: [DISCUSS] Apache Kafka 3.1.0 release

2021-12-13 Thread Jason Gustafson
Hi David, I think we should get https://issues.apache.org/jira/browse/KAFKA-13488. This is a follow-up to https://issues.apache.org/jira/browse/KAFKA-12257, which was previously considered a 3.0 blocker. Without the additional patch, the bug causing the consumer to get stuck can still occur in a

[jira] [Resolved] (KAFKA-13540) UniformStickyPartitioner leads to uneven Kafka partitions

2021-12-13 Thread Artem Livshits (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Livshits resolved KAFKA-13540. Resolution: Duplicate See also