[jira] [Resolved] (KAFKA-16137) ListClientMetricsResourcesResponse definition is missing field descriptions

2024-01-22 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-16137. - Fix Version/s: 3.8.0 Resolution: Fixed merged the PR to trunk. >

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2594

2024-01-22 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-890 Server Side Defense

2024-01-22 Thread Jun Rao
Hi, Justine, Thanks for the reply. 101.3 I realized that I actually have two questions. (1) In the non-overflow case, we need to write the previous produce Id tagged field in the end maker so that we know if the marker is from the new client. Since the end maker is derived from the prepare

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-01-22 Thread Chris Egerton
Hi Berci, Thanks for the KIP! IMO we don't need the "default." prefix for the new property, and it deviates a bit from the precedent set by properties like "replication.policy.internal.topic.separator.enabled". I think we can just call it "replication.policy.heartbeats.topic", or if we really

Re: [DISCUSS] KIP-890 Server Side Defense

2024-01-22 Thread Justine Olshan
101.3 I realized that I actually have two questions. > (1) In the non-overflow case, we need to write the previous produce Id tagged field in the end maker so that we know if the marker is from the new client. Since the end maker is derived from the prepare marker, should we write the previous

Re: [DISCUSS] KIP-890 Server Side Defense

2024-01-22 Thread Justine Olshan
Thanks Jun, I will update the KIP with the prev field for prepare as well. PREPARE producerId: x previous/lastProducerId (tagged field): x nextProducerId (tagged field): empty or z if y will overflow producerEpoch: y + 1 COMPLETE producerId: x or z if y overflowed previous/lastProducerId

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

2024-01-22 Thread José Armando García Sancio
Thanks for your feedback Jason and excuse the delayed response. See comments below. On Tue, Jan 9, 2024 at 5:08 PM Jason Gustafson wrote: > > Hi Jose, > > Thanks for the KIP! A few initial questions below: > > 1. In the user experience section, the user is expected to provide supply > the UUID

Re: [DISCUSS] KIP-890 Server Side Defense

2024-01-22 Thread Artem Livshits
> Hmm -- we would fence the producer if the epoch is bumped and we get a lower epoch. Yes -- we are intentionally adding this to prevent fencing. I think Jun's point is that we can defer the fencing decision until transition into complete state (which I believe is what the current logic is

[jira] [Resolved] (KAFKA-16166) Generify RetryWithToleranceOperator and ErrorReporter

2024-01-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-16166. - Fix Version/s: 3.8.0 Resolution: Fixed > Generify RetryWithToleranceOperator and

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-22 Thread ziming deng
Hello David, Thanks for reminding this, as Chirs explained, the tools I’m trying to update only support set/delete configs, and I’m just make a way for append/subtract configs in the future, so this would not be affected by KAFKA-10140, and it would be a little overkill to support

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

2024-01-22 Thread José Armando García Sancio
Thanks Jason. Comments below. On Wed, Jan 10, 2024 at 9:06 AM Jason Gustafson wrote: > One additional thought. It would be helpful to have an example to justify > the need for this: > > > Wait for the fetch offset of the replica (ID, UUID) to catch up to the > log end offset of the leader. > >

Re: [DISCUSS] KIP-890 Server Side Defense

2024-01-22 Thread Jun Rao
Hi, Justine, 101.3 Thanks for the explanation. (1) My point was that the coordinator could fail right after writing the prepare marker. When the new txn coordinator generates the complete marker after the failover, it needs some field from the prepare marker to determine whether it's written by

Re: [DISCUSS] KIP-853: KRaft Controller Membership Changes

2024-01-22 Thread José Armando García Sancio
Thanks for the feedback Colin. Comments below. On Tue, Jan 9, 2024 at 4:58 PM Colin McCabe wrote: > 1. restarting a controller with an empty storage directory > > The controller can contact the quorum to get the cluster ID and current MV. > If the MV doesn't support quorum reconfiguration, it

[jira] [Resolved] (KAFKA-16144) Controller leader checkQuorum timer should skip only 1 controller case

2024-01-22 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16144. --- Resolution: Fixed > Controller leader checkQuorum timer should skip only 1 controller case >

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-22 Thread Andrew Schofield
+1 (non-binding) Thanks, Andrew > On 22 Jan 2024, at 07:29, Federico Valeri wrote: > > +1 (non binding) > > Thanks. > > On Mon, Jan 22, 2024 at 7:03 AM Luke Chen wrote: >> >> Hi Ziming, >> >> +1(binding) from me. >> >> Thanks. >> Luke >> >> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash

[jira] [Created] (KAFKA-16183) Flaky test - testMetricsDuringTopicCreateDelete(String).quorum=zk – kafka.integration.MetricsDuringTopicCreationDeletionTest

2024-01-22 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-16183: Summary: Flaky test - testMetricsDuringTopicCreateDelete(String).quorum=zk – kafka.integration.MetricsDuringTopicCreationDeletionTest Key: KAFKA-16183 URL:

[jira] [Created] (KAFKA-16182) Flaky test - testClientInstanceId() - org.apache.kafka.clients.admin.KafkaAdminClientTest

2024-01-22 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-16182: Summary: Flaky test - testClientInstanceId() - org.apache.kafka.clients.admin.KafkaAdminClientTest Key: KAFKA-16182 URL: https://issues.apache.org/jira/browse/KAFKA-16182

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-22 Thread David Jacot
Hi Ziming, Thanks for driving this. I wanted to bring KAFKA-10140 to your attention. It looks like the incremental API does not work for configuring plugins. I think that we need to cover this in the KIP. Best, David On Mon, Jan 22, 2024 at

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2596

2024-01-22 Thread Apache Jenkins Server
See Changes: -- [...truncated 457952 lines...] Gradle Test Run :core:test > Gradle Test Executor 97 > ZkMigrationClientTest > testEmptyWrite() STARTED Gradle Test Run

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-22 Thread David Jacot
Hi Chris, Ziming, Thanks for the clarification. I am glad that it does not impact the tool. It may be worth adding a note about it in the KIP to avoid the same question in the future. Otherwise, I am +1 (binding). Thanks for driving this! Best, David On Tue, Jan 23, 2024 at 6:07 AM ziming deng

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.7 #72

2024-01-22 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-16147) Partition is assigned to two members at the same time

2024-01-22 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16147. - Fix Version/s: 3.8.0 Resolution: Fixed > Partition is assigned to two members at the

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2593

2024-01-22 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-22 Thread Chris Egerton
Hi David, I've only briefly skimmed KAFKA-10140 but it seems that it may only apply to append/subtract operations on list-type properties. If my understanding is correct then this shouldn't be a problem for the KIP since we only use the set/delete operations in the kafka-configs.sh script. If the

[jira] [Created] (KAFKA-16184) Flaky test - testAlterReplicaLogDirs(String).quorum=kraft – kafka.api.PlaintextAdminIntegrationTest

2024-01-22 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-16184: Summary: Flaky test - testAlterReplicaLogDirs(String).quorum=kraft – kafka.api.PlaintextAdminIntegrationTest Key: KAFKA-16184 URL:

[jira] [Created] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-01-22 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16185: -- Summary: Fix client reconciliation of same assignment received in different epochs Key: KAFKA-16185 URL: https://issues.apache.org/jira/browse/KAFKA-16185