[jira] [Created] (KAFKA-999) Controlled shutdown never succeeds until the broker is killed

2013-08-04 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-999: --- Summary: Controlled shutdown never succeeds until the broker is killed Key: KAFKA-999 URL: https://issues.apache.org/jira/browse/KAFKA-999 Project: Kafka

[jira] [Commented] (KAFKA-992) Double Check on Broker Registration to Avoid False NodeExist Exception

2013-08-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728905#comment-13728905 ] Neha Narkhede commented on KAFKA-992: - Thanks for patch v3. Few more review comments -

[jira] [Commented] (KAFKA-615) Avoid fsync on log segment roll

2013-08-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728922#comment-13728922 ] Neha Narkhede commented on KAFKA-615: - Thanks for all the patches. Overall, it's a good

[jira] [Updated] (KAFKA-615) Avoid fsync on log segment roll

2013-08-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-615: Attachment: KAFKA-615-v6.patch Updated patch: - Removed bad scaladoc - Improved log corruption test to

[jira] [Updated] (KAFKA-718) kafka-run-class.sh should use reasonable gc settings

2013-08-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-718: Attachment: KAFKA-718-v5.patch Patch v5: move all logs to a logs/ directory to avoid polluting the main

[jira] [Commented] (KAFKA-615) Avoid fsync on log segment roll

2013-08-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729010#comment-13729010 ] Jun Rao commented on KAFKA-615: --- Thanks for patch v5. Some comments: 50. Log: 50.1

[jira] [Commented] (KAFKA-718) kafka-run-class.sh should use reasonable gc settings

2013-08-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729014#comment-13729014 ] Jun Rao commented on KAFKA-718: --- Thanks for patch v4. Got the following exception running

Re: Two patches needing review

2013-08-04 Thread Jun Rao
Sorry for the delay. Reviewed both. Jun On Sat, Aug 3, 2013 at 10:52 AM, Jay Kreps jay.kr...@gmail.com wrote: This is a set of good housekeeping things for 0.8 open source release: https://issues.apache.org/jira/browse/KAFKA-718 This is just a small set of trivial cleanups that are very

[jira] [Commented] (KAFKA-718) kafka-run-class.sh should use reasonable gc settings

2013-08-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729076#comment-13729076 ] Jay Kreps commented on KAFKA-718: - Sorry, I had missed that file in v4. I had fixed it in

[jira] [Commented] (KAFKA-615) Avoid fsync on log segment roll

2013-08-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729087#comment-13729087 ] Jay Kreps commented on KAFKA-615: - Ah thanks for the detailed review: 50.2 Yes, nice. 50.3