Re: Review Request 14399: OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14399/#review26469 --- Ship it! Ship It! - Guozhang Wang On Sept. 29, 2013, 11:25 p.m.,

[jira] [Updated] (KAFKA-1068) OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1068: --- Status: Patch Available (was: Open) > OfflinePartitionCount metrics may be incorrect after the controller fa

[jira] [Commented] (KAFKA-1068) OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781530#comment-13781530 ] Jun Rao commented on KAFKA-1068: Created reviewboard https://reviews.apache.org/r/14399/

[jira] [Updated] (KAFKA-1068) OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1068: --- Attachment: KAFKA-1068.patch > OfflinePartitionCount metrics may be incorrect after the controller failover >

Review Request 14399: OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-29 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14399/ --- Review request for kafka. Bugs: KAFKA-1068 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1068) OfflinePartitionCount metrics may be incorrect after the controller failover

2013-09-29 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1068: -- Summary: OfflinePartitionCount metrics may be incorrect after the controller failover Key: KAFKA-1068 URL: https://issues.apache.org/jira/browse/KAFKA-1068 Project: Kafka

Re: Random Partitioning Issue

2013-09-29 Thread Jun Rao
The main issue is that if we do that, when key is null, we can only select a random partition, but not a random and available partition, without changing the partitioner api. Being able to do the latter is important in my opinion. For example, a user may choose the replication factor of a topic to