[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-04-23 Thread Artur Denysenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979318#comment-13979318 ] Artur Denysenko commented on KAFKA-824: --- The root of the problem is here: https://gi

[jira] [Comment Edited] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-04-23 Thread Artur Denysenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979318#comment-13979318 ] Artur Denysenko edited comment on KAFKA-824 at 4/24/14 5:44 AM: -

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-04-23 Thread Artur Denysenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979305#comment-13979305 ] Artur Denysenko commented on KAFKA-824: --- I think it's a case then "_connection" is nu

[jira] [Commented] (KAFKA-1417) Very slow initial high-level consumer startup in low traffic/blocking fetch scenario

2014-04-23 Thread Sam Meder (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979267#comment-13979267 ] Sam Meder commented on KAFKA-1417: -- I think the timeout is somewhat arbitrary, but since

Build failed in Jenkins: Kafka-trunk #172

2014-04-23 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1389; transient unit test failure in ProducerFailureHandlingTest; patched by Jun Rao; reviewed by Guozhang Wang and Neha Narkhede -- [...truncated 1514 lines...]

[jira] [Commented] (KAFKA-1417) Very slow initial high-level consumer startup in low traffic/blocking fetch scenario

2014-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979260#comment-13979260 ] Jun Rao commented on KAFKA-1417: Interesting. The problem is that the leaderFinderThread u

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979255#comment-13979255 ] Jun Rao commented on KAFKA-824: --- Do you see ZK session expiration around that time? > java.l

[jira] [Updated] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-04-23 Thread Artur Denysenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artur Denysenko updated KAFKA-824: -- Attachment: ZkClient.0.4.txt ZkClient.0.3.txt It fails for both zkclient 0.3 and

[jira] [Commented] (KAFKA-1417) Very slow initial high-level consumer startup in low traffic/blocking fetch scenario

2014-04-23 Thread Sam Meder (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979211#comment-13979211 ] Sam Meder commented on KAFKA-1417: -- The simple, although not the most efficient solution

[jira] [Created] (KAFKA-1417) Very slow initial high-level consumer startup in low traffic/blocking fetch scenario

2014-04-23 Thread Sam Meder (JIRA)
Sam Meder created KAFKA-1417: Summary: Very slow initial high-level consumer startup in low traffic/blocking fetch scenario Key: KAFKA-1417 URL: https://issues.apache.org/jira/browse/KAFKA-1417 Project: K

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round two

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/#review41250 --- core/src/main/scala/kafka/log/Log.scala

[jira] [Resolved] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1389. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the review. Committed to trunk. > transient unit

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
> On April 23, 2014, 9:56 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 313 > > > > > > Also line 292, 249, 207, 179, 150, 133, 123 Since these tests don't produce messages,

Re: Review Request 20380: Fix KAFKA-1395: incorporate Neha's comment, ensure createProducer use ack = -1 and type = async, with configurable serializer and partitioner

2014-04-23 Thread Guozhang Wang
> On April 22, 2014, 10 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala, lines > > 114-116 > > > > > > For this particular test, resending in the producer could introduce

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41241 --- Ship it! Ship It! - Neha Narkhede On April 23, 2014, 9:36 p.m.,

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979044#comment-13979044 ] Guozhang Wang commented on KAFKA-824: - Currently we are only using zkclient 0.3. Could

[jira] [Commented] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979005#comment-13979005 ] Guozhang Wang commented on KAFKA-1409: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1409: - Attachment: KAFKA-1409_2014-04-23_15:20:43.patch > oversized messages can slow down the brokers >

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round two

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/ --- (Updated April 23, 2014, 10:20 p.m.) Review request for kafka. Summary (updat

[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1416: - Description: Multiple unit tests have its own internal function to send/get messages from the br

[jira] [Created] (KAFKA-1416) Unify sendMessages/getMessages in unit tests

2014-04-23 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1416: Summary: Unify sendMessages/getMessages in unit tests Key: KAFKA-1416 URL: https://issues.apache.org/jira/browse/KAFKA-1416 Project: Kafka Issue Type: Bug

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/#review41217 --- core/src/main/scala/kafka/log/FileMessageSet.scala

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41220 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

[jira] [Commented] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978943#comment-13978943 ] Jun Rao commented on KAFKA-1389: Updated reviewboard https://reviews.apache.org/r/20290/

[jira] [Updated] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1389: --- Attachment: KAFKA-1389_2014-04-23_14:36:00.patch > transient unit test failure in ProducerFailureHandlingTest

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/ --- (Updated April 23, 2014, 9:36 p.m.) Review request for kafka. Bugs: KAFKA-138

[jira] [Updated] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1409: - Attachment: KAFKA-1409_2014-04-23_14:25:48.patch > oversized messages can slow down the brokers >

[jira] [Commented] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978929#comment-13978929 ] Guozhang Wang commented on KAFKA-1409: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/ --- (Updated April 23, 2014, 9:26 p.m.) Review request for kafka. Bugs: KAFKA-140

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41216 --- Ship it! Ship It! - Guozhang Wang On April 23, 2014, 5:41 p.m.,

[jira] [Updated] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1409: - Attachment: KAFKA-1409_2014-04-23_14:10:03.patch > oversized messages can slow down the brokers >

[jira] [Commented] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978908#comment-13978908 ] Guozhang Wang commented on KAFKA-1409: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/ --- (Updated April 23, 2014, 9:10 p.m.) Review request for kafka. Summary (update

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/#review41213 --- Ship it! Ship It! - Neha Narkhede On April 23, 2014, 5:41 p.m.,

Re: Review Request 20616: Fix KAFKA-1409

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/#review41182 --- core/src/main/scala/kafka/cluster/Partition.scala

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-04-23 Thread Artur Denysenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978785#comment-13978785 ] Artur Denysenko commented on KAFKA-824: --- I have it as well. No special test case - bu

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
> On April 14, 2014, 5:43 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 151 > > > > > > Actually, do we need waitUntilMetadataIsPropogated here? Shall we just > > remove lin

[jira] [Commented] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978520#comment-13978520 ] Jun Rao commented on KAFKA-1389: Updated reviewboard https://reviews.apache.org/r/20290/

[jira] [Updated] (KAFKA-1389) transient unit test failure in ProducerFailureHandlingTest

2014-04-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1389: --- Attachment: KAFKA-1389_2014-04-23_10:41:08.patch > transient unit test failure in ProducerFailureHandlingTest

Re: Review Request 20290: Patch for KAFKA-1389

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20290/ --- (Updated April 23, 2014, 5:41 p.m.) Review request for kafka. Bugs: KAFKA-138

[jira] [Updated] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1409: - Attachment: KAFKA-1409.patch > oversized messages can slow down the brokers > ---

[jira] [Commented] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978502#comment-13978502 ] Guozhang Wang commented on KAFKA-1409: -- Created reviewboard https://reviews.apache.or

Review Request 20616: Fix KAFKA-1409

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/ --- Review request for kafka. Bugs: KAFKA-1409 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1415) Async producer.send can block forever if async.ProducerSendThread dies

2014-04-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978463#comment-13978463 ] Guozhang Wang commented on KAFKA-1415: -- This would only happen with async mode, in wh

[jira] [Created] (KAFKA-1415) Async producer.send can block forever if async.ProducerSendThread dies

2014-04-23 Thread James Blackburn (JIRA)
James Blackburn created KAFKA-1415: -- Summary: Async producer.send can block forever if async.ProducerSendThread dies Key: KAFKA-1415 URL: https://issues.apache.org/jira/browse/KAFKA-1415 Project: Kaf

Re: a problem about kafka source code‏

2014-04-23 Thread Jun Rao
It seems to call unlock in the finally clause. Thanks, Jun On Wed, Apr 23, 2014 at 6:12 AM, 冯傲风 wrote: > HiI am reading the kafka source code now. I have a problem about the > "BufferPool" class int the file > "org.apache.kafka.clients.producer.internals.BufferPool.java"the source > code is l

a problem about kafka source code‏

2014-04-23 Thread 冯傲风
HiI am reading the kafka source code now. I have a problem about the "BufferPool" class int the file "org.apache.kafka.clients.producer.internals.BufferPool.java"the source code is like this: this.lock.lock();try {// check if we have a free buffer of the right size pooled

[jira] [Created] (KAFKA-1414) Speedup broker startup after hard reset

2014-04-23 Thread Dmitry Bugaychenko (JIRA)
Dmitry Bugaychenko created KAFKA-1414: - Summary: Speedup broker startup after hard reset Key: KAFKA-1414 URL: https://issues.apache.org/jira/browse/KAFKA-1414 Project: Kafka Issue Type: I

Build failed in Jenkins: Kafka-trunk #171

2014-04-23 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1410; MetadataCache cleanup; patched by Jun Rao; reviewed by Timothy Chen, Joel Koshy [junrao] kafka-1359; Followup on K1359: change nanoTime to currentTimeMillis in metrics; patched by Guozhang Wang; reviewed