decoding of responses with error_codes

2014-05-12 Thread svante karlsson
I'm writing (yet another) C++ binding for kafka and I'm curious on the encoding in relation to error-code != 0 There seems to be a discrepancy as to how to decode messages in presence of errors. ConsumerMetadataResponse error_code !=0 - no more data should be decoded. in all others we continue

Re: Review Request 21174: Fix KAFKA-1396

2014-05-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21174/ --- (Updated May 7, 2014, 9:55 p.m.) Review request for kafka. Bugs: KAFKA-1396

[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven

2014-05-12 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994880#comment-13994880 ] Mikael Högqvist commented on KAFKA-1308: +1 TestUtils are very useful for us as

Re: decoding of responses with error_codes

2014-05-12 Thread Guozhang Wang
Hi Svante, This is indeed an issue with the protocol definition of ConsumerMetadataResponse. Do you think this issue is fixed in the following JIRA? https://issues.apache.org/jira/browse/KAFKA-1437 Guozhang On Mon, May 12, 2014 at 1:10 AM, svante karlsson s...@csi.se wrote: I'm writing (yet

Re: decoding of responses with error_codes

2014-05-12 Thread svante karlsson
Thanks for the clarification. -if (errorCode == ErrorMapping.NoError) { - coordinator.get.writeTo(buffer) The removal of the if statement would fix the issue but the patch changes other things that I can't say much about as I don't know scala. /svante 2014-05-12 17:25 GMT+02:00

[jira] [Updated] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-05-12 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1443: Attachment: KAFKA-1443.patch Add delete topic to topic commands and update DeleteTopicCommand

Re: Review Request 21244: Patch for KAFKA-1442

2014-05-12 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21244/ --- (Updated May 8, 2014, 11:01 p.m.) Review request for kafka. Bugs: KAFKA-1442

Re: Review Request 21174: Fix KAFKA-1396

2014-05-12 Thread Guozhang Wang
On May 8, 2014, 8:24 p.m., Jun Rao wrote: core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, lines 296-297 https://reviews.apache.org/r/21174/diff/2/?file=576364#file576364line296 Should we check that after shutting down the producer scheduler? This

Re: Review Request 21304: Fix KAFKA-1445

2014-05-12 Thread Guozhang Wang
On May 12, 2014, 7:35 p.m., Jay Kreps wrote: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, line 201 https://reviews.apache.org/r/21304/diff/1/?file=578178#file578178line201 It seems like this only works some of the time. Let's say you

Re: Review Request 21304: Fix KAFKA-1445

2014-05-12 Thread Guozhang Wang
On May 12, 2014, 7:35 p.m., Jay Kreps wrote: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, line 54 https://reviews.apache.org/r/21304/diff/1/?file=578178#file578178line54 Does this need to be volatile? Do we actually need it? It is a

Re: Review Request 21304: Fix KAFKA-1445

2014-05-12 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21304/#review42734 ---

Re: Review Request 19731: Patch for KAFKA-1328

2014-05-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review42787 ---

Re: Review Request 19731: Patch for KAFKA-1328

2014-05-12 Thread Jun Rao
On May 7, 2014, 4:50 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java, lines 87-88 https://reviews.apache.org/r/19731/diff/9/?file=574802#file574802line87 The Future thing doesn't work well in this case. This is because the caller

[jira] [Created] (KAFKA-1447) Controlled shutdown deadlock when trying to send state updates

2014-05-12 Thread Sam Meder (JIRA)
Sam Meder created KAFKA-1447: Summary: Controlled shutdown deadlock when trying to send state updates Key: KAFKA-1447 URL: https://issues.apache.org/jira/browse/KAFKA-1447 Project: Kafka Issue

[jira] [Commented] (KAFKA-1442) RBTools post-review is deprecated

2014-05-12 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993235#comment-13993235 ] Neha Narkhede commented on KAFKA-1442: -- Created reviewboard