Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Build failed in Jenkins: Kafka-trunk #250

See Changes: [jjkoshy] KAFKA-1580; Reject producer requests to internal topics; reviewed by Joel Koshy and Neha Narkhede -- [...truncated 450 lines...] org.apache.kafka.common.record.RecordTest > te

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099423#comment-14099423 ] Jun Rao commented on KAFKA-1510: Yes, I agree that always do unfiltered commits when offse

[jira] [Updated] (KAFKA-1599) Change preferred replica election admin command to handle large clusters

[ https://issues.apache.org/jira/browse/KAFKA-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1599: - Labels: newbie++ (was: ) > Change preferred replica election admin command to handle large clust

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099340#comment-14099340 ] Jun Rao commented on KAFKA-1485: Gwen, Thanks for the patch. System tests work now. I hav

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099316#comment-14099316 ] Jun Rao commented on KAFKA-687: --- Yes, that sounds reasonable. We can try to minimize the chan

[jira] [Updated] (KAFKA-1580) Reject producer requests to internal topics

[ https://issues.apache.org/jira/browse/KAFKA-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1580: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk. > Reject produc

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099304#comment-14099304 ] Joel Koshy commented on KAFKA-687: -- [~junrao] I was thinking over this a little more and I

Re: Review Request 24620: Patch for KAFKA-1580

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50786 --- Ship it! Ship It! - Joel Koshy On Aug. 15, 2014, 10:05 p.m., Jon

[jira] [Updated] (KAFKA-1580) Reject producer requests to internal topics

[ https://issues.apache.org/jira/browse/KAFKA-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Natkins updated KAFKA-1580: Attachment: KAFKA-1580_2014-08-15_15:05:29.patch > Reject producer requests to internal top

[jira] [Commented] (KAFKA-1580) Reject producer requests to internal topics

[ https://issues.apache.org/jira/browse/KAFKA-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099244#comment-14099244 ] Jonathan Natkins commented on KAFKA-1580: - Updated reviewboard https://reviews.apa

Re: Review Request 24620: Patch for KAFKA-1580

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/ --- (Updated Aug. 15, 2014, 10:05 p.m.) Review request for kafka. Bugs: KAFKA-158

Build failed in Jenkins: Kafka-trunk #249

See Changes: [jjkoshy] KAFKA-1582; System Test should wait for producer to finish; reviewed by Joel Koshy and Guozhang Wang -- [...truncated 482 lines...] org.apache.kafka.common.record.RecordTest >

Re: Review Request 24620: Patch for KAFKA-1580

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50784 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

[jira] [Updated] (KAFKA-1525) DumpLogSegments should print transaction IDs

[ https://issues.apache.org/jira/browse/KAFKA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1525: Attachment: KAFKA-1525_2014-08-15_11:49:25.patch > DumpLogSegments should print transaction IDs > -

[jira] [Commented] (KAFKA-1525) DumpLogSegments should print transaction IDs

[ https://issues.apache.org/jira/browse/KAFKA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098921#comment-14098921 ] Dong Lin commented on KAFKA-1525: - Updated reviewboard https://reviews.apache.org/r/23569/

Re: Review Request 23569: Patch for KAFKA-1525

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23569/ --- (Updated Aug. 15, 2014, 6:49 p.m.) Review request for kafka. Bugs: KAFKA-1525

Re: Review Request 23567: Patch for KAFKA-1522

> On Aug. 14, 2014, 11:15 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TransactionRequest.scala, line 47 > > > > > > It would help to have comments here describing each type's role. Please check the update

[jira] [Commented] (KAFKA-1522) Transactional messaging request/response definitions

[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098903#comment-14098903 ] Dong Lin commented on KAFKA-1522: - Updated reviewboard https://reviews.apache.org/r/23567/

[jira] [Updated] (KAFKA-1522) Transactional messaging request/response definitions

[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1522: Attachment: KAFKA-1522_2014-08-15_11:37:42.patch > Transactional messaging request/response definitions > -

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 15, 2014, 6:37 p.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 263 > > > > > > As summarized in the ticket description we should have per-topic > > overrides as well. If the topic'

[jira] [Created] (KAFKA-1599) Change preferred replica election admin command to handle large clusters

Todd Palino created KAFKA-1599: -- Summary: Change preferred replica election admin command to handle large clusters Key: KAFKA-1599 URL: https://issues.apache.org/jira/browse/KAFKA-1599 Project: Kafka

[jira] [Resolved] (KAFKA-1582) System Test should wait for producer to finish

[ https://issues.apache.org/jira/browse/KAFKA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1582. --- Resolution: Fixed Committed to trunk > System Test should wait for producer to finish >

Re: Review Request 24510: Patch for KAFKA-1582

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/#review50745 --- Ship it! Ship It! - Joel Koshy On Aug. 11, 2014, 4:23 a.m., Dong

[jira] [Commented] (KAFKA-1231) Support partition shrink (delete partition)

[ https://issues.apache.org/jira/browse/KAFKA-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098792#comment-14098792 ] Clark Haskins commented on KAFKA-1231: -- It would also be useful have the ability to l

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1499: --- Status: Patch Available (was: Open) > Broker-side compression configuration > --

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098357#comment-14098357 ] Manikumar Reddy commented on KAFKA-1499: Updated reviewboard https://reviews.apach

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 263 > > > > > > As summarized in the ticket description we should have per-topic > > overrides as well. If the topic'

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1499: --- Attachment: KAFKA-1499_2014-08-15_14:20:27.patch > Broker-side compression configuration > --

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Aug. 15, 2014, 8:53 a.m.) Review request for kafka. Bugs: KAFKA-1499

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098324#comment-14098324 ] Nicolae Marasoiu edited comment on KAFKA-1282 at 8/15/14 8:45 AM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098324#comment-14098324 ] Nicolae Marasoiu edited comment on KAFKA-1282 at 8/15/14 8:35 AM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098324#comment-14098324 ] Nicolae Marasoiu edited comment on KAFKA-1282 at 8/15/14 8:19 AM: --

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098324#comment-14098324 ] Nicolae Marasoiu edited comment on KAFKA-1282 at 8/15/14 8:14 AM: --

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098324#comment-14098324 ] Nicolae Marasoiu commented on KAFKA-1282: - Hi, I am sorry, but traversing will be