Re: Review Request 31850: Patch for KAFKA-1660

2015-04-20 Thread Jiangjie Qin
On April 20, 2015, 5:30 p.m., Jay Kreps wrote: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, line 526 https://reviews.apache.org/r/31850/diff/9/?file=931818#file931818line526 I cleaned up this javadoc a little bit to try to simplify things. With

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Gwen Shapira
I admit that I'm also not sure what we gain by having deny rules. A user is either in the allow list (one way or another) or it will be denied by default. I think this is something we can skip for now and add later if needed? On Mon, Apr 20, 2015 at 5:24 PM, Jun Rao j...@confluent.io wrote:

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-20 Thread Jiangjie Qin
Jun, I thought a little bit differently on this. Intuitively, I am thinking that if a partition is offline, the metadata for that partition should be considered not ready because we don’t know which broker we should send the message to. So those sends need to be blocked on metadata timeout.

RE: Can't see KIP Template after click Create on https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

2015-04-20 Thread Honghai Chen
It works, many thanks. Thanks, Honghai From: Joe Stein [mailto:joe.st...@stealth.ly] Sent: Tuesday, April 21, 2015 9:24 AM To: Honghai Chen Cc: dev@kafka.apache.org Subject: Re: Can't see KIP Template after click Create on

[jira] [Updated] (KAFKA-1910) Refactor KafkaConsumer

2015-04-20 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1910: -- Resolution: Fixed Status: Resolved (was: Patch Available) The follow-up has been committed

[jira] [Assigned] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-1595: -- Assignee: Ismael Juma Remove deprecated and slower scala JSON parser from

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504095#comment-14504095 ] Ismael Juma commented on KAFKA-1595: Since there were no objections in the mailing

Re: [DISCUSS] KIP-12 - Kafka Sasl/Kerberos implementation

2015-04-20 Thread Sriharsha Chintalapani
Hi Jun,            I am using the underlying protocol GSS-API that sasl also uses. I can add details about LDAP/AD . For AD , this is in general the integration of AD to KERBEROS. I.e   kerberos can talk to AD to get the kinit login credentials ( more of a setup details between kerberos and AD)

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Parth Brahmbhatt
Here is a pseudo code that explains my current approach: acls = authorizer.getAcl(resource) if(acls == null || acls.isEmpty) { allow all requests for backward compatibility. (any topics that were created prior to security support will not have acls) This is debatable , generally we

[jira] [Commented] (KAFKA-2035) Add a topic config cache.

2015-04-20 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503888#comment-14503888 ] Parth Brahmbhatt commented on KAFKA-2035: - Makes sense. I will close this jira and

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

2015-04-20 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2136: --- Reviewer: Joel Koshy Client side protocol changes to return quota delays

[jira] [Created] (KAFKA-2136) Client side protocol changes to return quota delays

2015-04-20 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2136: -- Summary: Client side protocol changes to return quota delays Key: KAFKA-2136 URL: https://issues.apache.org/jira/browse/KAFKA-2136 Project: Kafka Issue

Re: Review Request 33378: Patch for KAFKA-2136

2015-04-20 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated April 21, 2015, 12:02 a.m.) Review request for kafka and Joel Koshy.

Re: Review Request 33378: Patch for KAFKA-2136

2015-04-20 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated April 21, 2015, 12:02 a.m.) Review request for kafka and Joel Koshy.

Can't see KIP Template after click Create on https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

2015-04-20 Thread Honghai Chen
Hi dear dev, Need create on KIP with title Add one configuration log.preallocate for https://issues.apache.org/jira/browse/KAFKA-1646 But can't see KIP Template after click Create on https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

[jira] [Updated] (KAFKA-2035) Add a topic config cache.

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-2035: - Status: In Progress (was: Patch Available) [~parth.brahmbhatt] Unless you object I'd prefer to either

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Jun Rao
According to the pseudo code, if you have a rule deny user1, then it essentially denies all users? Thanks, Jun On Mon, Apr 20, 2015 at 5:16 PM, Parth Brahmbhatt pbrahmbh...@hortonworks.com wrote: Here is a pseudo code that explains my current approach: acls = authorizer.getAcl(resource)

Re: Can't see KIP Template after click Create on https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

2015-04-20 Thread Joe Stein
give it a try now ~ Joe Stein - - - - - - - - - - - - - - - - - http://www.stealth.ly - - - - - - - - - - - - - - - - - On Mon, Apr 20, 2015 at 9:22 PM, Honghai Chen honghai.c...@microsoft.com wrote: Username: waldenchen Email:waldenc...@163.com Thanks, Honghai -Original

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Michael Herstine
Hi Parth, OK, I understand your approach much better, now. I don’t really have a strong opinion; I guess I just shared Gwen’s concern (in the hangout) that, with this approach, if a site implements their own authorizer using their own ACL implementation, it will work, but they’ll have this

Review Request 33383: Patch for KAFKA-1595

2015-04-20 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33383/ --- Review request for kafka. Bugs: KAFKA-1595

Re: Can't see KIP Template after click Create on https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

2015-04-20 Thread Joe Stein
What is your confluence username? ~ Joe Stein - - - - - - - - - - - - - - - - - http://www.stealth.ly - - - - - - - - - - - - - - - - - On Mon, Apr 20, 2015 at 9:15 PM, Honghai Chen honghai.c...@microsoft.com wrote: Hi dear dev, Need create on KIP with title “Add one

[jira] [Updated] (KAFKA-2091) Expose a Partitioner interface in the new producer

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-2091: - Status: In Progress (was: Patch Available) Expose a Partitioner interface in the new producer

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1660: - Status: In Progress (was: Patch Available) Ability to call close() with a timeout on the Java Kafka

Re: Review Request 32650: Patch for KAFKA-2000

2015-04-20 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review80857 --- core/src/main/scala/kafka/server/OffsetManager.scala

[jira] [Updated] (KAFKA-2000) Delete consumer offsets from kafka once the topic is deleted

2015-04-20 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2000: -- Status: In Progress (was: Patch Available) Delete consumer offsets from kafka once the topic is

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-04-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Status: Patch Available (was: In Progress) Ability to call close() with a timeout on the Java

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-04-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504039#comment-14504039 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Sriharsha Chintalapani
 According to the pseudo code, if you have a rule deny user1, then it  essentially denies all users?  Gwen,       I see “deny” being useful. I.e you want to allow everyone except few users. This is probably a common case otherwise without deny you have to add long list of users who should be

[GitHub] kafka pull request: Kafka 1595 remove deprecated json parser

2015-04-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/55 Kafka 1595 remove deprecated json parser You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-1595-remove-deprecated-json-parser

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Jun Rao
Hmm, I thought the semantics is that if you only have rule deny user2, it means that everyone except user2 has access? Thanks, Jun On Mon, Apr 20, 2015 at 3:25 PM, Parth Brahmbhatt pbrahmbh...@hortonworks.com wrote: user3 does not have access and removing the deny rule does not grant him or

[jira] [Updated] (KAFKA-1933) Fine-grained locking in log append

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1933: - Status: In Progress (was: Patch Available) These results are very good. I'm scared of the code. The

RE: Can't see KIP Template after click Create on https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

2015-04-20 Thread Honghai Chen
Username: waldenchen Email:waldenc...@163.com Thanks, Honghai -Original Message- From: Joe Stein [mailto:joe.st...@stealth.ly] Sent: Tuesday, April 21, 2015 9:19 AM To: dev@kafka.apache.org Subject: Re: Can't see KIP Template after click Create on

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1646: - Status: In Progress (was: Patch Available) Improve consumer read performance for Windows

Review Request 33378: Patch for KAFKA-2136

2015-04-20 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- Review request for kafka. Bugs: KAFKA-2136

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

2015-04-20 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503976#comment-14503976 ] Aditya A Auradkar commented on KAFKA-2136: -- Created reviewboard

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

2015-04-20 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2136: - Attachment: KAFKA-2136.patch Client side protocol changes to return quota delays

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Gwen Shapira
Wouldn't the everyone except few users be easier to manage through groups / roles? I think thats how its done in pretty much any system I can think of. Do you know any system with deny option? I don't feel strongly about this (i.e. its an extra feature, people can use it or not. maybe it will be

[jira] [Commented] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504099#comment-14504099 ] Ismael Juma commented on KAFKA-1054: Note that there are also some deprecation

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Michael Herstine
Ignore my last; I was catching up on this list hadn’t seen Gwen’s subsequent proposal. On 4/15/15, 5:15 PM, Parth Brahmbhatt pbrahmbh...@hortonworks.com wrote: Kafka currently stores logConfig overrides specified during topic creation in zookeeper, its just an instance of java.util.Properties

Re: Review Request 31850: Patch for KAFKA-1660

2015-04-20 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/ --- (Updated April 21, 2015, 12:38 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-1595: --- Status: Patch Available (was: Open) Remove deprecated and slower scala JSON parser from

[jira] [Updated] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-1595: --- Attachment: KAFKA-1595.patch Remove deprecated and slower scala JSON parser from

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-04-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504055#comment-14504055 ] Ismael Juma commented on KAFKA-1595: Created reviewboard

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504384#comment-14504384 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/ --- (Updated April 21, 2015, 5:48 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-20_22:48:31.patch prevent potential resource leak in

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Steven Wu
On April 21, 2015, 3:08 a.m., Guozhang Wang wrote: LGTM, besides one minor suggestion: could you move MockMetricsReporter to clients/src/test/java/org/apache/kafka/test? done. moved MockMetricsReporter to clients/src/test/java/org/apache/kafka/test - Steven

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-20 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504171#comment-14504171 ] Honghai Chen commented on KAFKA-1646: - Added KIP here and send out the email, will

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/#review80892 --- LGTM, besides one minor suggestion: could you move

Re: Can't see KIP Template after click Create on https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

2015-04-20 Thread Guozhang Wang
Joe, Is there a way to make everyone to be able to access template? There will be more and more folks asking that I think. Guozhang On Mon, Apr 20, 2015 at 6:25 PM, Honghai Chen honghai.c...@microsoft.com wrote: It works, many thanks. Thanks, Honghai From: Joe Stein

[DISCUSS] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-04-20 Thread Honghai Chen
I wrote a KIP for this after some discussion on KAFKA-1646. https://issues.apache.org/jira/browse/KAFKA-1646 https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system The RB is here:

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Todd Palino
I tend to agree with Parth's point here. Most ACL systems I run into have deny and allow. In general, you have a default policy of allow, then you follow your rules stopping at the first line that matches. If you would like a default deny policy, you have a bunch of allow rules and your last

Why can't see KIP Template after click Create?

2015-04-20 Thread 陈洪海
Hello everyone, Want to create KIP for https://issues.apache.org/jira/browse/KAFKA-1646; , but can't see KIP Template after click Create in page https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals . What should I do? Thanks.

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Parth Brahmbhatt
The iptables on unix supports the DENY operator, not that it should matter. The deny operator can also be used to specify ³allow user1 to READ from topic1 from all hosts but host1,host2². Again we could add a host group semantic and extra complexity around that, not sure if its worth it. In

Re: [DISCUSS] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-04-20 Thread Gwen Shapira
+1 (non-binding) Sure, makes sense :) Just make sure the doc for the config includes something like If you are using Kafka on Windows, you probably want to set it to true, so people will know how to use it without looking for the JIRA. On Mon, Apr 20, 2015 at 6:58 PM, Honghai Chen

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Gwen Shapira
Thanks for clarifying the logic. I'm +0 on the deny thing. IMO, its not really needed, but if you think its important, I don't object to having it in. Gwen On Mon, Apr 20, 2015 at 7:07 PM, Parth Brahmbhatt pbrahmbh...@hortonworks.com wrote: The iptables on unix supports the DENY operator, not

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-20 Thread Jun Rao
Jiangjie, Allowing messages to be accumulated in an offline partition could be useful since the partition may become available before the request timeout or linger time is reached. Now that we are planning to add a new timeout, it would be useful to think through whether/how that applies to

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Parth Brahmbhatt
user3 does not have access and removing the deny rule does not grant him or user2 access. user2 even without the deny rule will not have access. Thanks Parth On 4/20/15, 12:03 PM, Jun Rao j...@confluent.io wrote: Just a followup question. Suppose there are two rules. Rule1 allows user1 and

Re: [jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-20 Thread Colin Clark
unsubscribe On Apr 20, 2015, at 8:09 AM, Sriharsha Chintalapani (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502761#comment-14502761 ] Sriharsha

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-20 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502761#comment-14502761 ] Sriharsha Chintalapani commented on KAFKA-2122: --- [~wangbo23] This is for

[jira] [Updated] (KAFKA-2134) Producer blocked on metric publish

2015-04-20 Thread Vamsi Subhash Achanta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vamsi Subhash Achanta updated KAFKA-2134: - Description: Hi, We have a REST api to publish to a topic. Yesterday, we started

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-20 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502583#comment-14502583 ] 王博 commented on KAFKA-2122: --- Which version this patch is based on? I found

[jira] [Comment Edited] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-20 Thread Bo Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502583#comment-14502583 ] Bo Wang edited comment on KAFKA-2122 at 4/20/15 10:27 AM: -- Which

Jenkins build is back to normal : Kafka-trunk #470

2015-04-20 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/470/changes

Re: [DISCUSS] KIP-12 - Kafka Sasl/Kerberos implementation

2015-04-20 Thread Sriharsha Chintalapani
Hi,      I updated the KIP-12 with more details. Please take a look   https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=51809888 Thanks, Harsha On February 11, 2015 at 10:02:43 AM, Harsha (ka...@harsha.io) wrote: Thanks Joe. It will be part of KafkaServer and will run on its own

[jira] [Commented] (KAFKA-2035) Add a topic config cache.

2015-04-20 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503297#comment-14503297 ] Parth Brahmbhatt commented on KAFKA-2035: - [~jkreps] yes that is the difference I

Build failed in Jenkins: KafkaPreCommit #82

2015-04-20 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/82/changes Changes: [neha.narkhede] DelayedOperationTest.testRequestExpiry transient failure; reviewed by Neha Narkhede -- [...truncated 659 lines...] kafka.api.ProducerFailureHandlingTest

Re: Review Request 31850: Patch for KAFKA-1660

2015-04-20 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/#review80753 ---

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503279#comment-14503279 ] Steven Zhen Wu commented on KAFKA-2121: --- [~ewencp] I made two more changes in latest

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503278#comment-14503278 ] Steven Zhen Wu commented on KAFKA-2121: --- [~ewencp] I made two more changes in latest

Re: Review Request 33065: Patch for KAFKA-1928

2015-04-20 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33065/#review80761 ---

Re: Review Request 32781: Patch for KAFKA-2087

2015-04-20 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32781/#review80733 --- Ship it! Ship It! - Neha Narkhede On April 2, 2015, 5:29 p.m.,

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503261#comment-14503261 ] Jay Kreps commented on KAFKA-1646: -- Cool, this looks good to me. This introduces a new

[jira] [Created] (KAFKA-2135) New Kafka Producer Client: Send requests wait indefinitely if no broker is available.

2015-04-20 Thread David Hay (JIRA)
David Hay created KAFKA-2135: Summary: New Kafka Producer Client: Send requests wait indefinitely if no broker is available. Key: KAFKA-2135 URL: https://issues.apache.org/jira/browse/KAFKA-2135 Project:

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/#review80770 --- Ship it! New version with KafkaConsumer changes looks good, passes

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-20_09:51:51.patch prevent potential resource leak in

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/ --- (Updated April 20, 2015, 4:51 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503172#comment-14503172 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-04-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503179#comment-14503179 ] Jordan Zimmerman commented on KAFKA-873: [~nehanarkhede] - the major upside with

Re: Review Request 33027: Fix timing issue in DelayedOperationTest

2015-04-20 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33027/#review80742 --- Ship it! Ship It! - Neha Narkhede On April 9, 2015, 6:04 p.m.,

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/ --- (Updated April 20, 2015, 4:57 p.m.) Review request for kafka. Bugs:

Build failed in Jenkins: KafkaPreCommit #81

2015-04-20 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/81/changes Changes: [neha.narkhede] TopicConfigManager javadoc references incorrect paths; reviewed by Neha Narkhede -- [...truncated 1557 lines...] kafka.api.ProducerFailureHandlingTest

[jira] [Commented] (KAFKA-2035) Add a topic config cache.

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503222#comment-14503222 ] Jay Kreps commented on KAFKA-2035: -- Hey [~parth.brahmbhatt] I'm not picky about the

Re: Review Request 32869: Patch for KAFKA-2091

2015-04-20 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/#review80738 ---

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-04-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503169#comment-14503169 ] Neha Narkhede commented on KAFKA-873: - I'm not so sure yet that moving to Curator is a

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/ --- (Updated April 20, 2015, 4:52 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-20_09:52:46.patch prevent potential resource leak in

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503176#comment-14503176 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard

[jira] [Commented] (KAFKA-2091) Expose a Partitioner interface in the new producer

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503174#comment-14503174 ] Jay Kreps commented on KAFKA-2091: -- This is waiting on the KIP which would be the best

[jira] [Updated] (KAFKA-2057) DelayedOperationTest.testRequestExpiry transient failure

2015-04-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2057: - Resolution: Fixed Reviewer: Neha Narkhede Status: Resolved (was: Patch Available)

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-20_09:57:49.patch prevent potential resource leak in

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503190#comment-14503190 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard

[jira] [Commented] (KAFKA-2091) Expose a Partitioner interface in the new producer

2015-04-20 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503197#comment-14503197 ] Sriharsha Chintalapani commented on KAFKA-2091: --- [~jkreps] Thanks for the

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-20 Thread Joel Koshy
Hi Parth, Nice work on this KIP. I did another read through and had a few more comments (with edits after I went through the thread). Many of these comments were brought up by others as well, so it appears that the KIP would benefit from an update at this point to incorporate comments from the

[jira] [Updated] (KAFKA-2087) TopicConfigManager javadoc references incorrect paths

2015-04-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2087: - Reviewer: Neha Narkhede TopicConfigManager javadoc references incorrect paths

[jira] [Updated] (KAFKA-2087) TopicConfigManager javadoc references incorrect paths

2015-04-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-2087: - Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to trunk. Thanks!

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-20_09:06:09.patch prevent potential resource leak in

[jira] [Commented] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-04-20 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503051#comment-14503051 ] Fangmin Lv commented on KAFKA-2055: --- There is a case that the leader is shutting down

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503086#comment-14503086 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard

[jira] [Commented] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

2015-04-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503128#comment-14503128 ] Jay Kreps commented on KAFKA-2118: -- I don't think I'll get to it, go ahead without me.

  1   2   >