On June 18, 2015, 12:50 a.m., Jason Gustafson wrote:
core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines
229-236
https://reviews.apache.org/r/35231/diff/1/?file=980918#file980918line229
In manual group management, would we expect consumerId and generationId
On June 30, 2015, 4:14 p.m., Jun Rao wrote:
Thanks for the patch. A few comments below.
1. Could you add a unit test for this?
2. Also, we may have a similar issue when handling the failure of the
broker. Currently, the logic in the controller is that the controller will
only
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609426#comment-14609426
]
Ashish K Singh commented on KAFKA-972:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-972:
-
Status: Patch Available (was: In Progress)
MetadataRequest returns stale list of brokers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36030/
---
(Updated July 1, 2015, 1:42 a.m.)
Review request for kafka.
Bugs: KAFKA-972
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-972:
-
Attachment: KAFKA-972_2015-06-30_18:42:13.patch
MetadataRequest returns stale list of brokers
On June 25, 2015, 10:55 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 40
https://reviews.apache.org/r/33378/diff/8/?file=981582#file981582line40
I think we should add throttle time metrics to the old producer and
consumer as well. What
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/
---
(Updated July 1, 2015, 2:44 a.m.)
Review request for kafka, Joel Koshy and Jun
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609476#comment-14609476
]
Aditya A Auradkar commented on KAFKA-2136:
--
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/
---
(Updated July 1, 2015, 2:44 a.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34766/
---
(Updated June 30, 2015, 1:59 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi updated KAFKA-2229:
Attachment: KAFKA-2229_2015-06-30_16:59:17.patch
Phase 1: Requests and KafkaApis
[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608307#comment-14608307
]
Andrii Biletskyi commented on KAFKA-2229:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608309#comment-14608309
]
Andrii Biletskyi commented on KAFKA-2229:
-
Rebased to include KAFKA-2195.
Phase
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36030/#review90005
---
Thanks for the patch. A couple more comments.
[
https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609591#comment-14609591
]
Ross Black commented on KAFKA-873:
--
A more general mechanism could also support KAFKA-1793
On June 18, 2015, 12:50 a.m., Jason Gustafson wrote:
core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines
229-236
https://reviews.apache.org/r/35231/diff/1/?file=980918#file980918line229
In manual group management, would we expect consumerId and generationId
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608572#comment-14608572
]
Rajasekar Elango commented on KAFKA-1690:
-
[~harsha_ch] Thanks for working on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review89677
---
Thanks for the patch. A few comments below.
Also, we need to
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608583#comment-14608583
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
[~erajasekar] you can try
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1367:
---
Status: In Progress (was: Patch Available)
Broker topic metadata not kept in sync with ZooKeeper
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review89922
---
I have a few other comments which I can add later or discuss
On June 18, 2015, 12:50 a.m., Jason Gustafson wrote:
core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines
229-236
https://reviews.apache.org/r/35231/diff/1/?file=980918#file980918line229
In manual group management, would we expect consumerId and generationId
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-2168:
---
Attachment: KAFKA-2168_2015-06-30_10:54:22.patch
New consumer poll() can block other calls
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608743#comment-14608743
]
Jason Gustafson commented on KAFKA-2168:
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34789/
---
(Updated June 30, 2015, 5:55 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review89910
---
clients/src/main/java/org/apache/kafka/clients/ClientUtils.java
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608753#comment-14608753
]
Jason Gustafson commented on KAFKA-2168:
[~ewencp], there were some minor issues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33614/#review89919
---
Thanks for the patch. Just a few minor comments below.
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608883#comment-14608883
]
Ashish K Singh commented on KAFKA-2132:
---
Updated reviewboard
On June 30, 2015, 5:12 p.m., Jun Rao wrote:
Thanks for the patch. Just a few minor comments below.
Thanks Jun for the review.
On June 30, 2015, 5:12 p.m., Jun Rao wrote:
build.gradle, lines 389-391
https://reviews.apache.org/r/33614/diff/9/?file=991359#file991359line389
Could
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33614/
---
(Updated June 30, 2015, 7:07 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609046#comment-14609046
]
Ewen Cheslack-Postava commented on KAFKA-2304:
--
Patch works and looks fine to
[
https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stevo Slavic updated KAFKA-2304:
Attachment: KAFKA-2304-JMX.patch
Makes sense, changed.
Attached updated [^KAFKA-2304-JMX.patch]
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2132:
--
Attachment: KAFKA-2132_2015-06-30_12:07:23.patch
Move Log4J appender to a separate module
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34494/#review89940
---
core/src/main/scala/kafka/admin/AclCommand.scala (line 48)
On June 18, 2015, 12:50 a.m., Jason Gustafson wrote:
core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines
229-236
https://reviews.apache.org/r/35231/diff/1/?file=980918#file980918line229
In manual group management, would we expect consumerId and generationId
On June 30, 2015, 10:24 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java,
lines 933-937
https://reviews.apache.org/r/34789/diff/14/?file=996120#file996120line933
Wondering why we want to fetch for all assigned partitions if the
[
https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609220#comment-14609220
]
Michael Sandrof commented on KAFKA-2078:
We are experiencing the same issue in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34789/#review89971
---
40 matches
Mail list logo