Ismael Juma created KAFKA-2349:
--
Summary: `contributing` website page should link to Contributing
Code Changes wiki page
Key: KAFKA-2349
URL: https://issues.apache.org/jira/browse/KAFKA-2349
Project:
[
https://issues.apache.org/jira/browse/KAFKA-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2349:
---
Status: Patch Available (was: Open)
`contributing` website page should link to Contributing Code
On Mon, Jul 13, 2015 at 6:01 PM, Guozhang Wang wangg...@gmail.com wrote:
changing the statement in wiki that you could create a PR with
[KAFKA-] or [MINOR], [HOTFIX], etc
I went with this for now:
The PR title should usually be of the form [KAFKA-] Title, where
KAFKA- is the
On Mon, Jul 20, 2015 at 10:24 AM, Ismael Juma ism...@juma.me.uk wrote:
I went with this for now:
Actually, I changed it to the following to match our existing commit prefix
convention (instead of Spark's):
The PR title should usually be of the form KAFKA-; Title, where
KAFKA- is
Ismael Juma created KAFKA-2348:
--
Summary: Drop support for Scala 2.9
Key: KAFKA-2348
URL: https://issues.apache.org/jira/browse/KAFKA-2348
Project: Kafka
Issue Type: Task
Reporter:
[
https://issues.apache.org/jira/browse/KAFKA-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2349:
---
Attachment: KAFKA-2349.patch
Links to Contributing Code Changes, adds a section on contributing
[
https://issues.apache.org/jira/browse/KAFKA-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633397#comment-14633397
]
ASF GitHub Bot commented on KAFKA-2348:
---
GitHub user ijuma opened a pull request:
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/87
KAFKA-2348; Drop support for Scala 2.9
`testAll` passed locally.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
Thank you for voting. 72 hours have passed and the vote has passed with 5
binding +1s and 5 non-binding +1s.
I filed https://issues.apache.org/jira/browse/KAFKA-2348 and created a pull
request with the change.
Best,
Ismael
On Fri, Jul 17, 2015 at 11:26 AM, Ismael Juma ism...@juma.me.uk wrote:
[
https://issues.apache.org/jira/browse/KAFKA-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2348:
---
Status: Patch Available (was: Open)
`testAll` passed.
Drop support for Scala 2.9
Github user mosch closed the pull request at:
https://github.com/apache/kafka/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633579#comment-14633579
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani updated KAFKA-1690:
--
Attachment: KAFKA-1690_2015-07-20_06:10:42.patch
new java producer needs ssl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/
---
(Updated July 20, 2015, 1:10 p.m.)
Review request for kafka.
Bugs:
Hi,
All GitHub pull request builds were failing after we had a few successful
ones. This should now be fixed and the same issue should not happen again.
See the following for details:
https://issues.apache.org/jira/browse/BUILDS-99
Best,
Ismael
Github user abayer closed the pull request at:
https://github.com/apache/kafka/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fsaintjacques closed the pull request at:
https://github.com/apache/kafka/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633653#comment-14633653
]
ASF GitHub Bot commented on KAFKA-294:
--
Github user fsaintjacques closed the pull
Hello Ismael,
Can you please trigger the build for all of the currently opened pull
requests?
E.g. my PR https://github.com/apache/kafka/pull/85 last automatically added
comment is that the build has failed while it should have been success -
only javadocs changes are included in PR.
Kind
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92282
---
Ship it!
Ship It!
- Edward Ribeiro
On Julho 20, 2015, 5:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92286
---
clients/src/main/java/org/apache/kafka/clients/Metadata.java (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92293
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92296
---
Ship it!
Ship It!
- Ashish Singh
On July 20, 2015, 5:37 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92298
---
clients/src/main/java/org/apache/kafka/common/Cluster.java (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92301
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/
---
(Updated July 20, 2015, 7 p.m.)
Review request for kafka.
Bugs: KAFKA-1690
[
https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633766#comment-14633766
]
ASF GitHub Bot commented on KAFKA-2169:
---
Github user Parth-Brahmbhatt closed the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92288
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92290
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92291
---
clients/src/main/java/org/apache/kafka/common/Cluster.java (line
[
https://issues.apache.org/jira/browse/KAFKA-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alok Lal resolved KAFKA-1230.
-
Resolution: Cannot Reproduce
shell script files under bin don't work with cygwin (bash on windows)
Github user aloklal99 closed the pull request at:
https://github.com/apache/kafka/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2275:
--
Attachment: KAFKA-2275_2015-07-20_10:44:19.patch
Add a ListTopics() API to the new consumer
[
https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633891#comment-14633891
]
Ashish K Singh commented on KAFKA-2275:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92294
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92295
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92302
---
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633941#comment-14633941
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani updated KAFKA-1690:
--
Attachment: KAFKA-1690_2015-07-20_11:59:57.patch
new java producer needs ssl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92304
---
clients/src/main/java/org/apache/kafka/common/Cluster.java (line
Hi Jun,
Thanks for the close reading! Responses inline.
Thanks for the write-up. The single producer use case you mentioned makes
sense. It would be useful to include that in the KIP wiki.
Great -- I'll make sure that the wiki is clear about this.
1. What happens when the leader of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/
---
(Updated July 20, 2015, 5:44 p.m.)
Review request for kafka.
Bugs:
On July 19, 2015, 1:11 a.m., Jason Gustafson wrote:
Jason, thanks for your review! I looked into ConsumerNetworkClient/
NetwrokClient, Metadata and Cluster classes. On receiving metadataUpdate,
cluster instance in metadata is updated. However, when a topic is added by
consumer, it is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92289
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92292
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92299
---
clients/src/main/java/org/apache/kafka/common/Cluster.java (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92297
---
The per-key generalization is useful. As Jiangjie mentioned in KAFKA-2260,
one thing that we need to sort out is what happens if a produce request has
messages with different keys and some of the messages have expected offsets
while some others don't. Currently, the produce response has an error
Thanks Jun.
Thanks,
Mayuresh
On Mon, Jul 20, 2015 at 10:03 AM, Jun Rao j...@confluent.io wrote:
Added.
Thanks,
Jun
On Mon, Jul 20, 2015 at 9:48 AM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
My username is : mgharat
On Mon, Jul 20, 2015 at 9:46 AM, Mayuresh Gharat
acks=0 is a one-way send, the client doesn't need to wait on the response.
Whether this is useful sort of depends on the client implementation. The
new java producer does all sends async so waiting on a response isn't
really a thing. For a client that lacks this, though, as some of them do,
acks=0
Added.
Thanks,
Jun
On Mon, Jul 20, 2015 at 9:48 AM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
My username is : mgharat
On Mon, Jul 20, 2015 at 9:46 AM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
Hi,
I wanted to edit a KIP page and would like to get permission for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92276
---
core/src/main/scala/kafka/admin/TopicCommand.scala (line 89)
On July 20, 2015, 5:27 p.m., Ashish Singh wrote:
LGTM, just a small comment.
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92276
Github user Parth-Brahmbhatt closed the pull request at:
https://github.com/apache/kafka/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Hi,
I wanted to edit a KIP page and would like to get permission for that.
Currently I don't have edit authorization. It does not show me an option to
edit.
Can one of the committers grant me permission? Thanks.
--
-Regards,
Mayuresh R. Gharat
(862) 250-7125
On Mon, Jul 20, 2015 at 3:38 PM, Stevo Slavić ssla...@gmail.com wrote:
Can you please trigger the build for all of the currently opened pull
requests?
E.g. my PR https://github.com/apache/kafka/pull/85 last automatically
added
comment is that the build has failed while it should have been
[
https://issues.apache.org/jira/browse/KAFKA-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633748#comment-14633748
]
William Thurston commented on KAFKA-2236:
-
https://github.com/apache/kafka/pull/86
My username is : mgharat
On Mon, Jul 20, 2015 at 9:46 AM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
Hi,
I wanted to edit a KIP page and would like to get permission for that.
Currently I don't have edit authorization. It does not show me an option to
edit.
Can one of the
Github user jmlvanre closed the pull request at:
https://github.com/apache/kafka/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Hi, Ben,
Thanks for the write-up. The single producer use case you mentioned makes
sense. It would be useful to include that in the KIP wiki. A couple
questions on the design details.
1. What happens when the leader of the partition changes in the middle of a
produce request? In this case, the
[
https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633721#comment-14633721
]
Jay Kreps commented on KAFKA-2260:
--
Yes, exactly.
Allow specifying expected offset on
Hi, Everyone,
We plan to have a Kafka KIP meeting tomorrow at 11am PST. If you want to
attend, but haven't received an invitation, please let me know. The
following is the agenda.
Agenda:
KIP-27: Conditional publish
Go through jira backlogs:
Mayuresh,
You should already have the permissions.
Guozhang
On Mon, Jul 20, 2015 at 9:48 AM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
My username is : mgharat
On Mon, Jul 20, 2015 at 9:46 AM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
Hi,
I wanted to edit a KIP
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
---
(Updated July 20, 2015, 5:37 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Attachment: KAFKA-2337_2015-07-20_12:36:41.patch
Verify that metric names will not collide when
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633880#comment-14633880
]
Grant Henke commented on KAFKA-2337:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt reassigned KAFKA-824:
--
Assignee: Parth Brahmbhatt
java.lang.NullPointerException in commitOffsets
[
https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633776#comment-14633776
]
Parth Brahmbhatt commented on KAFKA-824:
[~techwhizbang] I upgraded to zkClient-0.5
Github user rocketraman closed the pull request at:
https://github.com/apache/kafka/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
I'm with you on the races that could happen in the scenarios you describe,
but I'm still not convinced that conditionally updating is the best call.
Instead of conditionally updating, the broker could fence off the old owner
to avoid spurious writes, and that's valid for all attempts. The
Jason Gustafson created KAFKA-2350:
--
Summary: Add KafkaConsumer pause capability
Key: KAFKA-2350
URL: https://issues.apache.org/jira/browse/KAFKA-2350
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634117#comment-14634117
]
Flavio Junqueira commented on KAFKA-2260:
-
I like the use of an array to increase
Thanks Ismael!
I agree clear failures or no failures is optimal. I did some hacky analysis
of the open files by running the tests and utilizing the lsof command.
In one run of the core tests I found the following:
- 4584 regular files (REG)
- 376 .jar files
- Not much one
It would be worth fleshing out the use cases a bit more and thinking
through the overlap with the other proposals for transactions and
idempotence (since likely we will end up with both).
The advantage of this proposal is that it is really simple.
If we go through use cases:
1. Stream
[
https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634069#comment-14634069
]
Gwen Shapira commented on KAFKA-313:
[~nehanarkhede] - mind if I review?
Add JSON/CSV
On July 19, 2015, 1:11 a.m., Jason Gustafson wrote:
Ashish Singh wrote:
Jason, thanks for your review! I looked into ConsumerNetworkClient/
NetwrokClient, Metadata and Cluster classes. On receiving metadataUpdate,
cluster instance in metadata is updated. However, when a topic is
[
https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634068#comment-14634068
]
Gwen Shapira commented on KAFKA-2299:
-
[~nehanarkhede] - mind if I review?
[
https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634080#comment-14634080
]
Ashish K Singh commented on KAFKA-2275:
---
I guess, it will be better to keep the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92323
---
Ship it!
LGTM.
Just a small nit.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634124#comment-14634124
]
Jason Gustafson commented on KAFKA-2350:
Sure, I just meant that if you fail to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92327
---
Ship it!
Ship It!
- Grant Henke
On July 20, 2015, 9:48 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634136#comment-14634136
]
Grant Henke commented on KAFKA-2337:
Updated reviewboard
I'm with you on the races that could happen in the scenarios you describe,
but I'm still not convinced that conditionally updating is the best call.
Instead of conditionally updating, the broker could fence off the old owner
to avoid spurious writes, and that's valid for all attempts. The
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-2350:
---
Description:
There are some use cases in stream processing where it is helpful to be able to
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634114#comment-14634114
]
Gwen Shapira commented on KAFKA-2350:
-
Cool feature :)
Can you clarify: If you skip
Hi all,
Is there any way I can force Zookeeper/Kafka to rebalance new consumers
only for subset of total number of partitions. I have a situation where out
of 120 partitions 60 have been already consumed, but the zookeeper also
assigns these empty/inactive partitions as well for the re-balancing,
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634126#comment-14634126
]
Gwen Shapira commented on KAFKA-2350:
-
oh, for some reason I expected heartbeats to be
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Attachment: KAFKA-2337_2015-07-20_16:48:25.patch
Verify that metric names will not collide when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
---
(Updated July 20, 2015, 9:48 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634151#comment-14634151
]
Jason Gustafson commented on KAFKA-2275:
[~singhashish], thanks for the response.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92307
---
clients/src/main/java/org/apache/kafka/common/Cluster.java (line
Up to Ben to clarify, but I'd think that in this case, it is up to the
logic of B to decide what to do. B knows that the offset isn't what it
expects, so it can react accordingly. If it chooses to try again, then it
should not violate any application invariant.
-Flavio
On Fri, Jul 17, 2015 at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92316
---
clients/src/main/java/org/apache/kafka/common/Cluster.java (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92309
---
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92313
---
On July 19, 2015, 1:11 a.m., Jason Gustafson wrote:
Ashish Singh wrote:
Jason, thanks for your review! I looked into ConsumerNetworkClient/
NetwrokClient, Metadata and Cluster classes. On receiving metadataUpdate,
cluster instance in metadata is updated. However, when a topic is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92315
---
[
https://issues.apache.org/jira/browse/KAFKA-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633756#comment-14633756
]
Joe Stein commented on KAFKA-2339:
--
I haven't had a chance to try to reproduce this yet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92345
---
core/src/main/scala/kafka/security/auth/Acl.scala (line 71)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/#review92347
---
core/src/main/scala/kafka/security/auth/PermissionType.scala (line
1 - 100 of 148 matches
Mail list logo