Re: [DISCUSS] KIP 151 - Expose Connector type in REST API

thanks for the feedback, it all sounds good. i have made the changes to the pr and the kip. dan On Fri, May 5, 2017 at 9:29 AM, Konstantine Karantasis < konstant...@confluent.io> wrote: > Thank you for the KIP. It's a nice improvement. > > Two small suggestions: > > 1) Let's not use all caps to

[GitHub] kafka pull request #2989: MINOR: Adding the RecordMetadata that is returned ...

GitHub user GeoSmith opened a pull request: https://github.com/apache/kafka/pull/2989 MINOR: Adding the RecordMetadata that is returned by the producer to the commitRecord method for SourceTask **Included:** - Added the producers record metadata object to the commitRecord

[GitHub] kafka pull request #2988: Added the producer record metadata to the SourceTa...

Github user GeoSmith closed the pull request at: https://github.com/apache/kafka/pull/2988 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2988: Added the producer record metadata to the SourceTa...

GitHub user GeoSmith opened a pull request: https://github.com/apache/kafka/pull/2988 Added the producer record metadata to the SourceTask commitRecord - Added the Producers Record Metadata object to the commitRecord method on the SourceTask class so more data is provided to those

Re: [DISCUSS]: KIP-149: Enabling key access in ValueTransformer, ValueMapper, and ValueJoiner

Hi, Thanks for comments. I extended PR and KIP to include rich functions. I will still have to evaluate the cost of deep copying of keys. Cheers, Jeyhun On Fri, May 5, 2017 at 8:02 PM Mathieu Fenniak wrote: > Hey Matthias, > > My opinion would be that documenting

[jira] [Commented] (KAFKA-4293) ByteBufferMessageSet.deepIterator burns CPU catching EOFExceptions

[ https://issues.apache.org/jira/browse/KAFKA-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999626#comment-15999626 ] ASF GitHub Bot commented on KAFKA-4293: --- Github user radai-rosenblatt closed the pull request at:

[GitHub] kafka pull request #2025: KAFKA-4293 - improve ByteBufferMessageSet.deepIter...

Github user radai-rosenblatt closed the pull request at: https://github.com/apache/kafka/pull/2025 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [VOTE] KIP-138: Change punctuate semantics

+1 Thanks, Bill On Sat, May 6, 2017 at 5:58 PM, Matthias J. Sax wrote: > +1 > > Thanks a lot for this KIP! > > -Matthias > > On 5/6/17 10:18 AM, Michal Borowiecki wrote: > > Hi all, > > > > Given I'm not seeing any contentious issues remaining on the discussion > >

Re: [VOTE] KIP-138: Change punctuate semantics

+1 Thanks a lot for this KIP! -Matthias On 5/6/17 10:18 AM, Michal Borowiecki wrote: > Hi all, > > Given I'm not seeing any contentious issues remaining on the discussion > thread, I'd like to initiate the vote for: > > KIP-138: Change punctuate semantics > >

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hi Matthias, Agreed. I tried your proposal and indeed it would work. However, I think to maintain full backward compatibility we would also need to deprecate Stores.create() and leave it unchanged, while providing a new method that returns the more strongly typed Factories. ( This is

Build failed in Jenkins: kafka-trunk-jdk7 #2155

See Changes: [jason] KAFKA-5121; Implement transaction index for KIP-98 -- [...truncated 1.67 MB...] kafka.log.BrokerCompressionTest > testBrokerSideCompression[4]

Build failed in Jenkins: kafka-trunk-jdk8 #1489

See Changes: [jason] KAFKA-5121; Implement transaction index for KIP-98 -- [...truncated 857.66 KB...] kafka.integration.SaslPlaintextTopicMetadataTest >

[jira] [Commented] (KAFKA-5121) Implement transaction index for KIP-98

[ https://issues.apache.org/jira/browse/KAFKA-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999524#comment-15999524 ] ASF GitHub Bot commented on KAFKA-5121: --- Github user asfgit closed the pull request at:

[GitHub] kafka pull request #2910: KAFKA-5121: Implement transaction index for KIP-98

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (KAFKA-5121) Implement transaction index for KIP-98

[ https://issues.apache.org/jira/browse/KAFKA-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-5121. Resolution: Fixed Issue resolved by pull request 2910

[jira] [Commented] (KAFKA-3353) Remove deprecated producer configs.

[ https://issues.apache.org/jira/browse/KAFKA-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999519#comment-15999519 ] ASF GitHub Bot commented on KAFKA-3353: --- GitHub user ijuma opened a pull request:

[GitHub] kafka pull request #2987: KAFKA-3353: Remove deprecated producer configs

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/2987 KAFKA-3353: Remove deprecated producer configs These configs have been deprecated since 0.9.0.0: block.on.buffer.full, metadata.fetch.timeout.ms and timeout.ms You can merge this pull request

[jira] [Updated] (KAFKA-3353) Remove deprecated producer configs.

[ https://issues.apache.org/jira/browse/KAFKA-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3353: --- Assignee: Ismael Juma (was: Ashish Singh) Status: Patch Available (was: Open) > Remove

Re: [VOTE] KIP-144: Exponential backoff for broker reconnect attempts

+1 ! On May 6, 2017 4:49 AM, "Edoardo Comar" wrote: > +1 (non binding) > thanks > -- > Edoardo Comar > IBM MessageHub > eco...@uk.ibm.com > IBM UK Ltd, Hursley Park, SO21 2JN > > IBM United Kingdom Limited Registered in England

[VOTE] KIP-138: Change punctuate semantics

Hi all, Given I'm not seeing any contentious issues remaining on the discussion thread, I'd like to initiate the vote for: KIP-138: Change punctuate semantics https://cwiki.apache.org/confluence/display/KAFKA/KIP-138%3A+Change+punctuate+semantics Thanks, Michał -- Signature

Re: [DISCUSS] KIP-133: List and Alter Configs Admin APIs

Hi James, Yes, that's right, it will return all config values. For topic configs, that means falling back to the respective broker config value, which could also be a default. If we fallback to the broker config (whether it's a default or not), is_default will be true. Does this make sense? And

[jira] [Updated] (KAFKA-5099) Replica Deletion Regression from KIP-101

[ https://issues.apache.org/jira/browse/KAFKA-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-5099: --- Status: Patch Available (was: Open) > Replica Deletion Regression from KIP-101 >

Re: [VOTE] KIP-144: Exponential backoff for broker reconnect attempts

+1 (non binding) thanks -- Edoardo Comar IBM MessageHub eco...@uk.ibm.com IBM UK Ltd, Hursley Park, SO21 2JN IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth,

Re: [DISCUSS] KIP-153 : Include only client traffic in BytesOutPerSec metric

Thanks for the KIP, Jun We're constantly reminded of this inconsistency when we look at the traffic on the dashboards ! -- Edoardo Comar IBM MessageHub eco...@uk.ibm.com IBM UK Ltd, Hursley Park, SO21 2JN IBM United Kingdom Limited Registered in

[jira] [Commented] (KAFKA-5184) Transient failure: MultipleListenersWithAdditionalJaasContextTest.testProduceConsume

[ https://issues.apache.org/jira/browse/KAFKA-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999372#comment-15999372 ] Ismael Juma commented on KAFKA-5184: The relevant part is: {code} ava.lang.IllegalStateException:

[jira] [Work started] (KAFKA-4801) Transient test failure (part 2): ConsumerBounceTest.testConsumptionWithBrokerFailures

[ https://issues.apache.org/jira/browse/KAFKA-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4801 started by Armin Braun. -- > Transient test failure (part 2): >