[GitHub] kafka pull request #3621: KAFKA-5694; Add ChangeReplicaDirRequest and Descri...

2017-08-03 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/3621 KAFKA-5694; Add ChangeReplicaDirRequest and DescribeReplicaDirRequest (KIP-113) You can merge this pull request into a Git repository by running: $ git pull

Re: [DISCUSS] KIP-113: Support replicas movement between log directories

2017-08-03 Thread Dong Lin
Hi all, I realized that we need new API in AdminClient in order to use the new request/response added in KIP-113. Since this is required by KIP-113, I choose to add the new interface in this KIP instead of creating a new KIP. The documentation of the new API in AdminClient can be found here

[jira] [Resolved] (KAFKA-5665) Incorrect interruption invoking method used for Heartbeat thread

2017-08-03 Thread huxihx (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx resolved KAFKA-5665. --- Resolution: Not A Bug > Incorrect interruption invoking method used for Heartbeat thread >

[GitHub] kafka pull request #3586: KAFKA-5665: Heartbeat thread should use correct in...

2017-08-03 Thread huxihx
Github user huxihx closed the pull request at: https://github.com/apache/kafka/pull/3586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3620: KAFKA-5700: Producer should not drop header inform...

2017-08-03 Thread huxihx
GitHub user huxihx opened a pull request: https://github.com/apache/kafka/pull/3620 KAFKA-5700: Producer should not drop header information when splitting batches Producer should not drop header information when splitting batches. This PR also corrects a minor typo in

[jira] [Created] (KAFKA-5700) producer missed header information when splitting batches

2017-08-03 Thread huxihx (JIRA)
huxihx created KAFKA-5700: - Summary: producer missed header information when splitting batches Key: KAFKA-5700 URL: https://issues.apache.org/jira/browse/KAFKA-5700 Project: Kafka Issue Type: Bug

[DISCUSS] KIP-178: Size-based log directory selection strategy

2017-08-03 Thread Hu Xi
Hi Dong, some thoughts on your second mail. Since currently logs for multiple partitions are created sequentially not in parallel, it's probably okay for us to simply select the directory with most disk spaces in a single round of `nextLogDir` calling. which can be guaranteed to lead to extreme

[VOTE] KIP-177: Consumer perf tool should count rebalance time

2017-08-03 Thread Hu Xi
Hi all, I'd like to kick off the vote for KIP-177: https://cwiki.apache.org/confluence/display/ARIES/KIP-177%3A+Consumer+perf+tool+should+count+rebalance+time. A PR for this KIP can be found at https://github.com/apache/kafka/pull/3188

[GitHub] kafka pull request #3619: MINOR: Update dependencies for 1.0.0 release

2017-08-03 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3619 MINOR: Update dependencies for 1.0.0 release Notable updates: 1. Gradle 4.1 includes a number of performance and CLI improvements as well as initial Java 9 support. There's also the

Re: [DISCUSS] KIP-180: Add a broker metric specifying the number of consumer group rebalances in progress

2017-08-03 Thread Guozhang Wang
>From an ops person's view who are mostly likely watching the metrics these names may not be very clear as people may not know the internals well. I'd prefer PrepareRebalance and CompleteRebalance since they may be easier to understand thought not 100 percent accurately match to internal

[GitHub] kafka pull request #3618: KAFKA-5698: Sort processor nodes based on its sub-...

2017-08-03 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3618 KAFKA-5698: Sort processor nodes based on its sub-tree size 1. Sort processor nodes within a sub-topology by its sub-tree size: nodes with largest sizes are source nodes and hence printed

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-08-03 Thread Sumant Tambe
I don't want to list the alternatives in the JIRA as rejected just yet because they are still being discussed. I would encourage the respective proposers to do that. It's a wiki after all. As per my current understanding, there are two alternatives being proposed. The original kip-91 approach #1

[GitHub] kafka pull request #3612: KAFKA-2507, KAFKA-2959: Remove legacy ControlledSh...

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (KAFKA-5699) Validate and Create connector endpoint should take the same format message body

2017-08-03 Thread Robin Moffatt (JIRA)
Robin Moffatt created KAFKA-5699: Summary: Validate and Create connector endpoint should take the same format message body Key: KAFKA-5699 URL: https://issues.apache.org/jira/browse/KAFKA-5699

[jira] [Resolved] (KAFKA-2507) Replace ControlledShutdown{Request,Response} with org.apache.kafka.common.requests equivalent

2017-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-2507. Resolution: Fixed Assignee: Jason Gustafson (was: Grant Henke) Fix Version/s:

Re: [DISCUSS] KIP-180: Add a broker metric specifying the number of consumer group rebalances in progress

2017-08-03 Thread Jason Gustafson
Hey Colin, Guozhang, I agree the current state names are not ideal for end users. I tend to see the rebalance as joining the group and receiving the assignment. Maybe the states could be named in those terms? For example: RebalanceJoin and RebalanceAssignment. What do you think? -Jason On Fri,

[jira] [Resolved] (KAFKA-2959) Remove temporary mapping to deserialize functions in RequestChannel

2017-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-2959. Resolution: Fixed Assignee: Jason Gustafson Fix Version/s: 1.0.0 > Remove temporary

Re: Consumer assign vs subscribe influence on __consumer_offset

2017-08-03 Thread Jason Gustafson
Hey Paolo, When you use the subscribe() API, you are using Kafka for group coordination. All members with the same group.id will balance the partitions of subscribed topics between themselves. When you use assign(), no such balancing takes place but you can still using Kafka to store offsets.

[jira] [Created] (KAFKA-5698) Sort processor node based on name suffix in TopologyDescription.toString()

2017-08-03 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-5698: Summary: Sort processor node based on name suffix in TopologyDescription.toString() Key: KAFKA-5698 URL: https://issues.apache.org/jira/browse/KAFKA-5698 Project:

Re: Kafka Client for Swift 4

2017-08-03 Thread Jason Gustafson
Hi Kellan, Looks cool. If you tell me your user id, I can give you access to edit the wiki directly. -Jason On Fri, Jul 28, 2017 at 1:41 PM, Kellan Burket Cummings < kellan.bur...@gmail.com> wrote: > Here it is: https://github.com/kellanburket/franz > > Can someone with access to the Wiki

[jira] [Created] (KAFKA-5697) StreamThread.close() need to interrupt the stream threads to break the loop

2017-08-03 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-5697: Summary: StreamThread.close() need to interrupt the stream threads to break the loop Key: KAFKA-5697 URL: https://issues.apache.org/jira/browse/KAFKA-5697 Project:

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-08-03 Thread Jason Gustafson
Thanks for the KIP. Just a quick comment. Can you list the alternatives mentioned in the JIRA discussion in the rejected alternatives section? -Jason On Thu, Aug 3, 2017 at 3:09 PM, Sumant Tambe wrote: > Hi all, > > KIP-91 [1] is another attempt to get better control on

[GitHub] kafka pull request #3606: MINOR: Use commitId property if set

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-08-03 Thread Sumant Tambe
Hi all, KIP-91 [1] is another attempt to get better control on producer side timeouts. In essence we're proposing a new config named batch.expiry.ms that will cause batches in the accumulator to expire after the configured timeout. Recently, the discussion on KAFKA-5621 [2] has shed new light

Re: [DISCUSS] KIP-179: Change ReassignPartitionsCommand to use AdminClient

2017-08-03 Thread Dong Lin
Hey Tom, Thanks for the KIP. It seems that the prior discussion in this thread has focused on reassigning partitions (or AlterTopics). I haven't looked into this yet. I have two comments on the replicaStatus() API and the ReplicaStatusRequest: - It seems that the use-case for

[GitHub] kafka pull request #3596: MINOR: Null out all buffer references in RequestCh...

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3617: HOTFIX add the hyper link for storage

2017-08-03 Thread guozhangwang
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3617 HOTFIX add the hyper link for storage You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-introduction-hyperlink

[GitHub] kafka-site issue #69: Hyperlink 3 callouts on the homepage

2017-08-03 Thread guozhangwang
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/69 LGTM. Merged to asf-site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] kafka-site pull request #69: Hyperlink 3 callouts on the homepage

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka-site/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3491: HOTFIX: Fixes to metric names

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (KAFKA-5696) SourceConnector does not commit offset on reconfiguration

2017-08-03 Thread Oleg Kuznetsov (JIRA)
Oleg Kuznetsov created KAFKA-5696: - Summary: SourceConnector does not commit offset on reconfiguration Key: KAFKA-5696 URL: https://issues.apache.org/jira/browse/KAFKA-5696 Project: Kafka

SASL SCRAM failing during Handshake

2017-08-03 Thread Quentin Derory
Hello, I have a 0.11.0.0 kafka cluster running with SSL and SASL SCRAM enabled connected with Zookeeper 3.5.3-beta SASL-Plain and SSL enabled. Kafka is connecting correctly to zookeeper(I replaced default zookeeper library with the corresponding cluster zookeeper library and added Netty library

Re: [VOTE] KIP-163: Lower the Minimum Required ACL Permission of OffsetFetch

2017-08-03 Thread Jason Gustafson
+1 On Wed, Aug 2, 2017 at 2:40 PM, Vahid S Hashemian wrote: > Hi all, > > Thanks to everyone who participated in the discussion on KIP-163, and > provided feedback. > The KIP can be found at > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

[GitHub] kafka pull request #3616: KAFKA-4541: Support for delegation token mechanism

2017-08-03 Thread omkreddy
GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/3616 KAFKA-4541: Support for delegation token mechanism You can merge this pull request into a Git repository by running: $ git pull https://github.com/omkreddy/kafka KAFKA-4541 Alternatively

Re: [DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-03 Thread Pranav Maniar
Thanks Jason ! I will create KIP for the same. On Wed, Aug 2, 2017 at 11:12 PM, Jason Gustafson wrote: > Hey Pranav, > > Thanks for raising this. I already commented on the JIRA, but I'll > reiterate my thoughts here. The "log cleaner" naming may not be ideal, but > it is

[GitHub] kafka pull request #3615: MINOR: Avoid duplicate processing of notifications...

2017-08-03 Thread omkreddy
GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/3615 MINOR: Avoid duplicate processing of notifications in ZkNodeChangeNotificationListener You can merge this pull request into a Git repository by running: $ git pull

答复: 答复: [DISCUSS] KIP-178: Size-based log directory selection strategy

2017-08-03 Thread Hu Xi
Dong, yes, many thanks for the comments from the second mail. Will take some time to figure out an algorithm to better handle the situation you mentioned. Thanks again. 发件人: Dong Lin 发送时间: 2017年8月3日 12:07 收件人: dev@kafka.apache.org 主题: Re:

Re: KStreamPrintTest : no differences in the unit tests

2017-08-03 Thread Paolo Patierno
Hi Damian, I submit the patch as part of this PR https://github.com/apache/kafka/pull/3611 adding a couple of other tests as well. Maybe you can take a look at it :-) Thanks ! Paolo Patierno Senior Software Engineer (IoT) @ Red Hat Microsoft MVP on Windows Embedded & IoT Microsoft