Re: [DISCUSS] KIP-232: Detect outdated metadata by adding ControllerMetadataEpoch field

Regarding the use of the global epoch in 65), it is very similar to the proposal of the metadata_epoch we discussed earlier. The main difference is that this epoch is incremented when we create/expand/delete topic and does not change when controller re-send metadata. I looked at our previous

Re: [DISCUSS] KIP-212: Enforce set of legal characters for connector names

great point, I'm always for exclusions where they make sense. i just prefer to include by default w/ exclusions when necessary to listing explicit inclusions and being restrictive. (and security updates immediately as needed). If you have a set of characters you think we should exclude, I think

[jira] [Created] (KAFKA-6436) Provide a metric indicating broker cluster membership state

Lukasz Mierzwa created KAFKA-6436: - Summary: Provide a metric indicating broker cluster membership state Key: KAFKA-6436 URL: https://issues.apache.org/jira/browse/KAFKA-6436 Project: Kafka

Jenkins build is back to normal : kafka-trunk-jdk8 #2320

See

Re: [DISCUSS] KIP-232: Detect outdated metadata by adding ControllerMetadataEpoch field

Hey Jun, Thanks so much. These comments very useful. Please see below my comments. On Mon, Jan 8, 2018 at 5:52 PM, Jun Rao wrote: > Hi, Dong, > > Thanks for the updated KIP. A few more comments. > > 60. Perhaps having a partition epoch is more flexible since in the future, >

Build failed in Jenkins: kafka-trunk-jdk7 #3086

See Changes: [wangguoz] MINOR: Menu updates and navigation (#4405) -- [...truncated 399.38 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

[jira] [Created] (KAFKA-6435) Application Reset Tool might delete incorrect internal topics

Matthias J. Sax created KAFKA-6435: -- Summary: Application Reset Tool might delete incorrect internal topics Key: KAFKA-6435 URL: https://issues.apache.org/jira/browse/KAFKA-6435 Project: Kafka

Build failed in Jenkins: kafka-trunk-jdk8 #2319

See Changes: [junrao] KAFKA-4247; Prevent CLASSPATH from beginning with a single colon -- [...truncated 401.78 KB...] kafka.integration.TopicMetadataTest >

Re: [DISCUSS] KIP 226 - Dynamic Broker Configuration

Thanks, Rajini. That makes sense. regards, Colin On Tue, Jan 9, 2018, at 14:38, Rajini Sivaram wrote: > Hi Colin, > > Thank you for reviewing. > > Yes, validation is done on the broker, not the client. > > All configs from ZooKeeper are processed and any config that could not be > applied

Build failed in Jenkins: kafka-trunk-jdk7 #3085

See Changes: [junrao] KAFKA-4247; Prevent CLASSPATH from beginning with a single colon -- [...truncated 399.51 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

Re: [DISCUSS] KIP 226 - Dynamic Broker Configuration

Hi Colin, Thank you for reviewing. Yes, validation is done on the broker, not the client. All configs from ZooKeeper are processed and any config that could not be applied are logged as warnings. This includes any configs that are not dynamic in the broker version or any configs that are not

Re: [DISCUSS] KIP 226 - Dynamic Broker Configuration

On Mon, Dec 18, 2017, at 13:40, Jason Gustafson wrote: > Hi Rajini, > > Looking good. Just a few questions. > > 1. (Related to Jay's comment) Is the validate() method on Reconfigurable > necessary? I would have thought we'd validate using the ConfigDef. Do you > have a use case in mind in which

Re: [DISCUSS] KIP-212: Enforce set of legal characters for connector names

On Sat, Jan 6, 2018, at 16:00, Ewen Cheslack-Postava wrote: > re: whitespace characters, I'm fine with the restriction since I don't see > it becoming an issue in practice. I just don't see any reason to restrict > it so it seems like we're going out of our way and doing extra work to be >

Re: [DISCUSS] KIP-240: AdminClient.listReassignments AdminClient.describeReassignments

What if we had an internal topic which watchers could listen to for information about partition reassignments? The information could be in JSON, so if we want to add new fields later, we always could. This avoids introducing a new AdminClient API. For clients that want to be notified about

Jenkins build is back to normal : kafka-1.0-jdk7 #121

See

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

+1 On Wed, 3 Jan 2018 at 03:49 Matthias J. Sax wrote: > It must be two different names, as we add two processor to the topology: > a source processor that only read the data from a topic, and the actual > processor that maintains the global table. > > > -Matthias > > On

Re: [DISCUSS] KIP 226 - Dynamic Broker Configuration

Hi Ismael, Thank you for reviewing the KIP. *password.encoder.iterations: 2048*: That was a mistake in the doc, changed to 4096, which is the minimum we use for SCRAM credentials *password.encoder.key.length: 128: *That is a key size that works with the default cipher algorithm. Will change if

Re: [DISCUSS] KIP 226 - Dynamic Broker Configuration

Hi Rajini, Quick question (sorry if this was already discussed). How were the following chosen? Name: password.encoder.keyfactory.algorithm Type: String Default: PBKDF2WithHmacSHA512 if available, otherwise PBKDF2WithHmacSHA1 (e.g. Java7) Name: password.encoder.cipher.algorithm Type: String

Re: [VOTE] KIP-226 - Dynamic Broker Configuration

Thank you, Jun! I have updated the KIP. If there are no other comments or concerns, I will close the vote later today. Thanks, Rajini On Mon, Jan 8, 2018 at 10:57 PM, Jun Rao wrote: > Hi, Rajini, > > Thanks for the explanation. Then your suggestion sounds good to me. > >

[jira] [Resolved] (KAFKA-6171) [1.0.0] Logging is broken with Windows and Java 9

[ https://issues.apache.org/jira/browse/KAFKA-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-6171. -- Resolution: Duplicate > [1.0.0] Logging is broken with Windows and Java 9 >

[jira] [Resolved] (KAFKA-5850) Py4JJavaError: An error occurred while calling o40.loadClass. : java.lang.ClassNotFoundException: org.apache.spark.streaming.kafka.KafkaUtilsPythonHelper

[ https://issues.apache.org/jira/browse/KAFKA-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-5850. -- Resolution: Invalid Please reopen if you think the issue is related to kafka > Py4JJavaError: An

[jira] [Resolved] (KAFKA-3893) Kafka Broker ID disappears from /brokers/ids

[ https://issues.apache.org/jira/browse/KAFKA-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-3893. -- Resolution: Fixed Please reopen if the issue still exists. > Kafka Broker ID disappears from

[jira] [Created] (KAFKA-6434) Kafka-consumer-groups.sh reset-offsets does not work properly for not existing group

George Smith created KAFKA-6434: --- Summary: Kafka-consumer-groups.sh reset-offsets does not work properly for not existing group Key: KAFKA-6434 URL: https://issues.apache.org/jira/browse/KAFKA-6434