Re: [DISCUSS] KIP-486 Support for pluggable KeyStore and TrustStore

2019-08-15 Thread Maulin Vasavada
Hi Harsha/Colin I did the sample with a custom Provider for TrustStoreManager and tried using ssl.provider Kafka config AND the way KIP-492 is suggesting (by adding Provider programmatically instead of relying on ssl.provider+java.security. The below sample is followed by my detailed findings. I'l

Build failed in Jenkins: kafka-2.3-jdk8 #89

2019-08-15 Thread Apache Jenkins Server
See Changes: [cmccabe] MINOR: Fix bugs in handling zero-length ImplicitLinkedHashCollections -- [...truncated 2.92 MB...] kafka.utils.CoreUtilsTest > testTryAll PASSED kafka.

[jira] [Created] (KAFKA-8807) Flaky Test GlobalThreadShutDownOrderTest.shouldFinishGlobalStoreOperationOnShutDown

2019-08-15 Thread Sophie Blee-Goldman (JIRA)
Sophie Blee-Goldman created KAFKA-8807: -- Summary: Flaky Test GlobalThreadShutDownOrderTest.shouldFinishGlobalStoreOperationOnShutDown Key: KAFKA-8807 URL: https://issues.apache.org/jira/browse/KAFKA-8807

Jenkins build is back to normal : kafka-trunk-jdk11 #757

2019-08-15 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #3855

2019-08-15 Thread Apache Jenkins Server
See Changes: [jason] MINOR: Update the javadoc of SocketServer#startup(). (#7215) -- [...truncated 8.94 MB...] kafka.api.PlaintextConsumerTest > testInterceptorsWithWrongK

Re: [DISCUSS] KIP-401 TransformerSupplier/ProcessorSupplier enhancements

2019-08-15 Thread Paul Whalen
I updated the KIP (and PR) to relax the restriction on connecting state stores via either means; it definitely makes sense to me at this point. I'd love to hear if there are any other concerns or broad objections to the KIP. Paul On Thu, Aug 8, 2019 at 10:12 PM Paul Whalen wrote: > Matthias, >

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

2019-08-15 Thread Ryanne Dolan
Thanks Chris, that makes sense. I know you have already considered this, but I'm not convinced we should rule out using Kafka topics for this purpose. That would enable the same level of security without introducing any new authentication or authorization mechanisms (your keys). And as you say, yo

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

2019-08-15 Thread Arjun Satish
Hey Konstantine, Thanks for the feedback. re: the use of log4j, yes, the proposed changes will only work if log4j is available in runtime. We will not add the mBean if log4j is not available in classpath. If we change from log4j 1 to 2, that would involve another KIP, and it would need to update

Re: [DISCUSS] KIP-504 - Add new Java Authorizer Interface

2019-08-15 Thread Colin McCabe
Thanks, Rajini. It looks good to me. best, Colin On Thu, Aug 15, 2019, at 11:37, Rajini Sivaram wrote: > Hi Colin, > > Thanks for the review. I have updated the KIP to move the interfaces for > request context and server info to the authorizer package. These are now > called AuthorizableReques

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-15 Thread Colin McCabe
On Thu, Aug 15, 2019, at 11:47, Jason Gustafson wrote: > Hey Colin, I think deleting all offsets is equivalent to deleting the > group, which can be done with the `deleteConsumerGroups` api. I debated > whether there should be a way to delete partitions for all unsubscribed > topics, but I decided

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

2019-08-15 Thread Chris Egerton
Hi Ryanne, Yes, if the Connect group is left unsecured then that is a potential vulnerability. However, in a truly secure Connect cluster, the group would need to be secured anyways to prevent attackers from joining the group with the intent to either snoop on connector/task configurations or brin

Re: [VOTE] KIP-396: Add Commit/List Offsets Operations to AdminClient

2019-08-15 Thread Guozhang Wang
+1 (binding). Thanks! Guozhang On Wed, Aug 14, 2019 at 5:18 PM Vahid Hashemian wrote: > +1 (binding) > > Thanks Michael for the suggestion of simplifying offset > retrieval/alteration operations. > > --Vahid > > On Wed, Aug 14, 2019 at 4:42 PM Bill Bejeck wrote: > > > Thanks for the KIP Mick

Build failed in Jenkins: kafka-trunk-jdk11 #756

2019-08-15 Thread Apache Jenkins Server
See Changes: [jason] MINOR: Update the javadoc of SocketServer#startup(). (#7215) -- [...truncated 2.59 MB...] org.apache.kafka.connect.runtime.rest.resources.ConnectorsR

Re: UnderReplicatedPartitions = 0 and UnderMinPartitionIsrCount > 0

2019-08-15 Thread Alexandre Dupriez
Hello James, Many thanks for your quick response and pointing out the associated JIRA. Happy to dig a bit on the function paths affected by a consistency check on these parameters, as explained in the ticket, and see what could be done (or not). Thanks, Alexandre Le mer. 14 août 2019 à 06:11, J

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-15 Thread Jason Gustafson
Hey Colin, I think deleting all offsets is equivalent to deleting the group, which can be done with the `deleteConsumerGroups` api. I debated whether there should be a way to delete partitions for all unsubscribed topics, but I decided to start with a simple API. I'm going to close this vote. The

Re: [DISCUSS] KIP-504 - Add new Java Authorizer Interface

2019-08-15 Thread Rajini Sivaram
Hi Colin, Thanks for the review. I have updated the KIP to move the interfaces for request context and server info to the authorizer package. These are now called AuthorizableRequestContext and AuthorizerServerInfo. Endpoint is now a class in org.apache.kafka.common to make it reusable since we al

Re: [DISCUSS] KIP-481: SerDe Improvements for Connect Decimal type in JSON

2019-08-15 Thread Konstantine Karantasis
Thanks! KIP reads even better for me now. Just voted. +1 non-binding Konstantine On Wed, Aug 14, 2019 at 7:00 PM Almog Gavra wrote: > Thanks for the review Konstantine! > > I think the terminology suggestion definitely makes things clearer - I will > update the documentation based on your sugge

Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON

2019-08-15 Thread Konstantine Karantasis
Thanks Almog! Nicely designed and concise KIP. +1 non-binding Konstantine On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra wrote: > Hello Everyone, > > After discussions on > > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E >

Re: Apply to be contributor of kafka

2019-08-15 Thread Matthias J. Sax
Thanks for you interest in Kafka! I added you to the list of contributors in Jira. You can now self-assign tickets. To get started check out the web-page: https://kafka.apache.org/contributing Let us know if you have any further questions. -Matthias On 8/14/19 5:55 PM, xiemian wrote: > Hello,

Re: Request permission

2019-08-15 Thread Matthias J. Sax
Done. On 8/14/19 6:30 PM, Mario Molina wrote: > Hi, > > I'd like to create a new page for a KIP in the Apache Kafka Confluence site. > The implementation of this KIP is already done but changes some things in > the API that should be approved. You can check it out here >

Re: [DISCUSS] KIP-373: Allow users to create delegation tokens for other users

2019-08-15 Thread Viktor Somogyi-Vass
Started to implement my proposition and thought about it a little bit more and it seems like I overthought the problem and we'd actually be better off by having only the User resource type only and not CreateUsers. The problem with CreateUsers is that a resource apparently is created only in addAcl

Re: [VOTE] KIP-499 - Unify connection name flag for command line tool

2019-08-15 Thread Jakub Scholz
+1 (non-binding) Jakub On Sat, Aug 10, 2019 at 8:34 PM Stanislav Kozlovski wrote: > Awesome KIP, +1 (non-binding) > > Thanks, > Stanislav > > On Fri, Aug 9, 2019 at 11:32 PM Colin McCabe wrote: > > > +1 (binding) > > > > cheers, > > Colin > > > > On Fri, Aug 9, 2019, at 09:56, Ron Dagostino wr

Build failed in Jenkins: kafka-trunk-jdk11 #755

2019-08-15 Thread Apache Jenkins Server
See Changes: [github] KAFKA-8788: Optimize client metadata handling with a large number of -- [...truncated 6.53 MB...] org.apache.kafka.connect.transforms.TimestampConve

Build failed in Jenkins: kafka-trunk-jdk8 #3854

2019-08-15 Thread Apache Jenkins Server
See Changes: [github] KAFKA-8788: Optimize client metadata handling with a large number of -- [...truncated 6.51 MB...] org.apache.kafka.connect.file.FileStreamSourceConne

Build failed in Jenkins: kafka-2.3-jdk8 #88

2019-08-15 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-8788: Optimize client metadata handling with a large number of -- Started by an SCM change [EnvInject] - Loading node environment variables. Buildi