RE: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

Regarding what I labeled the simplest solution below, SslConfigs could instantiate the custom interface only if the yet to be validated configs were passed in to the call to get the list of known SSL configs. -Original Message- From: Pellerin, Clement Sent: Tuesday, September 10, 2019 1

Re: [DISCUSS] KIP-448: Add State Stores Unit Test Support to Kafka Streams Test Utils

Just took a look at the current KIP, and I think you should actually be fine if you're just mocking the stores. The issue I brought up isn't necessarily blocking this KIP, but it is related -- just wanted to bring it up and see if there's any overlap, or if it's better to address separately. The p

[jira] [Resolved] (KAFKA-8817) Flaky Test KafkaProducerTest.testCloseIsForcedOnPendingAddOffsetRequest

[ https://issues.apache.org/jira/browse/KAFKA-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8817. -- Fix Version/s: 2.4.0 Assignee: Guozhang Wang Resolution: Fixed > Flaky Test Kaf

Build failed in Jenkins: kafka-trunk-jdk11 #806

See Changes: [bbejeck] KAFKA-8878: Fix flaky test -- [...truncated 2.62 MB...] org.apache.kafka.trogdor.basic.BasicPlatformTest > testCreateBasicPlatform PASSED org.apac

Build failed in Jenkins: kafka-trunk-jdk8 #3897

See Changes: [bbejeck] KAFKA-8878: Fix flaky test -- [...truncated 2.62 MB...] kafka.security.authorizer.AclAuthorizerTest > testAclManagementAPIs PASSED kafka.security.

[jira] [Resolved] (KAFKA-8747) Flaky Test ControllerEventManagerTest#testEventQueueTime

[ https://issues.apache.org/jira/browse/KAFKA-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8747. Resolution: Fixed > Flaky Test ControllerEventManagerTest#testEventQueueTime >

[jira] [Resolved] (KAFKA-7018) persist memberId for consumer restart

[ https://issues.apache.org/jira/browse/KAFKA-7018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-7018. Fix Version/s: 2.4.0 Resolution: Fixed > persist memberId for consumer restart > ---

[jira] [Resolved] (KAFKA-8222) Admin client changes to add ability to batch remove static members

[ https://issues.apache.org/jira/browse/KAFKA-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-8222. Resolution: Fixed > Admin client changes to add ability to batch remove static members > --

[jira] [Created] (KAFKA-8896) NoSuchElementException after coordinator move

Jason Gustafson created KAFKA-8896: -- Summary: NoSuchElementException after coordinator move Key: KAFKA-8896 URL: https://issues.apache.org/jira/browse/KAFKA-8896 Project: Kafka Issue Type: B

[jira] [Created] (KAFKA-8894) Flaky org.apache.kafka.streams.integration.ResetIntegrationTest.testReprocessingFromFileAfterResetWithoutIntermediateUserTopic

Stanislav Kozlovski created KAFKA-8894: -- Summary: Flaky org.apache.kafka.streams.integration.ResetIntegrationTest.testReprocessingFromFileAfterResetWithoutIntermediateUserTopic Key: KAFKA-8894 URL: https://is

[jira] [Created] (KAFKA-8895) Flaky org.apache.kafka.streams.integration.ResetIntegrationTest.testReprocessingFromDateTimeAfterResetWithoutIntermediateUserTopic

Stanislav Kozlovski created KAFKA-8895: -- Summary: Flaky org.apache.kafka.streams.integration.ResetIntegrationTest.testReprocessingFromDateTimeAfterResetWithoutIntermediateUserTopic Key: KAFKA-8895 URL: https:

[jira] [Created] (KAFKA-8893) Flaky ResetIntegrationTest. testReprocessingFromScratchAfterResetWithIntermediateUserTopic

Stanislav Kozlovski created KAFKA-8893: -- Summary: Flaky ResetIntegrationTest. testReprocessingFromScratchAfterResetWithIntermediateUserTopic Key: KAFKA-8893 URL: https://issues.apache.org/jira/browse/KAFKA-88

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

Hi Randall, Thanks so much for your comprehensive feedback! To avoid creating an extremely long response I'll address your comments/questions by referencing the identifiers you've provided for them as opposed to copying them and responding inline; hopefully things are still readable :) RE new co

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

I don't have a strong preference. So I am also fine to deprecate the existing methods. Let's see what Jason thinks. Can you update the KIP to reflect the semantics of the return `Map` (ie, does only contain entries for partitions with committed offsets, and does not contain `null` values)? +1 (b

[jira] [Resolved] (KAFKA-8878) Flaky Test AssignedStreamsTasksTest#shouldCloseCleanlyWithSuspendedTaskAndEOS

[ https://issues.apache.org/jira/browse/KAFKA-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-8878. Resolution: Fixed > Flaky Test AssignedStreamsTasksTest#shouldCloseCleanlyWithSuspendedTaskAndEOS >

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

Hi Jason / Matthias, I understand your concerns now. Just to clarify my main motivation on deprecating the old APIs is not only for aesthetics (confess I personally do have preference on succinct APIs), but to urge people to use the batched API for better latency when possible --- as stated in the

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

Thanks for the KIP Guozhang. > Another reason is that other functions of KafkaConsumers do not have those > overloaded functions to be consistent I tend to agree with Jason about keeping the existing methods. Your argument does not seem to hold. I just checked the `Consumer` API, and it's mix of

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

> I feel it not worth making committed to have both plurals and singulars. Not sure I agree. If we had started with these new APIs from the beginning, that may have been better, but we already have exposed the singular APIs and users are depending on them. Not sure it's worth breaking compatibili

Re: hope add permission to contribute

Done. On 9/10/19 6:52 AM, Xiangyuan LI wrote: > Hi: >I want to get permission to make some contribute, plz add me if > could,thx! > >my jira account: flashmouse >my wiki account: flashmouse > signature.asc Description: OpenPGP digital signature

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

Thanks Jason! On Tue, Sep 10, 2019 at 9:07 AM Jason Gustafson wrote: > Hi Guozhang, > > I think the motivation for the new API makes sense. I've wanted something > like this in the past. That said, do you think there is a substantial > benefit from deprecating the old API? I can still see it bei

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

Hi Guozhang, I think the motivation for the new API makes sense. I've wanted something like this in the past. That said, do you think there is a substantial benefit from deprecating the old API? I can still see it being convenient in some cases and it's no real cost to maintain. Also, just a mino

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

Thanks for the KIP Guozhang. +1 (binding) -Bill On Tue, Sep 10, 2019 at 9:09 AM Mickael Maison wrote: > +1 (non-binding), thanks Guozhang > > On Tue, Sep 10, 2019 at 1:14 AM Boyang Chen > wrote: > > > > Hey Guozhang, > > > > LGTM, +1 (non-binding) > > > > On Mon, Sep 9, 2019 at 5:07 PM Guozha

RE: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

Another solution could be a new standard ssl config that holds a list of extra custom configs to accept. Using a custom SslEngineFactory with custom configs would require setting two configs, one for the class name and another for the list of custom configs. In SslConfigs, we see that declaring a

Re: [DISCUSS] KIP-373: Allow users to create delegation tokens for other users

+1 non-binding Ryanne On Tue, Sep 10, 2019, 7:51 AM Viktor Somogyi-Vass wrote: > Bumping this in the hope I can get more feedback and/or votes. > > Thanks, > Viktor > > On Tue, Sep 3, 2019 at 1:49 PM Gabor Somogyi > wrote: > > > +1 (non-binding) I've had a deeper look and this would be a good

Build failed in Jenkins: kafka-trunk-jdk11 #805

See Changes: [wangguoz] KAFKA-8889: Log the details about error (#7317) -- [...truncated 940.26 KB...] org.apache.kafka.streams.state.internals.RocksDBKeyValueStoreTest >

hope add permission to contribute

Hi: I want to get permission to make some contribute, plz add me if could,thx! my jira account: flashmouse my wiki account: flashmouse

RE: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

Some of these items are copied from my email in the KIP-416 discussion. Custom config is a term I invented to mean a config that does not exist in Kafka but is specified by a custom implementation of SslEngineFactory. The problem with custom configs (as I remember it) is that the list of configs

Re: [VOTE] KIP-520: Augment Consumer.committed(partition) to allow multiple partitions

+1 (non-binding), thanks Guozhang On Tue, Sep 10, 2019 at 1:14 AM Boyang Chen wrote: > > Hey Guozhang, > > LGTM, +1 (non-binding) > > On Mon, Sep 9, 2019 at 5:07 PM Guozhang Wang wrote: > > > Hello folks, > > > > I've created a new KIP allowing consumer.committed to take a set of > > partitions

Re: [DISCUSS] KIP-373: Allow users to create delegation tokens for other users

Bumping this in the hope I can get more feedback and/or votes. Thanks, Viktor On Tue, Sep 3, 2019 at 1:49 PM Gabor Somogyi wrote: > +1 (non-binding) I've had a deeper look and this would be a good addition > to Spark. > > > On Thu, Aug 15, 2019 at 6:19 PM Viktor Somogyi-Vass < > viktorsomo...@g

[jira] [Created] (KAFKA-8892) Display the sorted configs in Kafka Configs Help Command.

Kamal Chandraprakash created KAFKA-8892: --- Summary: Display the sorted configs in Kafka Configs Help Command. Key: KAFKA-8892 URL: https://issues.apache.org/jira/browse/KAFKA-8892 Project: Kafka

[jira] [Created] (KAFKA-8891) invalid assignment protocol

SAIRAM KODURU created KAFKA-8891: Summary: invalid assignment protocol Key: KAFKA-8891 URL: https://issues.apache.org/jira/browse/KAFKA-8891 Project: Kafka Issue Type: Bug Reporte

Re: [DISCUSS] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

Hi, I have checked the KIP-399 and the discussion and also KIP-210. So the question we need to answer is whether it's okay to also skip writing the record in the internal topics, the current implementation of 'ProductionExceptionHandler' is applied for all topics and if we decided to keep it tha